Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge Target for Packages using the latest Spectrum CSS v3.0.0 dependency #790

Merged
merged 44 commits into from
Aug 29, 2020
Merged

Merge Target for Packages using the latest Spectrum CSS v3.0.0 dependency #790

merged 44 commits into from
Aug 29, 2020

Conversation

Westbrook
Copy link
Contributor

@Westbrook Westbrook commented Jul 24, 2020 •
edited
Loading

Includes:
#754
#761
#783
#785
#794
#810
#817
#824

Issues:
fixes #268
fixes #279
fixes #561
refs #199 only 4 left?

node_modules/@spectrum-css/tabs/dist/index-vars.css
44:1	⚠  :slotted() rules must be the last in the selector [postcss-process-spectrum]
48:1	⚠  :slotted() rules must be the last in the selector [postcss-process-spectrum]
120:1	⚠  :slotted() rules must be the last in the selector [postcss-process-spectrum]
222:1	⚠  :slotted() rules must be the last in the selector [postcss-process-spectrum]

fixes #513
fixes #543
fixes #568
fixes #662
fixes #750
fixes #753
fixes #793
fixes #845

@Westbrook Westbrook force-pushed the spectrum-css-3 branch 2 times, most recently from f3e03da to c19087b Compare August 4, 2020 22:24
@Westbrook Westbrook force-pushed the spectrum-css-3 branch 2 times, most recently from 2d808ae to 4482efa Compare August 6, 2020 15:10
@Westbrook Westbrook added a11y Issues related to accessibility Spectrum labels Aug 8, 2020
@Westbrook
Copy link
Contributor Author

Liz from the Material Web Component's team shared this great research demo for expanding baseline support for [dir] in a base class: https://jsbin.com/qomimoxoyu/edit?html,output

@Westbrook Westbrook force-pushed the spectrum-css-3 branch 4 times, most recently from 0eea972 to 3524582 Compare August 18, 2020 12:06
@Westbrook Westbrook force-pushed the spectrum-css-3 branch 4 times, most recently from cf19168 to 26c50f6 Compare August 27, 2020 23:18
Westbrook and others added 15 commits August 28, 2020 14:53
@Westbrook
feat(base): insert Spectrum base class/mixin
253f84c
@Westbrook
build: process [dir="ltr|rtl"] entries in Spectrum CSS
759e654
@Westbrook
feat: use 3.0.0-beta.* release for styles
82d385a
@Westbrook
feat(accordion): add accordion pattern
c957809
@Westbrook
refactor: update Spectrum CSS processing for expanded coverage
d779c7f
@Westbrook
feat(split-button): add split-button pattern
949eea8
@Westbrook
fix(tags): support distant sibling selectors
1a2b6b2
@Westbrook
test(split-button): inject more time into test
e449c1b
@Westbrook
fix(tags): correct render types
9bf880f
@Westbrook
fix(split-button): follow visible tab order
3327984
@Westbrook
feat(textfield): use Spectrum CSS ^3.0.0
131ff66
@Westbrook
feat(search): use Spectrum CSS ^3.0.0
74736e1
@Westbrook
feat(action-group): add action-group pattern
b6596d9
@Westbrook
refactor(button): exclude CSS meant for other elements
9f6eda1
@Westbrook
feat(quick-actions): add quick-actions pattern
5f40391
Westbrook Johnson and others added 22 commits August 28, 2020 14:58
@Westbrook
test: address coverage
d67fe57
@Westbrook
feat: observe document.documentElement for dir value
3d78260
@Westbrook
docs: support RTL delivery
5d3ac13
@Westbrook
docs: support RTL across all stories
3a866ee
@Westbrook
refactor: leverage cleaner types
f5dc67b
@Westbrook
ci: expand visual regressions to RTL
a55b575
@Westbrook
ci: update golden images cache
ae256e6
@Westbrook
fix(tabs): bind tabindicator update to dir value
81286c9
@Westbrook
feat: allow dir management by sp-theme elements
a0b4a59
@Westbrook
ci: update golden images cache
11657f6
@Westbrook
refactor: use isLTR instead of isDefaultDir
7b9742b
@Westbrook
docs: outline "dir" support in elements and themes
b512ab4
@Westbrook
docs: keep "dir" decisions for docs site in localStorage
492e226
@Westbrook
refactor(split-button): catch up to upstream changes in Dropdown
2ff8410
@Westbrook
ci: update golden images cache
a31dd08
@Westbrook
feat(split-button): add split-button pattern
0b904cc
@Westbrook
ci: update golden images cache
e2fcec3
@Westbrook
ci: update golden images cache
c7a9943
@Westbrook
refactor: use shared slot presence mixin for conditional element styling
5592657
@Westbrook
refactor: centralize on @spectrum-web-components/base for lit-* exports
4d7ac1c
@Westbrook
refactor(base): export "ifDefined" from "lit-html"
96d3998
@Westbrook
docs: clarify language in README
acfe6a9
@Westbrook Westbrook force-pushed the spectrum-css-3 branch 2 times, most recently from 62c088d to d3bc6f4 Compare August 28, 2020 19:59
@Westbrook Westbrook merged commit 288b31a into main Aug 29, 2020
@Westbrook Westbrook deleted the spectrum-css-3 branch August 29, 2020 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
a11y Issues related to accessibility Spectrum
Projects
None yet
Milestone
No milestone
1 participant
@Westbrook