Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toast close button does not have a sufficient focus style #753

Closed
jnurthen opened this issue Jul 9, 2020 · 1 comment · Fixed by #790
Closed

Toast close button does not have a sufficient focus style #753

jnurthen opened this issue Jul 9, 2020 · 1 comment · Fixed by #790
Labels
a11y Issues related to accessibility

Comments

@jnurthen
Copy link
Member

jnurthen commented Jul 9, 2020

Expected Behaviour

The focus style should be discernable to people with low vision

Actual Behaviour

The focus style is too subtle
Screen Shot showing the keyboard focus style on the toast close button

Reproduce Scenario (including but not limited to)

Steps to Reproduce

Platform and Version

Chrome 83
Safari 14
FF 78

Sample Code that illustrates the problem

Logs taken while reproducing problem
@Westbrook
Copy link
Contributor

Luckily, it seems that this will come for free with the upgrade to Spectrum CSS 3.0.0 for the button package! Check it out in development here: https://5f0b5f499b119400073dfbf6--spectrum-web-components.netlify.app/components/toast Yay. 🎆

@Westbrook Westbrook added the a11y Issues related to accessibility label Jul 16, 2020
@Westbrook Westbrook mentioned this issue Aug 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a11y Issues related to accessibility
Projects
None yet
Milestone
No milestone
2 participants
@Westbrook @jnurthen