[rfc|feature branch] Spectrum CSS 3.0.0 releases and '[dir="rtl|ltr"]' #754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Westbrook
force-pushed
the
westbrook/base
branch
from
a0e36aa
to
8c6f013
Compare
Westbrook
force-pushed
the
westbrook/base
branch
5 times, most recently
from
84ff0e1
to
9cd027d
Compare
Westbrook
force-pushed
the
westbrook/base
branch
6 times, most recently
from
1c70136
to
7febd88
Compare
Westbrook
commented
Jul 24, 2020
| @@ -17,7 +17,7 @@ module.exports = { | |||
| name: 'checkbox', | |||
| host: { | |||
| selector: '.spectrum-Checkbox', | |||
| shadowSelector: '#root', | |||
| // shadowSelector: '#root', | |||
There was a problem hiding this comment.
Actually remove this.
Westbrook
force-pushed
the
westbrook/base
branch
from
7febd88
to
863aaff
Compare
Westbrook
force-pushed
the
westbrook/base
branch
from
863aaff
to
843a9aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Spectrum CSS is getting close to a v3.0.0 release of all of its components and this branch should be able to serve as a base for testing out individual package upgrades.
SpectrumMixinandSpectrumElement, very open to alternate naming conventions if you have them.public shadowRoot!: ShadowRoot;to the element as we currently use shadow DOM in all of our elements and it's a pain to test for it in TS all the timeconnectedCallback()that queries document direction and then applies it to the element tag so that elements extending from his can have an[dir="rtl|ltr"]selector to leverage in their styles[dir="rtl|ltr"]selectors in the output by appending them to the host selector (by default they are included as "context" selectors the director corollary of which in shadow DOM are not available cross-browser)sp-actionbaras a very simple upgrade (just the version bump)sp-checkboxas a more complex upgrade (leverages mixins and requires DOM updates, etc.)I'm gonna work with the Spectrum CSS team and catch up on how they're documenting the lack of support for
dir="auto"in this update, as we'll need to include matching instructions in our docs so that users don't fall into any traps there. I'll also confirm whether the team is targeting any other specifically breaking changes (e.g. t-shirt sizes) before moving these releases to stable.Related Issue
related to #477
related to #513
related to #543
related to #669
related to #739
Motivation and Context
Need to keep up with out source material
How Has This Been Tested?
Types of changes
Checklist: