Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Andrew/accordion #783

Merged
merged 2 commits into from
Jul 24, 2020
Merged

Andrew/accordion #783

merged 2 commits into from
Jul 24, 2020

Conversation

andrewhatran
Copy link
Collaborator

Description

Implements the <sp-accordion> pattern.

leverages Spectrum CSS ^3.0.0

Related Issue

Issue 561

Motivation and Context

Pattern coverage

How Has This Been Tested?

Accessibility tests
Screenshot tests

Screenshots (if appropriate):

Screen Shot 2020-07-22 at 3 13 14 PM

Screen Shot 2020-07-22 at 3 13 31 PM

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@Westbrook Westbrook force-pushed the westbrook/base branch 2 times, most recently from 1c70136 to 7febd88 Compare July 24, 2020 15:50
@andrewhatran andrewhatran force-pushed the andrew/accordion branch 3 times, most recently from 2dc2637 to b6a6a04 Compare July 24, 2020 19:45
@Westbrook Westbrook force-pushed the westbrook/base branch 2 times, most recently from 863aaff to 843a9aa Compare July 24, 2020 20:12
Base automatically changed from westbrook/base to spectrum-css-3 July 24, 2020 20:59
@Westbrook Westbrook mentioned this pull request Jul 24, 2020
Merged
Westbrook
Westbrook approved these changes Jul 24, 2020
View reviewed changes
Copy link
Contributor

@Westbrook Westbrook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Great pre-PTO work here!

@andrewhatran andrewhatran merged commit d1bd638 into spectrum-css-3 Jul 24, 2020
@andrewhatran andrewhatran deleted the andrew/accordion branch July 24, 2020 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Westbrook Westbrook Westbrook approved these changes

Assignees
No one assigned
Labels
Component: Accordion
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrewhatran @Westbrook