Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hlx deploy] fails if project contains a submodule #614

Closed
kptdobe opened this issue Mar 4, 2019 · 4 comments
Closed

[hlx deploy] fails if project contains a submodule #614

kptdobe opened this issue Mar 4, 2019 · 4 comments
Assignees
@stefan-guggisberg
Labels
bug Something isn't working

Comments

@kptdobe
Copy link
Contributor

kptdobe commented Mar 4, 2019

Description
It seems that having a submodule in the project triggers an exception during hlx deploy.

To Reproduce
Steps to reproduce the behavior:

  1. git clone [email protected]:adobe/project-helix.io.git
  2. cd project-helix.io
  3. hlx build
  4. hlx deploy --wsk-auth <your_wsk_auth_token> --wsk-namespace <your_wsk_namespace>

Following error appears and stop the process: Failed to read git object with oid ce24eb86a33320577f1b66498629f21d22cda703

Version:
run: $ hlx --version
0.13.7-pre.0

Additional context
Some initial debugging with @stefan-guggisberg reveals that the isDirty check is the entry point. Then it seems that isomorphic-git does not co-op with submodules (getting git info on subdomains/helix-cli folder seems to be the trigger of the error)
@kptdobe kptdobe added the bug Something isn't working label Mar 4, 2019
@stefan-guggisberg stefan-guggisberg self-assigned this Mar 4, 2019
@stefan-guggisberg
Copy link
Contributor

This is a regression of #523 (replace shelljs git command line calls with isomorphic-git implementation).

I've created an isomorphic-git issue: isomorphic-git/isomorphic-git#707

@kptdobe kptdobe mentioned this issue Mar 4, 2019
Closed
stefan-guggisberg added a commit to adobe/git-server that referenced this issue Apr 17, 2019
@stefan-guggisberg
update isomorphic-git dependency (adobe/helix-cli#614)
7652885
stefan-guggisberg added a commit to adobe/helix-simulator that referenced this issue Apr 17, 2019
@stefan-guggisberg
fix(git-server): fix for adobe/helix-cli#614
ddd63e3 
adobe/helix-cli#614
stefan-guggisberg added a commit that referenced this issue Apr 17, 2019
@stefan-guggisberg
fix(GitUtils): GitUtils.isDirty: ignore git submodules
fcdc572 
#614
trieloff pushed a commit that referenced this issue Apr 17, 2019
@semantic-release-bot
chore(release): 0.14.15 [skip ci]
ecd504d 
## [0.14.15](v0.14.14...v0.14.15) (2019-04-17)

### Bug Fixes

* **GitUtils:** GitUtils.isDirty: ignore git submodules ([fcdc572](fcdc572)), closes [#614](#614)
@stefan-guggisberg
Copy link
Contributor

fixed in fcdc572

@tripodsan
Copy link
Contributor

tripodsan commented Apr 18, 2019 •
edited
Loading

Thanks for the fix, @stefan-guggisberg, but I'm not sure if it is 100% correct. AFAICS, the check now excludes the submodules completely. so if you have a modified file in the submodule path, then isDirty is still wrong. I created a new issue for this (#781).

@tripodsan tripodsan mentioned this issue Apr 18, 2019
Closed
@stefan-guggisberg
Copy link
Contributor

are submodules packaged? if yes i agree that dirty submodules should be considered.

@maxakuru maxakuru mentioned this issue Jun 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stefan-guggisberg stefan-guggisberg

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kptdobe @tripodsan @stefan-guggisberg