Modifications below a submodule are not detected as _dirty_

[tripodsan]

Description
with #614, it is now possible to use submodules (for better or worse). however, the isDirty() check ignores the submodule, so modifications below a submodule are not considered dirty. this is unexpected if it contains sources or static files, since the developer expects that what is packages with the current sha, would also be the one that is in the git repository.

[tripodsan]

adding this to the test case highlights the issue:

helix-cli/test/testGitUtils.js

Line 102 in 9bb976e

diff --git a/test/testGitUtils.js b/test/testGitUtils.js
index 7f4efea..8f9ecd5 100644
--- a/test/testGitUtils.js
+++ b/test/testGitUtils.js
@@ -100,6 +100,9 @@ describe('Testing GitUtils', () => {
     shell.exec('git commit -m "added submodule"');
     assert.equal(await GitUtils.isDirty(testRoot, GIT_USER_HOME), false);

+    await fse.writeFile(path.resolve(moduleRoot, 'README.md'), 'Hello, world.\n', 'utf-8');
+    assert.equal(await GitUtils.isDirty(testRoot, GIT_USER_HOME), true);
+
     await fse.remove(moduleRoot);
   });

[stefan-guggisberg]

are submodules packaged?

[tripodsan]

are submodules packaged?

well, it depends on the layout. someone could have a ./src/my-utils submodule. in this case, yes.
but I guess, this is not realistic, and we still can tackle the problem when someone notices :-)

[tripodsan]

closing for now. I don't think this is important.