Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move GitUtils back to helix-cli #523

Closed
stefan-guggisberg opened this issue Feb 11, 2019 · 1 comment
Closed

move GitUtils back to helix-cli #523

stefan-guggisberg opened this issue Feb 11, 2019 · 1 comment
Assignees
@stefan-guggisberg
Labels
enhancement New feature or request

Comments

@stefan-guggisberg
Copy link
Contributor

Is your feature request related to a problem? Please describe.
GitUtils in adobe/helix-shared is only used by helix-cli.
see helix-shared/issues/29 for the related discussion.

Describe the solution you'd like
move GitUtils from adobe/helix-shared to adobe/helix-cli and reimplement git-based functionality using isomorphic-git
@stefan-guggisberg stefan-guggisberg added the enhancement New feature or request label Feb 11, 2019
@stefan-guggisberg stefan-guggisberg self-assigned this Feb 11, 2019
stefan-guggisberg added a commit that referenced this issue Feb 11, 2019
@stefan-guggisberg
move GitUtils back to helix-cli #523
a50614f
stefan-guggisberg added a commit that referenced this issue Feb 11, 2019
@stefan-guggisberg
rename to git-utils.js #523
3f4a04e
stefan-guggisberg added a commit that referenced this issue Feb 11, 2019
@stefan-guggisberg
rename to git-utils.js #523
041f37c
stefan-guggisberg added a commit that referenced this issue Feb 12, 2019
@stefan-guggisberg
replacing git cli calls with isomorphic-git #523
deea027
stefan-guggisberg added a commit that referenced this issue Feb 14, 2019
@stefan-guggisberg
replacing git cli calls with isomorphic-git #523
a3b4b42
stefan-guggisberg added a commit that referenced this issue Feb 16, 2019
@stefan-guggisberg
replacing git cli calls with isomorphic-git #523
a9e9ddf
@stefan-guggisberg stefan-guggisberg mentioned this issue Feb 18, 2019
Merged
stefan-guggisberg added a commit that referenced this issue Feb 19, 2019
@stefan-guggisberg
move GitUtils back to helix-cli (#523) (#565)
e866be3 
* move GitUtils back to helix-cli #523

* rename to git-utils.js #523

* rename to git-utils.js #523

* replacing git cli calls with isomorphic-git #523

* replacing git cli calls with isomorphic-git #523

* replacing git cli calls with isomorphic-git #523

* fix broken test setup: testdir needs to be a local git repo

* add test for getBranch() -> tag

* jsdoc for GitUtils functions
@stefan-guggisberg
Copy link
Contributor Author

resolved via PR #565

@stefan-guggisberg stefan-guggisberg mentioned this issue Mar 4, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stefan-guggisberg stefan-guggisberg

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@stefan-guggisberg