[pull] master from raspberrypi:master #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
This is where clangd puts a bunch of junk, so it's nice to have it ignored for folks who use clangd.
* Support serial flash with 16 byte unique id Flash devices like IS25LP016D have a 16 byte unique id. Reading just the first 8 bytes causes devices to have duplicate unique ids as the numbers only differ in the final 8 bytes. Support overriding FLASH_UNIQUE_ID_SIZE_BYTES in the board header. Use the final 8 bytes for the unique id. Fixes #1641
This fixes searching for installed picotool/pioasm on Windows, and generally improves default find_package behaviour
This functionality has been moved into `picotool`, so remove this Python script to avoid confusion
…sble instead of spin lock (#1838)
* fix boot stage2 not showing up in binary info; sync rp2040 and rp230 bs2 CMakeLists.txt
* Use powershell for windows CI build * Remove unnecessary warning
* #1817 fix regression with CMSIS interrupt renaming
This reverts commit b271208.
* Ensure makefsdata.py generates valid variable names * Use mimetypes library in makefsdata.py * Avoid generating duplicate variable names
Needs to copy the _u(x) definition from platform_defs.h
* Modify check_board_header.py to work with both RP2040- and RP2350-based boards * Tweaks to the board-header files so that they pass check_board_header.py * Update tools/check_board_header.py so that it handles pico_cmake_set_default the same way as cmake/generic_board.cmake does
specifed -> specified
I was reading through my PDF copy of the SDK docs, and I think that there's a typo in this example. The macro is `__time_critical_func` but the example spells it `__time_critical`.
#1835) * Disable interrupts for some rom functions * Use flash_safe_execute * Inline and rename helpers
* Add @pico-sdk prefix to bazel/config in lwip.BUILD Without this, we're trying to refer to a subpackage of the lwip directory called bazel/config, which doesn't exist. See similar references in this file. * bazelbuild: Fix compilation errors with pico_lwip and freertos This fixes two general problems. * pico_lwip_contrib_freertos misspelled several things (omitted contrib/ dir prefix, didn't have @pico-sdk in front of out references to pico-sdk targets) This is fixed simply by fixing the spellings. * Circular dependency between pico_lwip_core and pico_lwip_contrib_freertos. In NO_SYS=0 mode, lwip wants to include sys_arch.h. But sys_arch.h is defined in pico_lwip_contrib_freertos. sys_arch.c in turn wants to include lwip's opt.h and arch.h, among other things. So it needs to depend on pico_lwip_core. This is fixed by extracting all the headers into a common rule which can be depended on by both targets, then depending on it in the relevant targets. Additionally, for the LWIP+FreeRTOS build to work correctly, we need to actually depend on the pico_lwip_contrib_freertos rule from pico_lwip_core. This the purpose of the select in the deps of pico_lwip_core. * bazel+cyw43: Fix compilation errors. This fixes issues with the cyw43 driver build rules in Bazel: * Before this, the btstack would always be included even if it could not be used. If the user did not specify a btstack config, this would cause a compilation error. Now, we condition the linking and building of the btstack on whether there is a config for it. * Before, the btbus was not properly linked. * Implements code review feedback
* Add build-essential to README command line install * Update README.md
* Fix assert in gpio_set_irq_enabled
NUM_DMA_IRQS was used instead of NUM_PWM_IRQS
…ag on RP2350. (#2083) The existing RAM implementation does not work because asserting the RUN pin holds SRAM in power-down.
In some cases, the flash lockout task can start on the wrong core and not have time to move to the correct core before exit is called. This causes a timeout as the exit function is looking at the wrong core when checking for the lockout task.
…change existing uses to use this (#2084)
* making pio_calculate_clkdiv8_from_float round to the neareset 1/256 (not lower 1/256) * chage rounding of all float clkdivs to round to neareset; default to nearest (which is a backwards incompatible change, but I think OK), and add ability to turn it off * fix copy/paste errors in PICO_CONFIG * Calculate size of FRAC field using its own MSB and LSB, rather than hoping that INT_LSB is in the right place * Add a new REG_FIELD_WIDTH macro, and make the calculation of the clock-dividers more consistent --------- Co-authored-by: Andrew Scheller <[email protected]>
…#2082) * Save/restore QMI window 1 registers across calls to flash_exit_xip(). This works around the RP2350 ROM reinitialising window 1 even when it does not actually issue an XIP exit sequence to that QSPI device. If no exit sequence is issued, then the original configuration still applies. This is not valid in the case where the ROM *does* issue an XIP exit sequence to the second chip select, because the original mode is no longer valid once the device is in the serial command state. The ROM does this when FLASH_DEVINFO (loaded from OTP, stored in boot RAM) has a nonzero size for chip select 1. To distinguish the two cases, this patch adds getters/setters for FLASH_DEVINFO. If chip select 1 has a nonzero size in FLASH_DEVINFO then the ROM's register changes for window 1 are not reverted, and instead the hardware_flash code makes additional changes to ensure writes also work (as the ROM only reinitialises for reads). This means that, in the case you have opted into ROM support for the second chip select by setting a nonzero CS1 size in FLASH_DEVINFO, the device on chip select 1 will continue to function correctly, but full performance won't be restored until it is reinitialised. The best way to handle this is initialising both chip select devices in your XIP setup function (your boot2). * Fix whitespace. Fix handling of PICO_FLASH_SIZE_BYTES == 0.
…calling malloc/free (#2069)
* Initial Pico 2 W Bazel support Improves compatibility with Pico W and Pico 2 W by fixing issues that prevented correct linking of wireless libraries. * Improve correctness and configurability * Require newer rules_python * Require [email protected] * Fix missing compatibility expressions * Minor tweaks * Minor cleanup * Update suggested version in Bazel README * More README tweaks * Improve Bazel btstack build correctness
…2034) * Propogate non-default pico_cmake_set_default values through to compile definitions Add PICO_BOARD_CMAKE_OVERRIDES common scope variable, to contain any pico_cmake_set_default CMake variables which have been overwritten. This allows passing CMake arguments to the build, without needing extra target_compile_definitions. Also add pico_cmake_set_default PICO_RP2350_A2_SUPPORTED to enable/disable the E10 abs-block fix * Fix more board files missing pico_cmake_set_default PICO_RP2350_A2_SUPPORTED * Apply @lurch's patch to check_board_header.py
…APIs (#2079) * support both struct timespec and struct tm variants of the aon timer APIs since use of one type on RP2040 and the other on RP2350 require pulling in C library code. Provide weak pico_ wrappers for localtime_r and mktime so that the user can override the conversion functions
hardware_watchdog depends from pico_bootrom due to header pico/bootrom.h BUILD.bazel also has this dependency.
…al i don't think (#2090)
pico-sdk/src/rp2_common/pico_flash/flash.c:155:33: warning: implicit declaration of function 'make_timeout_time_ms' pico-sdk/src/rp2_common/pico_flash/flash.c:156:77: warning: implicit declaration of function 'time_reached'
* Add board pimoroni_pico_plus2_w_rp2350.
…efer people to be on the latest)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )