Fix Windows CI build #1846
Merged
Fix Windows CI build #1846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤞 🙂 |
kilograham
approved these changes
Aug 19, 2024
|
https://github.com/raspberrypi/pico-sdk/commits/develop/ Yay, green ticks ✔️ ✔️ ✔️ |
will-v-pi
added a commit
to raspberrypi/pico-examples
that referenced
this pull request
Aug 28, 2024
Apply the same fix as in raspberrypi/pico-sdk#1846
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use powershell for the build, instead of bash - I can't test this works without this being merged, but running the CI commands locally in powershell works fine, so they should run correctly in GitHub actions. There seem to be some path escaping issues or something in bash on Windows, so using powershell instead as that's a more standard option on Windows generally
Also remove the unnecessary warning - it isn't necessary, as picotool no longer throws an error with garbage coprocessor instructions
Fixes #1843