Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comment out CMake cyw43 vars which aren't really that useful in geneal i don't think #2090

Merged
merged 1 commit into from
Nov 24, 2024
Merged

Comment out CMake cyw43 vars which aren't really that useful in geneal i don't think #2090

merged 1 commit into from
Nov 24, 2024

Conversation

kilograham
Copy link
Contributor

@kilograham kilograham commented Nov 23, 2024 •
edited
Loading

These can be specified via board header or target_compile_definitions

@kilograham kilograham added this to the 2.1.0 milestone Nov 23, 2024
peterharperuk
peterharperuk reviewed Nov 23, 2024
View reviewed changes
Copy link
Contributor

@peterharperuk peterharperuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, ok. If you're removing them, wouldn't it be better to delete them?

@kilograham
Copy link
Contributor Author

yeah, i decided to leave them for now in case we want them back

@kilograham kilograham merged commit 5f607a9 into develop Nov 24, 2024
8 checks passed
@kilograham kilograham deleted the remove_cmake_opts_for_cyw43 branch November 24, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterharperuk peterharperuk peterharperuk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@kilograham @peterharperuk