Cleanup/clarification of PIO behavior with >32 pins #2085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterharperuk
approved these changes
Nov 22, 2024
peterharperuk
requested changes
Nov 22, 2024
There was a problem hiding this comment.
ah - I think pio_sm_set_pindirs_with_mask64 is shifting twice. It shifts by pio_get_gpio_base then calls pio_sm_set_pindirs_with_mask_internal which shifts again. Removing the shift from pio_sm_set_pindirs_with_mask_internal fixes this. uart_tx can be used to test this.
peterharperuk
approved these changes
Nov 22, 2024
lurch
reviewed
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.