feat(analyser): add config builder to extend the analyser config #730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekarademir
changed the title
* feat(decoratormanager) add validate method Signed-off-by: Ertugrul Karademir <[email protected]>
Signed-off-by: Ertugrul Karademir <[email protected]>
* feat(map): add property based flag Signed-off-by: Jonathan Casey <[email protected]> * fix typo Signed-off-by: Jonathan Casey <[email protected]> --------- Signed-off-by: Jonathan Casey <[email protected]> Signed-off-by: Ertugrul Karademir <[email protected]>
* feat(map): add jsdoc for enableMapType option Signed-off-by: Jonathan Casey <[email protected]> * chore(*): update changelog Signed-off-by: Jonathan Casey <[email protected]> --------- Signed-off-by: Jonathan Casey <[email protected]> Signed-off-by: Ertugrul Karademir <[email protected]>
Signed-off-by: Ertugrul Karademir <[email protected]>
Signed-off-by: Ertugrul Karademir <[email protected]>
ekarademir
force-pushed
the
ertugrul/i720/extendable_analyser
branch
from
6e98c14 to
200acfc
Compare
Signed-off-by: Ertugrul Karademir <[email protected]>
Signed-off-by: Ertugrul Karademir <[email protected]>
Signed-off-by: Ertugrul Karademir <[email protected]>
Signed-off-by: Ertugrul Karademir <[email protected]>
mttrbrts
reviewed
Oct 11, 2023
There was a problem hiding this comment.
A well designed extension, thanks @ekarademir!
Do you understand why we have the linting/whitespace changes? Is there a build step that we should be automating, or are these changes made by your editor's configuration?
What generated those differences was to run the |
jonathan-casey
approved these changes
Oct 11, 2023
|
Nice work @ekarademir |
ekarademir
force-pushed
the
ertugrul/i720/extendable_analyser
branch
from
d536e59 to
8441a77
Compare
Signed-off-by: Ertugrul Karademir <[email protected]>
Signed-off-by: Ertugrul Karademir <[email protected]>
ekarademir
force-pushed
the
ertugrul/i720/extendable_analyser
branch
from
8441a77 to
f562818
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #720
Adds a builder to create a
CompareConfigthat can be used for creatingCompareclass.Changes
CompareConfigBuilderclass that starts from an empty configuration and able to build up configuration as we go.buildmethod to get the resulting configuration.Flags
Screenshots or Video
Related Issues
Author Checklist
--signoffoption of git commit.mainfromfork:branchname