Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jonathan/add options jsdoc #729

Merged
merged 2 commits into from
Oct 10, 2023
Merged

Jonathan/add options jsdoc #729

merged 2 commits into from
Oct 10, 2023

Conversation

jonathan-casey
Copy link
Member

Description

Add JSDoc for option enableMapType on BaseModelManager

@jonathan-casey jonathan-casey requested a review from a team October 10, 2023 08:45
@jonathan-casey jonathan-casey merged commit a801e7d into main Oct 10, 2023
11 checks passed
@jonathan-casey jonathan-casey deleted the jonathan/add_options_jsdoc branch October 10, 2023 10:56
ekarademir pushed a commit to ekarademir/concerto that referenced this pull request Oct 10, 2023
* feat(map): add jsdoc for enableMapType option

Signed-off-by: Jonathan Casey <[email protected]>

* chore(*): update changelog

Signed-off-by: Jonathan Casey <[email protected]>

---------

Signed-off-by: Jonathan Casey <[email protected]>
Signed-off-by: Ertugrul Karademir <[email protected]>
mttrbrts pushed a commit that referenced this pull request Oct 20, 2023
* feat(decoratormanager) add validate method (#726)

* feat(decoratormanager) add validate method

Signed-off-by: Ertugrul Karademir <[email protected]>

* Add a builder for the config

Signed-off-by: Ertugrul Karademir <[email protected]>

* feat(map): add property based flag (#728)

* feat(map): add property based flag

Signed-off-by: Jonathan Casey <[email protected]>

* fix typo

Signed-off-by: Jonathan Casey <[email protected]>

---------

Signed-off-by: Jonathan Casey <[email protected]>
Signed-off-by: Ertugrul Karademir <[email protected]>

* Jonathan/add options jsdoc (#729)

* feat(map): add jsdoc for enableMapType option

Signed-off-by: Jonathan Casey <[email protected]>

* chore(*): update changelog

Signed-off-by: Jonathan Casey <[email protected]>

---------

Signed-off-by: Jonathan Casey <[email protected]>
Signed-off-by: Ertugrul Karademir <[email protected]>

* Lint and test

Signed-off-by: Ertugrul Karademir <[email protected]>

* Signing off

Signed-off-by: Ertugrul Karademir <[email protected]>

* Renaming a method

Signed-off-by: Ertugrul Karademir <[email protected]>

* Fix comment alignments

Signed-off-by: Ertugrul Karademir <[email protected]>

* Clone instead of copy

Signed-off-by: Ertugrul Karademir <[email protected]>

* Export builder with the main package

Signed-off-by: Ertugrul Karademir <[email protected]>

* Typo fixes

Signed-off-by: Ertugrul Karademir <[email protected]>

* Complete builder pattern

Signed-off-by: Ertugrul Karademir <[email protected]>

---------

Signed-off-by: Ertugrul Karademir <[email protected]>
Signed-off-by: Jonathan Casey <[email protected]>
Co-authored-by: Dan Selman <[email protected]>
Co-authored-by: Jonathan-Casey <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant