Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(decoratormanager) add validate method #726

Merged
merged 2 commits into from
Oct 4, 2023

Conversation

dselman
Copy link
Contributor

@dselman dselman commented Oct 3, 2023

Closes #725

Adds DecoratorManager.validate method to perform structural validation of decorator command sets.

Changes

  • Adds new static method to DecoratorManager: refactoring of existing code that was in the decoratorModels method.
  • Adds test cases

Flags

Screenshots or Video

Related Issues

  • Issue #
  • Pull Request #

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to main from fork:branchname

@dselman dselman marked this pull request as ready for review October 3, 2023 14:29
@dselman dselman requested a review from a team October 3, 2023 14:29
Signed-off-by: Dan Selman <[email protected]>
@dselman dselman merged commit 3337541 into main Oct 4, 2023
11 checks passed
@dselman dselman deleted the ds-decoratormanager-validate branch October 4, 2023 13:39
ekarademir pushed a commit to ekarademir/concerto that referenced this pull request Oct 10, 2023
* feat(decoratormanager) add validate method

Signed-off-by: Ertugrul Karademir <[email protected]>
mttrbrts pushed a commit that referenced this pull request Oct 20, 2023
* feat(decoratormanager) add validate method (#726)

* feat(decoratormanager) add validate method

Signed-off-by: Ertugrul Karademir <[email protected]>

* Add a builder for the config

Signed-off-by: Ertugrul Karademir <[email protected]>

* feat(map): add property based flag (#728)

* feat(map): add property based flag

Signed-off-by: Jonathan Casey <[email protected]>

* fix typo

Signed-off-by: Jonathan Casey <[email protected]>

---------

Signed-off-by: Jonathan Casey <[email protected]>
Signed-off-by: Ertugrul Karademir <[email protected]>

* Jonathan/add options jsdoc (#729)

* feat(map): add jsdoc for enableMapType option

Signed-off-by: Jonathan Casey <[email protected]>

* chore(*): update changelog

Signed-off-by: Jonathan Casey <[email protected]>

---------

Signed-off-by: Jonathan Casey <[email protected]>
Signed-off-by: Ertugrul Karademir <[email protected]>

* Lint and test

Signed-off-by: Ertugrul Karademir <[email protected]>

* Signing off

Signed-off-by: Ertugrul Karademir <[email protected]>

* Renaming a method

Signed-off-by: Ertugrul Karademir <[email protected]>

* Fix comment alignments

Signed-off-by: Ertugrul Karademir <[email protected]>

* Clone instead of copy

Signed-off-by: Ertugrul Karademir <[email protected]>

* Export builder with the main package

Signed-off-by: Ertugrul Karademir <[email protected]>

* Typo fixes

Signed-off-by: Ertugrul Karademir <[email protected]>

* Complete builder pattern

Signed-off-by: Ertugrul Karademir <[email protected]>

---------

Signed-off-by: Ertugrul Karademir <[email protected]>
Signed-off-by: Jonathan Casey <[email protected]>
Co-authored-by: Dan Selman <[email protected]>
Co-authored-by: Jonathan-Casey <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Decorator Command Set validation independent of applying decorators
2 participants