feat(map): add property based flag #728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jonathan Casey <[email protected]>
DianaLease
requested changes
Oct 9, 2023
| } | ||
| }); | ||
|
|
||
| it('should not throw if Map Type not enabled in ModelManager options', () => { |
There was a problem hiding this comment.
'should not throw if Map Type not is enabled in ModelManager options'
There was a problem hiding this comment.
Thanks for spotting @DianaLease, typo is corrected. Can you unblock the PR please?
Signed-off-by: Jonathan Casey <[email protected]>
DianaLease
approved these changes
Oct 9, 2023
ekarademir
pushed a commit
to ekarademir/concerto
that referenced
this pull request
Oct 10, 2023
* feat(map): add property based flag Signed-off-by: Jonathan Casey <[email protected]> * fix typo Signed-off-by: Jonathan Casey <[email protected]> --------- Signed-off-by: Jonathan Casey <[email protected]> Signed-off-by: Ertugrul Karademir <[email protected]>
mttrbrts
pushed a commit
that referenced
this pull request
Oct 20, 2023
* feat(decoratormanager) add validate method (#726) * feat(decoratormanager) add validate method Signed-off-by: Ertugrul Karademir <[email protected]> * Add a builder for the config Signed-off-by: Ertugrul Karademir <[email protected]> * feat(map): add property based flag (#728) * feat(map): add property based flag Signed-off-by: Jonathan Casey <[email protected]> * fix typo Signed-off-by: Jonathan Casey <[email protected]> --------- Signed-off-by: Jonathan Casey <[email protected]> Signed-off-by: Ertugrul Karademir <[email protected]> * Jonathan/add options jsdoc (#729) * feat(map): add jsdoc for enableMapType option Signed-off-by: Jonathan Casey <[email protected]> * chore(*): update changelog Signed-off-by: Jonathan Casey <[email protected]> --------- Signed-off-by: Jonathan Casey <[email protected]> Signed-off-by: Ertugrul Karademir <[email protected]> * Lint and test Signed-off-by: Ertugrul Karademir <[email protected]> * Signing off Signed-off-by: Ertugrul Karademir <[email protected]> * Renaming a method Signed-off-by: Ertugrul Karademir <[email protected]> * Fix comment alignments Signed-off-by: Ertugrul Karademir <[email protected]> * Clone instead of copy Signed-off-by: Ertugrul Karademir <[email protected]> * Export builder with the main package Signed-off-by: Ertugrul Karademir <[email protected]> * Typo fixes Signed-off-by: Ertugrul Karademir <[email protected]> * Complete builder pattern Signed-off-by: Ertugrul Karademir <[email protected]> --------- Signed-off-by: Ertugrul Karademir <[email protected]> Signed-off-by: Jonathan Casey <[email protected]> Co-authored-by: Dan Selman <[email protected]> Co-authored-by: Jonathan-Casey <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add property based flag to
ModelManageroptions as an alternative to setting process.envENABLE_MAP_TYPE='true'.This change is temporary and will be removed on full release of Map Type.
Usage
modelManager = new ModelManager({enableMapType: true});