Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/typescript #123

Merged
merged 21 commits into from
Mar 31, 2022
Merged

Feat/typescript #123

merged 21 commits into from
Mar 31, 2022

Conversation

cyp3rius
Copy link
Collaborator

Summary

What does this PR do/solve?

Full migration to TypeScript 🔥

Test Plan

How are you testing the work you're submitting?

  • follow the readme chapter

rrfaria and others added 2 commits March 8, 2022 08:47
@rrfaria
Feat: add pt-BR translation (#119)
3ac6138 
* feat: add pt-br translation

* refac: add missing key

* fix: approved translation
@cyp3rius
chore: version bump
ca39a5d
@codecov-commenter
Copy link

codecov-commenter commented Mar 25, 2022 •
edited
Loading

Codecov Report

Merging #123 (047cd73) into master (7736616) will decrease coverage by 3.91%.
The diff coverage is 38.60%.

@@            Coverage Diff             @@
##           master     #123      +/-   ##
==========================================
- Coverage   42.52%   38.60%   -3.92%     
==========================================
  Files          12        9       -3     
  Lines         428      487      +59     
  Branches      141      192      +51     
==========================================
+ Hits          182      188       +6     
- Misses        200      297      +97     
+ Partials       46        2      -44
Flag Coverage Δ
unittest 38.60% <38.60%> (-3.92%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
server/services/client.ts 5.08% <5.08%> (ø)
server/services/admin.ts 5.71% <5.71%> (ø)
server/utils/functions.ts 34.78% <34.78%> (ø)
server/utils/error.ts 53.33% <53.33%> (ø)
server/services/utils/functions.ts 62.68% <62.68%> (ø)
server/services/common.ts 73.37% <73.37%> (ø)
content-types/comment.ts 100.00% <100.00%> (ø)
content-types/report.ts 100.00% <100.00%> (ø)
server/utils/constants.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7736616...047cd73. Read the comment docs.

CodeVoyager
CodeVoyager approved these changes Mar 30, 2022
View reviewed changes
Copy link
Contributor

@CodeVoyager CodeVoyager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor stuff. Overall - good effort.

types/controllers.d.ts Outdated Show resolved Hide resolved
types/config.d.ts Outdated Show resolved Hide resolved
types/common.d.ts Outdated Show resolved Hide resolved
strapi-server.ts Outdated Show resolved Hide resolved
strapi-server.ts Show resolved Hide resolved
server/graphql/mutations/createAbuseReport.ts Outdated Show resolved Hide resolved
server/graphql/mutations/createComment.ts Outdated Show resolved Hide resolved
server/graphql/mutations/removeComment.ts Show resolved Hide resolved
server/services/utils/functions.ts Outdated Show resolved Hide resolved
server/services/utils/functions.ts Outdated Show resolved Hide resolved
cyp3rius and others added 19 commits March 31, 2022 11:35
@cyp3rius
feat: typescript flow and basic typings
0f906d5
@cyp3rius
feat: ts-jest and tests
f6d010d
@cyp3rius
feat: client service to typescript
4627fb2
@cyp3rius
feat: types functions utils
f84595b
@cyp3rius
fix: runtime errors
96604d1
@cyp3rius
feat: usage of strapi-typed package and coverage for services
1907617
@cyp3rius
chore: strapi-typed version bump
d5ffc7d
@cyp3rius
feat: initial ts move done
5b1b882
@cyp3rius
chore: prettier formatting
7f3de93
@cyp3rius
moved types out to strapi-typed
078e3fb
@cyp3rius
fix: fixing pluginId importing
9580e06
@cyp3rius @CodeVoyager
Update server/services/utils/functions.ts
9d17f15 
Co-authored-by: Tomasz Puch <[email protected]>
@cyp3rius @CodeVoyager
Update server/services/utils/functions.ts
0404714 
Co-authored-by: Tomasz Puch <[email protected]>
@cyp3rius @CodeVoyager
Update strapi-server.ts
a8ab3d3 
Co-authored-by: Tomasz Puch <[email protected]>
@cyp3rius @CodeVoyager
Update types/config.d.ts
4d50df6 
Co-authored-by: Tomasz Puch <[email protected]>
@cyp3rius @CodeVoyager
Update types/controllers.d.ts
67b1caa 
Co-authored-by: Tomasz Puch <[email protected]>
@cyp3rius
refactor: reworks after review
644fbd8
@cyp3rius
refactor: last reworks
2a8ac52
@cyp3rius
refactor: prettier formatting
75e2a50
@cyp3rius cyp3rius changed the base branch from master to develop March 31, 2022 09:38
@cyp3rius cyp3rius merged commit fce09c6 into develop Mar 31, 2022
@cyp3rius cyp3rius deleted the feat/typescript branch March 31, 2022 09:40
cyp3rius added a commit that referenced this pull request Apr 14, 2022
@cyp3rius @rrfaria @CodeVoyager
Feat/typescript (#123)
d567b34 
* Feat: add pt-BR translation (#119)

* feat: add pt-br translation

* refac: add missing key

* fix: approved translation

* chore: version bump

* feat: typescript flow and basic typings

* feat: ts-jest and tests

* feat: client service to typescript

* feat: types functions utils

* fix: runtime errors

* feat: usage of strapi-typed package and coverage for services

* chore: strapi-typed version bump

* feat: initial ts move done

* chore: prettier formatting

* moved types out to strapi-typed

* fix: fixing pluginId importing

* Update server/services/utils/functions.ts

Co-authored-by: Tomasz Puch <[email protected]>

* Update server/services/utils/functions.ts

Co-authored-by: Tomasz Puch <[email protected]>

* Update strapi-server.ts

Co-authored-by: Tomasz Puch <[email protected]>

* Update types/config.d.ts

Co-authored-by: Tomasz Puch <[email protected]>

* Update types/controllers.d.ts

Co-authored-by: Tomasz Puch <[email protected]>

* refactor: reworks after review

* refactor: last reworks

* refactor: prettier formatting

Co-authored-by: Rafael Faria <[email protected]>
Co-authored-by: Tomasz Puch <[email protected]>
cyp3rius added a commit that referenced this pull request Apr 22, 2022
@cyp3rius @rrfaria @CodeVoyager
Release ready version 2.1.0 (#135)
cb33d12 
* Feat/typescript (#123)

* Feat: add pt-BR translation (#119)

* feat: add pt-br translation

* refac: add missing key

* fix: approved translation

* chore: version bump

* feat: typescript flow and basic typings

* feat: ts-jest and tests

* feat: client service to typescript

* feat: types functions utils

* fix: runtime errors

* feat: usage of strapi-typed package and coverage for services

* chore: strapi-typed version bump

* feat: initial ts move done

* chore: prettier formatting

* moved types out to strapi-typed

* fix: fixing pluginId importing

* Update server/services/utils/functions.ts

Co-authored-by: Tomasz Puch <[email protected]>

* Update server/services/utils/functions.ts

Co-authored-by: Tomasz Puch <[email protected]>

* Update strapi-server.ts

Co-authored-by: Tomasz Puch <[email protected]>

* Update types/config.d.ts

Co-authored-by: Tomasz Puch <[email protected]>

* Update types/controllers.d.ts

Co-authored-by: Tomasz Puch <[email protected]>

* refactor: reworks after review

* refactor: last reworks

* refactor: prettier formatting

Co-authored-by: Rafael Faria <[email protected]>
Co-authored-by: Tomasz Puch <[email protected]>

* chore: version bump

* fix: package.json outdated

* feat: typescripted client service and controllers

* Feat/rest fields query (#132)

* feat: issue #115 support rest select fields in query

* chore: bump strapi-typed to 1.0.8

* refactor: reworks based on pr comments

* refactor: typings alignments based on pr review

* [CU-2cq60k0] feat: issue #113 author field population (#133)

* feat: issue #115 support rest select fields in query

* feat: issue #113 author field population

* refactor: reworks after pr review

* chore: bump strapi-typed version

* [CU-2cq6299] chore/api service client tests (#134)

* feat: issue #115 support rest select fields in query

* feat: issue #113 author field population

* refactor: reworks after pr review

* feat: issue #115 support rest select fields in query

* chore: client api service tests coverage

* fix: conflicts resolution

* fix: small some tests fixes

* refactor: prettier formatting

Co-authored-by: Rafael Faria <[email protected]>
Co-authored-by: Tomasz Puch <[email protected]>
cyp3rius added a commit that referenced this pull request Oct 12, 2022
@cyp3rius @rrfaria
@CodeVoyager @kamilszewczyk0 @AndrzejBugdol @Kronos66
Develop (#160)
9a08731 
* Feat/typescript (#123)

* Feat: add pt-BR translation (#119)

* feat: add pt-br translation

* refac: add missing key

* fix: approved translation

* chore: version bump

* feat: typescript flow and basic typings

* feat: ts-jest and tests

* feat: client service to typescript

* feat: types functions utils

* fix: runtime errors

* feat: usage of strapi-typed package and coverage for services

* chore: strapi-typed version bump

* feat: initial ts move done

* chore: prettier formatting

* moved types out to strapi-typed

* fix: fixing pluginId importing

* Update server/services/utils/functions.ts

Co-authored-by: Tomasz Puch <[email protected]>

* Update server/services/utils/functions.ts

Co-authored-by: Tomasz Puch <[email protected]>

* Update strapi-server.ts

Co-authored-by: Tomasz Puch <[email protected]>

* Update types/config.d.ts

Co-authored-by: Tomasz Puch <[email protected]>

* Update types/controllers.d.ts

Co-authored-by: Tomasz Puch <[email protected]>

* refactor: reworks after review

* refactor: last reworks

* refactor: prettier formatting

Co-authored-by: Rafael Faria <[email protected]>
Co-authored-by: Tomasz Puch <[email protected]>

* chore: version bump

* fix: package.json outdated

* feat: typescripted client service and controllers

* Feat/rest fields query (#132)

* feat: issue #115 support rest select fields in query

* chore: bump strapi-typed to 1.0.8

* refactor: reworks based on pr comments

* refactor: typings alignments based on pr review

* [CU-2cq60k0] feat: issue #113 author field population (#133)

* feat: issue #115 support rest select fields in query

* feat: issue #113 author field population

* refactor: reworks after pr review

* chore: bump strapi-typed version

* [CU-2cq6299] chore/api service client tests (#134)

* feat: issue #115 support rest select fields in query

* feat: issue #113 author field population

* refactor: reworks after pr review

* feat: issue #115 support rest select fields in query

* chore: client api service tests coverage

* fix: conflicts resolution

* fix: small some tests fixes

* refactor: prettier formatting

* feat: create reports page [CU-20rfmkv] (#153)

* feat: reports page

* refactor: changes after code review

* Feat/moderator responses in threads (#150)

* feat: Change WYSIWYG to TypeScript

* feat: Moderator response under thread

* feat: Delete comment

* feat: New comment notifications and standardize of refresh

* feat: Update and StartThread functionality

* fix: Blocking thread and comment of reported comment

* refactor: reworks after review

* refactor: reworks after further reviews

* Merge branch 'develop' into feat/moderator-responses-in-threads

Co-authored-by: Kamil Szewczyk <[email protected]>

* chore: version bump

* fix: fixes after merge

* feat: comments custom field [CU-2tn2923] (#157)

* feat: comments custom field

* chore: code coverage

* fix: pr feedback and tests

* chore: tests rename

* fix: failing test

* chore: version update

* feat: custom field icon

* fix: failing tests

* fix: typescript build failing

* fix: add env and change path (#158)

Co-authored-by: Mateusz Ziarko <[email protected]>
Co-authored-by: Maksymilian Pamuła <[email protected]>

* chore: version bump & docs update

Co-authored-by: Rafael Faria <[email protected]>
Co-authored-by: Tomasz Puch <[email protected]>
Co-authored-by: kamilszewczyk0 <[email protected]>
Co-authored-by: AndrzejBugdol <[email protected]>
Co-authored-by: Kamil Szewczyk <[email protected]>
Co-authored-by: Andrzej Bugdol <[email protected]>
Co-authored-by: Maksymilian Pamuła <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CodeVoyager CodeVoyager CodeVoyager approved these changes

@ltsNotMike ltsNotMike Awaiting requested review from ltsNotMike

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cyp3rius @codecov-commenter @CodeVoyager @rrfaria