-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CU-2cq60k0] Maybe populate the author field? #113
Comments
Hello @be90728 , That kind of request pops up already for v3 (in terms of |
* Feat/typescript (#123) * Feat: add pt-BR translation (#119) * feat: add pt-br translation * refac: add missing key * fix: approved translation * chore: version bump * feat: typescript flow and basic typings * feat: ts-jest and tests * feat: client service to typescript * feat: types functions utils * fix: runtime errors * feat: usage of strapi-typed package and coverage for services * chore: strapi-typed version bump * feat: initial ts move done * chore: prettier formatting * moved types out to strapi-typed * fix: fixing pluginId importing * Update server/services/utils/functions.ts Co-authored-by: Tomasz Puch <[email protected]> * Update server/services/utils/functions.ts Co-authored-by: Tomasz Puch <[email protected]> * Update strapi-server.ts Co-authored-by: Tomasz Puch <[email protected]> * Update types/config.d.ts Co-authored-by: Tomasz Puch <[email protected]> * Update types/controllers.d.ts Co-authored-by: Tomasz Puch <[email protected]> * refactor: reworks after review * refactor: last reworks * refactor: prettier formatting Co-authored-by: Rafael Faria <[email protected]> Co-authored-by: Tomasz Puch <[email protected]> * chore: version bump * fix: package.json outdated * feat: typescripted client service and controllers * Feat/rest fields query (#132) * feat: issue #115 support rest select fields in query * chore: bump strapi-typed to 1.0.8 * refactor: reworks based on pr comments * refactor: typings alignments based on pr review * [CU-2cq60k0] feat: issue #113 author field population (#133) * feat: issue #115 support rest select fields in query * feat: issue #113 author field population * refactor: reworks after pr review * chore: bump strapi-typed version * [CU-2cq6299] chore/api service client tests (#134) * feat: issue #115 support rest select fields in query * feat: issue #113 author field population * refactor: reworks after pr review * feat: issue #115 support rest select fields in query * chore: client api service tests coverage * fix: conflicts resolution * fix: small some tests fixes * refactor: prettier formatting Co-authored-by: Rafael Faria <[email protected]> Co-authored-by: Tomasz Puch <[email protected]>
Released as part of |
@cyp3rius thank you for your awesome work. 🙏 I wonder would be the right way to add the avatar field 🤔 Shouldn't be like this to populate the avatar field? |
@Tragio yep that's the correct way to do this. Both examples should work:
I got following result in one of my queries: {
"id": 10,
"content": "Fusce bibendum molestie scelerisque.",
"blocked": false,
"blockedThread": false,
"blockReason": null,
"removed": null,
"approvalStatus": null,
"related":{"id": 1, "Title": "ghghghgh", "Content": null, "createdAt": "2022-03-30T20:54:53.162Z",…},
"createdAt": "2022-04-15T11:26:29.897Z",
"updatedAt": "2022-04-15T11:26:29.897Z",
"threadOf": null,
"gotThread": false,
"author":{
"id": 1,
"name": "Test",
"email": "[email protected]",
"avatar":{
"id": 1,
"name": "Hand-Drawn-Blue-Bird-Avatar.jpeg",
"alternativeText": "Hand-Drawn-Blue-Bird-Avatar.jpeg",
"caption": "Hand-Drawn-Blue-Bird-Avatar.jpeg",
"width": 480,
"height": 480,
"formats":{"thumbnail":{"ext": ".jpeg", "url": "/uploads/thumbnail_Hand_Drawn_Blue_Bird_Avatar_c9c6d8cc2b.jpeg",…},
"hash": "Hand_Drawn_Blue_Bird_Avatar_c9c6d8cc2b",
"ext": ".jpeg",
"mime": "image/jpeg",
"size": 15.13,
"url": "/uploads/Hand_Drawn_Blue_Bird_Avatar_c9c6d8cc2b.jpeg",
"previewUrl": null,
"provider": "local",
"provider_metadata": null,
"createdAt": "2022-04-15T11:51:04.979Z",
"updatedAt": "2022-04-15T11:51:04.979Z"
}
}
} |
@cyp3rius hmmm strange that it was not working. I updated to version 2.1.2 to see if that was fixed but the plugin now stopped showing in the dashboard and the routes also give 404. |
in Have you re-builded your admin tool? |
@Tragio found it, some files failed to transpile while publish. Fixed that and |
@cyp3rius with 2.1.3 is giving critical error:
|
There was a mess with dependencies seems, I've done some more deep checks and reverted to the same |
@cyp3rius so fresh morning, fresh mind. I forgot the avatar was created by me and not as default by Strapi, so it's called thumbnail and not avatar 🤦♂️ sorry for wasting your time, and really thank you for your support and awesome work!! |
No worries :D You've pushed me to double check the logic and define most strict tests and found the error with multiple fields population which has been solved already ;) |
Hey, I don't quite understand how |
* Feat/typescript (#123) * Feat: add pt-BR translation (#119) * feat: add pt-br translation * refac: add missing key * fix: approved translation * chore: version bump * feat: typescript flow and basic typings * feat: ts-jest and tests * feat: client service to typescript * feat: types functions utils * fix: runtime errors * feat: usage of strapi-typed package and coverage for services * chore: strapi-typed version bump * feat: initial ts move done * chore: prettier formatting * moved types out to strapi-typed * fix: fixing pluginId importing * Update server/services/utils/functions.ts Co-authored-by: Tomasz Puch <[email protected]> * Update server/services/utils/functions.ts Co-authored-by: Tomasz Puch <[email protected]> * Update strapi-server.ts Co-authored-by: Tomasz Puch <[email protected]> * Update types/config.d.ts Co-authored-by: Tomasz Puch <[email protected]> * Update types/controllers.d.ts Co-authored-by: Tomasz Puch <[email protected]> * refactor: reworks after review * refactor: last reworks * refactor: prettier formatting Co-authored-by: Rafael Faria <[email protected]> Co-authored-by: Tomasz Puch <[email protected]> * chore: version bump * fix: package.json outdated * feat: typescripted client service and controllers * Feat/rest fields query (#132) * feat: issue #115 support rest select fields in query * chore: bump strapi-typed to 1.0.8 * refactor: reworks based on pr comments * refactor: typings alignments based on pr review * [CU-2cq60k0] feat: issue #113 author field population (#133) * feat: issue #115 support rest select fields in query * feat: issue #113 author field population * refactor: reworks after pr review * chore: bump strapi-typed version * [CU-2cq6299] chore/api service client tests (#134) * feat: issue #115 support rest select fields in query * feat: issue #113 author field population * refactor: reworks after pr review * feat: issue #115 support rest select fields in query * chore: client api service tests coverage * fix: conflicts resolution * fix: small some tests fixes * refactor: prettier formatting * feat: create reports page [CU-20rfmkv] (#153) * feat: reports page * refactor: changes after code review * Feat/moderator responses in threads (#150) * feat: Change WYSIWYG to TypeScript * feat: Moderator response under thread * feat: Delete comment * feat: New comment notifications and standardize of refresh * feat: Update and StartThread functionality * fix: Blocking thread and comment of reported comment * refactor: reworks after review * refactor: reworks after further reviews * Merge branch 'develop' into feat/moderator-responses-in-threads Co-authored-by: Kamil Szewczyk <[email protected]> * chore: version bump * fix: fixes after merge * feat: comments custom field [CU-2tn2923] (#157) * feat: comments custom field * chore: code coverage * fix: pr feedback and tests * chore: tests rename * fix: failing test * chore: version update * feat: custom field icon * fix: failing tests * fix: typescript build failing * fix: add env and change path (#158) Co-authored-by: Mateusz Ziarko <[email protected]> Co-authored-by: Maksymilian Pamuła <[email protected]> * chore: version bump & docs update Co-authored-by: Rafael Faria <[email protected]> Co-authored-by: Tomasz Puch <[email protected]> Co-authored-by: kamilszewczyk0 <[email protected]> Co-authored-by: AndrzejBugdol <[email protected]> Co-authored-by: Kamil Szewczyk <[email protected]> Co-authored-by: Andrzej Bugdol <[email protected]> Co-authored-by: Maksymilian Pamuła <[email protected]>
When the comment author is a registered strapi user
For example, I populate
authorUser.role
, but the fieldrole
will be cleared because ofbuildAuthorModel
insanitizeCommentEntity
.Maybe we can add an author populate field to the plugin configuration page?
In this way, there is no need to worry about the leakage of the author's confidential information due to illegal query populate.
The text was updated successfully, but these errors were encountered: