Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CU-2cq6005] Feat/rest fields query #132

Merged
merged 4 commits into from
Apr 21, 2022
Merged

Conversation

cyp3rius
Copy link
Collaborator

Ticket

#115

Summary

What does this PR do/solve?

Introduce support of Fields query via REST API according to Strapi documentation:

https://docs.strapi.io/developer-docs/latest/developer-resources/database-apis-reference/rest/populating-fields.html#field-selection

Test Plan

How are you testing the work you're submitting?

  1. Run project
  2. Try to call API with ?fields[0]=content and see that there are present some mandatory fields like id, related, threadOf, gotThread and content. Other fields has been dropped. Works for both flat and hierarchical query

Note
This is not supported by GraphQL by design, not necessary.

@cyp3rius cyp3rius changed the base branch from master to develop April 15, 2022 10:21
@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (develop@eddd4b3). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop     #132   +/-   ##
==========================================
  Coverage           ?   39.18%           
==========================================
  Files              ?        9           
  Lines              ?      490           
  Branches           ?      192           
==========================================
  Hits               ?      192           
  Misses             ?      296           
  Partials           ?        2           
Flag Coverage Δ
unittest 39.18% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eddd4b3...5e7933d. Read the comment docs.

server/controllers/client.ts Outdated Show resolved Hide resolved
types/services.d.ts Outdated Show resolved Hide resolved
@cyp3rius cyp3rius merged commit 9716494 into develop Apr 21, 2022
@cyp3rius cyp3rius deleted the feat/rest-fields-query branch April 21, 2022 14:41
@cyp3rius cyp3rius changed the title Feat/rest fields query [CU-2cq6005] Feat/rest fields query Apr 22, 2022
@cyp3rius
Copy link
Collaborator Author

Task linked: CU-2cq6005 Support for 'fields' query

cyp3rius added a commit that referenced this pull request Apr 22, 2022
* Feat/typescript (#123)

* Feat: add pt-BR translation (#119)

* feat: add pt-br translation

* refac: add missing key

* fix: approved translation

* chore: version bump

* feat: typescript flow and basic typings

* feat: ts-jest and tests

* feat: client service to typescript

* feat: types functions utils

* fix: runtime errors

* feat: usage of strapi-typed package and coverage for services

* chore: strapi-typed version bump

* feat: initial ts move done

* chore: prettier formatting

* moved types out to strapi-typed

* fix: fixing pluginId importing

* Update server/services/utils/functions.ts

Co-authored-by: Tomasz Puch <[email protected]>

* Update server/services/utils/functions.ts

Co-authored-by: Tomasz Puch <[email protected]>

* Update strapi-server.ts

Co-authored-by: Tomasz Puch <[email protected]>

* Update types/config.d.ts

Co-authored-by: Tomasz Puch <[email protected]>

* Update types/controllers.d.ts

Co-authored-by: Tomasz Puch <[email protected]>

* refactor: reworks after review

* refactor: last reworks

* refactor: prettier formatting

Co-authored-by: Rafael Faria <[email protected]>
Co-authored-by: Tomasz Puch <[email protected]>

* chore: version bump

* fix: package.json outdated

* feat: typescripted client service and controllers

* Feat/rest fields query (#132)

* feat: issue #115 support rest select fields in query

* chore: bump strapi-typed to 1.0.8

* refactor: reworks based on pr comments

* refactor: typings alignments based on pr review

* [CU-2cq60k0] feat: issue #113 author field population (#133)

* feat: issue #115 support rest select fields in query

* feat: issue #113 author field population

* refactor: reworks after pr review

* chore: bump strapi-typed version

* [CU-2cq6299] chore/api service client tests (#134)

* feat: issue #115 support rest select fields in query

* feat: issue #113 author field population

* refactor: reworks after pr review

* feat: issue #115 support rest select fields in query

* chore: client api service tests coverage

* fix: conflicts resolution

* fix: small some tests fixes

* refactor: prettier formatting

Co-authored-by: Rafael Faria <[email protected]>
Co-authored-by: Tomasz Puch <[email protected]>
cyp3rius added a commit that referenced this pull request Oct 12, 2022
* Feat/typescript (#123)

* Feat: add pt-BR translation (#119)

* feat: add pt-br translation

* refac: add missing key

* fix: approved translation

* chore: version bump

* feat: typescript flow and basic typings

* feat: ts-jest and tests

* feat: client service to typescript

* feat: types functions utils

* fix: runtime errors

* feat: usage of strapi-typed package and coverage for services

* chore: strapi-typed version bump

* feat: initial ts move done

* chore: prettier formatting

* moved types out to strapi-typed

* fix: fixing pluginId importing

* Update server/services/utils/functions.ts

Co-authored-by: Tomasz Puch <[email protected]>

* Update server/services/utils/functions.ts

Co-authored-by: Tomasz Puch <[email protected]>

* Update strapi-server.ts

Co-authored-by: Tomasz Puch <[email protected]>

* Update types/config.d.ts

Co-authored-by: Tomasz Puch <[email protected]>

* Update types/controllers.d.ts

Co-authored-by: Tomasz Puch <[email protected]>

* refactor: reworks after review

* refactor: last reworks

* refactor: prettier formatting

Co-authored-by: Rafael Faria <[email protected]>
Co-authored-by: Tomasz Puch <[email protected]>

* chore: version bump

* fix: package.json outdated

* feat: typescripted client service and controllers

* Feat/rest fields query (#132)

* feat: issue #115 support rest select fields in query

* chore: bump strapi-typed to 1.0.8

* refactor: reworks based on pr comments

* refactor: typings alignments based on pr review

* [CU-2cq60k0] feat: issue #113 author field population (#133)

* feat: issue #115 support rest select fields in query

* feat: issue #113 author field population

* refactor: reworks after pr review

* chore: bump strapi-typed version

* [CU-2cq6299] chore/api service client tests (#134)

* feat: issue #115 support rest select fields in query

* feat: issue #113 author field population

* refactor: reworks after pr review

* feat: issue #115 support rest select fields in query

* chore: client api service tests coverage

* fix: conflicts resolution

* fix: small some tests fixes

* refactor: prettier formatting

* feat: create reports page [CU-20rfmkv] (#153)

* feat: reports page

* refactor: changes after code review

* Feat/moderator responses in threads (#150)

* feat: Change WYSIWYG to TypeScript

* feat: Moderator response under thread

* feat: Delete comment

* feat: New comment notifications and standardize of refresh

* feat: Update and StartThread functionality

* fix: Blocking thread and comment of reported comment

* refactor: reworks after review

* refactor: reworks after further reviews

* Merge branch 'develop' into feat/moderator-responses-in-threads

Co-authored-by: Kamil Szewczyk <[email protected]>

* chore: version bump

* fix: fixes after merge

* feat: comments custom field [CU-2tn2923] (#157)

* feat: comments custom field

* chore: code coverage

* fix: pr feedback and tests

* chore: tests rename

* fix: failing test

* chore: version update

* feat: custom field icon

* fix: failing tests

* fix: typescript build failing

* fix: add env and change path (#158)

Co-authored-by: Mateusz Ziarko <[email protected]>
Co-authored-by: Maksymilian Pamuła <[email protected]>

* chore: version bump & docs update

Co-authored-by: Rafael Faria <[email protected]>
Co-authored-by: Tomasz Puch <[email protected]>
Co-authored-by: kamilszewczyk0 <[email protected]>
Co-authored-by: AndrzejBugdol <[email protected]>
Co-authored-by: Kamil Szewczyk <[email protected]>
Co-authored-by: Andrzej Bugdol <[email protected]>
Co-authored-by: Maksymilian Pamuła <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants