[CU-2cq60k0] feat: issue #113 author field population #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #133 +/- ##
==========================================
Coverage ? 40.04%
==========================================
Files ? 9
Lines ? 497
Branches ? 192
==========================================
Hits ? 199
Misses ? 296
Partials ? 2
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
ltsNotMike
approved these changes
Apr 19, 2022
cyp3rius
force-pushed
the
feat/author-fields-population
branch
from
8e3006d to
f1d5fa5
Compare
cyp3rius
changed the title
cyp3rius
added a commit
that referenced
this pull request
Apr 22, 2022
* Feat/typescript (#123) * Feat: add pt-BR translation (#119) * feat: add pt-br translation * refac: add missing key * fix: approved translation * chore: version bump * feat: typescript flow and basic typings * feat: ts-jest and tests * feat: client service to typescript * feat: types functions utils * fix: runtime errors * feat: usage of strapi-typed package and coverage for services * chore: strapi-typed version bump * feat: initial ts move done * chore: prettier formatting * moved types out to strapi-typed * fix: fixing pluginId importing * Update server/services/utils/functions.ts Co-authored-by: Tomasz Puch <[email protected]> * Update server/services/utils/functions.ts Co-authored-by: Tomasz Puch <[email protected]> * Update strapi-server.ts Co-authored-by: Tomasz Puch <[email protected]> * Update types/config.d.ts Co-authored-by: Tomasz Puch <[email protected]> * Update types/controllers.d.ts Co-authored-by: Tomasz Puch <[email protected]> * refactor: reworks after review * refactor: last reworks * refactor: prettier formatting Co-authored-by: Rafael Faria <[email protected]> Co-authored-by: Tomasz Puch <[email protected]> * chore: version bump * fix: package.json outdated * feat: typescripted client service and controllers * Feat/rest fields query (#132) * feat: issue #115 support rest select fields in query * chore: bump strapi-typed to 1.0.8 * refactor: reworks based on pr comments * refactor: typings alignments based on pr review * [CU-2cq60k0] feat: issue #113 author field population (#133) * feat: issue #115 support rest select fields in query * feat: issue #113 author field population * refactor: reworks after pr review * chore: bump strapi-typed version * [CU-2cq6299] chore/api service client tests (#134) * feat: issue #115 support rest select fields in query * feat: issue #113 author field population * refactor: reworks after pr review * feat: issue #115 support rest select fields in query * chore: client api service tests coverage * fix: conflicts resolution * fix: small some tests fixes * refactor: prettier formatting Co-authored-by: Rafael Faria <[email protected]> Co-authored-by: Tomasz Puch <[email protected]>
cyp3rius
added a commit
that referenced
this pull request
Oct 12, 2022
* Feat/typescript (#123) * Feat: add pt-BR translation (#119) * feat: add pt-br translation * refac: add missing key * fix: approved translation * chore: version bump * feat: typescript flow and basic typings * feat: ts-jest and tests * feat: client service to typescript * feat: types functions utils * fix: runtime errors * feat: usage of strapi-typed package and coverage for services * chore: strapi-typed version bump * feat: initial ts move done * chore: prettier formatting * moved types out to strapi-typed * fix: fixing pluginId importing * Update server/services/utils/functions.ts Co-authored-by: Tomasz Puch <[email protected]> * Update server/services/utils/functions.ts Co-authored-by: Tomasz Puch <[email protected]> * Update strapi-server.ts Co-authored-by: Tomasz Puch <[email protected]> * Update types/config.d.ts Co-authored-by: Tomasz Puch <[email protected]> * Update types/controllers.d.ts Co-authored-by: Tomasz Puch <[email protected]> * refactor: reworks after review * refactor: last reworks * refactor: prettier formatting Co-authored-by: Rafael Faria <[email protected]> Co-authored-by: Tomasz Puch <[email protected]> * chore: version bump * fix: package.json outdated * feat: typescripted client service and controllers * Feat/rest fields query (#132) * feat: issue #115 support rest select fields in query * chore: bump strapi-typed to 1.0.8 * refactor: reworks based on pr comments * refactor: typings alignments based on pr review * [CU-2cq60k0] feat: issue #113 author field population (#133) * feat: issue #115 support rest select fields in query * feat: issue #113 author field population * refactor: reworks after pr review * chore: bump strapi-typed version * [CU-2cq6299] chore/api service client tests (#134) * feat: issue #115 support rest select fields in query * feat: issue #113 author field population * refactor: reworks after pr review * feat: issue #115 support rest select fields in query * chore: client api service tests coverage * fix: conflicts resolution * fix: small some tests fixes * refactor: prettier formatting * feat: create reports page [CU-20rfmkv] (#153) * feat: reports page * refactor: changes after code review * Feat/moderator responses in threads (#150) * feat: Change WYSIWYG to TypeScript * feat: Moderator response under thread * feat: Delete comment * feat: New comment notifications and standardize of refresh * feat: Update and StartThread functionality * fix: Blocking thread and comment of reported comment * refactor: reworks after review * refactor: reworks after further reviews * Merge branch 'develop' into feat/moderator-responses-in-threads Co-authored-by: Kamil Szewczyk <[email protected]> * chore: version bump * fix: fixes after merge * feat: comments custom field [CU-2tn2923] (#157) * feat: comments custom field * chore: code coverage * fix: pr feedback and tests * chore: tests rename * fix: failing test * chore: version update * feat: custom field icon * fix: failing tests * fix: typescript build failing * fix: add env and change path (#158) Co-authored-by: Mateusz Ziarko <[email protected]> Co-authored-by: Maksymilian Pamuła <[email protected]> * chore: version bump & docs update Co-authored-by: Rafael Faria <[email protected]> Co-authored-by: Tomasz Puch <[email protected]> Co-authored-by: kamilszewczyk0 <[email protected]> Co-authored-by: AndrzejBugdol <[email protected]> Co-authored-by: Kamil Szewczyk <[email protected]> Co-authored-by: Andrzej Bugdol <[email protected]> Co-authored-by: Maksymilian Pamuła <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
#113
Summary
What does this PR do/solve?
Provides ability to populate author field and all fields related to it.
Test Plan
Scenario 1
api/comments/api::page.page:1/flat?populate[author][populate][0]=roleroleis part of theauthorper each commentScenario 2
avatarfield to theUserCollection and set it for your test usersapi/comments/api::page.page:1/flat?populate[author][populate][0]=role&populate[author][populate][1]=avatarroleis part of theauthorper each comment as well asavatar