Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regional Assessment of Risk Using Point Clouds #372

Closed

Conversation

RobynCastro
Copy link
Collaborator

@RobynCastro RobynCastro commented Feb 21, 2019

Please fill out the following before requesting review on this PR

Description

Created a node that takes in a point cloud of the ground and outputs a regional assessment of risk. Risk is based on factors like standard deviation of Z.

Testing Done

Unit tests were done to test functionality of each function.

Functional testing was done by visualising a point cloud in Rviz and then checking the output. The point cloud was taken using the Realsense.

Resolved Issues

resolves #349

Review Checklist

(Please check every item to indicate your code complies with it (by changing [ ]->[x]). This will hopefully save both you and the reviewer(s) a lot of time!)
It is the reviewers responsibility to also make sure every item here has been covered

  • Start of document comments: each .cpp and .h file should have a comment at the start of it. See files in src/sample_package for examples.
  • Function comments: All function definitions (usually in the .h file) should have a javadoc style comment at the start of them. For examples, see the classes defined in src/sample_package
  • Remove all commented out code
  • Remove extra print statements: for example, those just used for testing
  • Resolve all TODO's: All TODO (or similar) statements should either be completed or associated with a github issue
    Feel free to make additions of things that we should be checking to this file if you think there's something missing!!!!

@RobynCastro RobynCastro changed the title Robyn/risk analysis Regional Assessment of Risk using Point Clouds Feb 23, 2019
@RobynCastro RobynCastro changed the title Regional Assessment of Risk using Point Clouds Regional Assessment of Risk Using Point Clouds Feb 23, 2019
Copy link
Collaborator

@garethellis0 garethellis0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOTE: I skipped over all the rviz marker stuff, because I think that's part of another PR that's in process? Let me know if I'm mistaken though!

Overall looks pretty good, no major functionality comments, just some comments on comments/documentation.

@garethellis0
Copy link
Collaborator

Looks like there are some error(s) in the CMakeLists.txt, building and running test locally should reveal them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a Risk Assessment System of the Surrounding Environment
3 participants