-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regional Assessment of Risk Using Point Clouds #372
Conversation
…nowbots#359)" (UBC-Snowbots#361)" This reverts commit 863ae21.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NOTE: I skipped over all the rviz marker stuff, because I think that's part of another PR that's in process? Let me know if I'm mistaken though!
Overall looks pretty good, no major functionality comments, just some comments on comments/documentation.
Looks like there are some error(s) in the |
Please fill out the following before requesting review on this PR
Description
Created a node that takes in a point cloud of the ground and outputs a regional assessment of risk. Risk is based on factors like standard deviation of Z.
Testing Done
Unit tests were done to test functionality of each function.
Functional testing was done by visualising a point cloud in Rviz and then checking the output. The point cloud was taken using the Realsense.
Resolved Issues
resolves #349
Review Checklist
(Please check every item to indicate your code complies with it (by changing
[ ]
->[x]
). This will hopefully save both you and the reviewer(s) a lot of time!)It is the reviewers responsibility to also make sure every item here has been covered
.cpp
and.h
file should have a comment at the start of it. See files insrc/sample_package
for examples..h
file) should have a javadoc style comment at the start of them. For examples, see the classes defined insrc/sample_package
TODO
(or similar) statements should either be completed or associated with a github issueFeel free to make additions of things that we should be checking to this file if you think there's something missing!!!!