Revert "Pegged librealsense Version as a Temporary Fix (#359)" #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
)" This reverts commit fd31afd.
RobynCastro
added a commit
to RobynCastro/Snowflake
that referenced
this pull request
Dec 1, 2018
…nowbots#359)" (UBC-Snowbots#361)" This reverts commit 863ae21.
5 tasks
RobynCastro
added a commit
that referenced
this pull request
Dec 14, 2018
RobynCastro
added a commit
that referenced
this pull request
Jan 19, 2019
* Revert "Revert "Pegged librealsense Version as a Temporary Fix (#359)" (#361)" This reverts commit 863ae21. * Changed setup_realsense realsense version to a working version * Updated realsense version * Fixed install_tools script * Now pegging versions for realsense library and package * Now manually installing realsense in the scripts * Changed external_libs installation path to the root directory * Added external libs to git ignore
RobynCastro
added a commit
that referenced
this pull request
Feb 23, 2019
* Revert "Revert "Pegged librealsense Version as a Temporary Fix (#359)" (#361)" This reverts commit 863ae21. * Changed setup_realsense realsense version to a working version * Updated realsense version * Fixed install_tools script * Removed the navigation package * Removed navigation from the install_dependencies script
RobynCastro
added a commit
that referenced
this pull request
Feb 23, 2019
) * Revert "Revert "Pegged librealsense Version as a Temporary Fix (#359)" (#361)" This reverts commit 863ae21. * Changed setup_realsense realsense version to a working version * Updated realsense version * Fixed install_tools script * Refactored zed_transform to pcl_transform and added a new param * Fixed output frame_id for pcl_transform * Update src/sb_pointcloud_processing/src/pcl_transform.cpp Removed space between time and (s) Co-Authored-By: RobynCastro <[email protected]> * Reordered CMakeLists.txt and changed when pcl_transform will log messages
WilliamGu98
pushed a commit
that referenced
this pull request
Mar 16, 2019
* Added rviz polygon markers * Fixed a function javadoc commentfor createPolygonMarker * Resolved type mismatch in RvizUtils * Ran fix formatting script * Added point equality testing inside multiplePointMarkersTest * Ran fix formatting script * Revert "Revert "Pegged librealsense Version as a Temporary Fix (#359)" (#361)" This reverts commit 863ae21. * Changed setup_realsense realsense version to a working version * Updated realsense version * Fixed install_tools script * Added reasoning why rviz_utils uses a rostest * Templating the polygon risk function * Fixed type for createMarkerScale * Fixed typo in rostest * Fixed rviz polygon tests to account for cycles * Removed the node for rviz_utils_rostest * Fixed file naming inside rviz_utils_rostest * No longer templating and now forcing marker_id specification * Fixed ros_tests to work with sb_geom_msgs::Polygon2D * Ran fix formatting * Updated sb_utils to build messages first * Removed publisher and subscriber * removed redundant gitignore * Added back missing javadoc param statements * Moved the end of file down * Fixed the sb_utils test to run rostest instead of gtest * Fixed formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please fill out the following before requesting review on this PR
Description
This reverts commit fd31afd, now thathttps://github.com/IntelRealSense/realsense-ros/issues/502#event-1944687405 has been closed.
Testing Done
Once CI passes on this PR, should be good to go.
Resolved Issues
resolves #359
Review Checklist
(Please check every item to indicate your code complies with it (by changing
[ ]->[x]). This will hopefully save both you and the reviewer(s) a lot of time!)It is the reviewers responsibility to also make sure every item here has been covered
.cppand.hfile should have a comment at the start of it. See files insrc/sample_packagefor examples..hfile) should have a javadoc style comment at the start of them. For examples, see the classes defined insrc/sample_packageTODO(or similar) statements should either be completed or associated with a github issueFeel free to make additions of things that we should be checking to this file if you think there's something missing!!!!