-
Notifications
You must be signed in to change notification settings - Fork 425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix YouTube playlists continuations #567
Fix YouTube playlists continuations #567
Conversation
Requires sending a POST request instead of GET. clientName and clientVersion, which were required as headers previously now need to be part of the request payload. continuation id also needs to be part of request body. quick and dirty solution.
Normally i would say: "just look at the tests and you can see that the fix works" But as you can see, the tests fail, now figure out thats it's not because of me.... |
Why are you using the hard-coded key? Iirc there was a method in some class to get the key dynamically 🤔 |
Because it's quick and dirty. Feel free to take this PR as a base and to refine it |
I fixed it in FireMasterK@179015b You can just add this commit :) |
Lovely how i can just open a PR with your changes in your fork against my own branch in my fork. So i don't have to boot up my PC to get the changes 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good. I did not have time to take a look at YouTube's requests, but you did, so that should be fine ;)
The tests pass and the changes work in the app.
Can be merged after addressing the review.
extractor/src/main/java/org/schabi/newpipe/extractor/services/youtube/YoutubeParsingHelper.java
Outdated
Show resolved
Hide resolved
@TiA4f8R You can open a PR for the channels |
I carefully read the contribution guidelines and agree to them.
Requires sending a POST request instead of GET.
clientName and clientVersion, which were required as headers previously now need to be part of the request payload.
continuation id also needs to be part of request body.
quick and dirty solution (very dirty)
app-debug.zip
I allowed edits by other maintainers, so just adjust it if there are any bugs