Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Youtube channels and playlist continuations broken #566

Closed
XiangRongLin opened this issue Mar 3, 2021 · 5 comments
Closed

Youtube channels and playlist continuations broken #566

XiangRongLin opened this issue Mar 3, 2021 · 5 comments
Labels
ASAP Issue needs to be fixed as soon as possible bug Issue is related to a bug youtube service, https://www.youtube.com/

Comments

@XiangRongLin
Copy link
Collaborator

XiangRongLin commented Mar 3, 2021 •
edited
Loading

From @TiA4f8R from IRC

Looks like a new hotfix release will be needed again for YouTube channels and also for playlists, because of a YouTube continuation endpoint change: #5739. Also, see iv-org/invidious#1838 and ytdl-org/youtube-dl#28289 (comment). I can reproduce the bug on my side.

The tests confirm it, see the scheduled run against real websites: https://github.com/TeamNewPipe/NewPipeExtractor/runs/2018005570?check_suite_focus=true#step:5:448

@TobiGr @Stypox
@XiangRongLin XiangRongLin added bug Issue is related to a bug ASAP Issue needs to be fixed as soon as possible youtube service, https://www.youtube.com/ labels Mar 3, 2021
@XiangRongLin XiangRongLin changed the title Youtube channels and playlist continuations were changed Youtube channels and playlist continuations broken Mar 3, 2021
@XiangRongLin
Copy link
Collaborator Author

I'll work on playlists for now

@AudricV
Copy link
Member

AudricV commented Mar 3, 2021 •
edited
Loading

From the youtube-dl issue: the new endpoint is a POST request to https://www.youtube.com/youtubei/v1/browse?key=AIzaSyAO_FJ2SlqU8Q4STEHLGCilw_Y9_11qcW8 (https://youtubei.googleapis.com/youtubei/v1/browse?key=AIzaSyAO_FJ2SlqU8Q4STEHLGCilw_Y9_11qcW8 works too, I tried this on my side) with the continuation token in the payload.
In the future, I think we need to move all YouTube endpoints to youtubei.googleapis.com.

@AudricV AudricV mentioned this issue Mar 3, 2021
Closed
4 tasks
@XiangRongLin
Copy link
Collaborator Author

#567 is open for playlists. Im done for today so someone else can work on channels or refine the stuff from my PR

@FireMasterK
Copy link
Member

I'm also going to create a new issue to use all the APIs from the mobile API, which will solve rate limiting issues.

@AudricV
Copy link
Member

AudricV commented Mar 5, 2021

Fixed with #567 and #570.

@AudricV AudricV closed this as completed Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
ASAP Issue needs to be fixed as soon as possible bug Issue is related to a bug youtube service, https://www.youtube.com/
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@FireMasterK @XiangRongLin @AudricV