Fix YouTube channels contination #570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TobiGr
added
bug
Co-authored-by: TiA4f8R <[email protected]>
TobiGr
force-pushed
the
fix-yt-channels-playlists
branch
from
bfc9ab8 to
2b671b1
Compare
FireMasterK
approved these changes
Mar 4, 2021
B0pol
requested changes
Mar 4, 2021
...n/java/org/schabi/newpipe/extractor/services/youtube/extractors/YoutubeChannelExtractor.java
Outdated
Show resolved
Hide resolved
…ractor Because it's unused with the new request. Co-authored-by: bopol <[email protected]>
|
The mocks for the other tests channel also need to be regenerated |
|
@XiangRongLin Can you check, whether I've done this correctly? |
B0pol
approved these changes
Mar 5, 2021
From a glance it looks good. Basically if the tests pass with the mock downloader then its good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix YouTube channels continuation extraction by using the same method as @XiangRongLin in #567.
APK to test: https://github.com/TiA4f8R/NewPipe/suites/2178388837/artifacts/44814609
(Sorry for the commits, I can't use my computer right now.)