Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust Page class to incorperate request body #569

Closed
XiangRongLin opened this issue Mar 4, 2021 · 3 comments
Closed

Adjust Page class to incorperate request body #569

XiangRongLin opened this issue Mar 4, 2021 · 3 comments
Assignees
Labels
youtube service, https://www.youtube.com/

Comments

@XiangRongLin
Copy link
Collaborator

With #567 I added a quick fix for the new continuations API. Instead of a GET request with headers and query parameters, now a POST request with the same information inside the request body is necessary. In that PR i just added that made that new custom request right inside the Extractor and passed on the continuations key as the id field of Page

This needs to be properly done, by also adding a request body field or something similiar to the Page class

@XiangRongLin XiangRongLin added the youtube service, https://www.youtube.com/ label Mar 4, 2021
@FireMasterK
Copy link
Member

Maybe a Map?

You can technically store everything you need there 🙂

@Stypox
Copy link
Member

Stypox commented Mar 18, 2021

I don't think a map is a good idea, it would make everything more difficult to understand and to test. I'd go with just a new request-body field in the class.

@XiangRongLin XiangRongLin self-assigned this Apr 1, 2021
@XiangRongLin
Copy link
Collaborator Author

Closed by #599

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
youtube service, https://www.youtube.com/
Projects
None yet
Development

No branches or pull requests

3 participants