Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade CMake #162

Closed
KrisThielemans opened this issue Dec 8, 2018 · 5 comments · Fixed by #221
Closed

upgrade CMake #162

KrisThielemans opened this issue Dec 8, 2018 · 5 comments · Fixed by #221
Assignees
@paskino
Milestone
v2.0

Comments

@KrisThielemans
Copy link
Member

See #103 for rationale

I think best to set required CMake version according to required Boost version

Will need to update build_essential-ubuntu.sh (see also SyneRBI/SyneRBI_VM#107)
@KrisThielemans KrisThielemans mentioned this issue Dec 8, 2018
Closed
@KrisThielemans
Copy link
Member Author

Also need to update .travis.yml sadly, also in SIRF.

We have 4 places (or more with Azure) where this CMake dependency is. Need to get working on #91 in 2019...

@KrisThielemans KrisThielemans mentioned this issue Dec 9, 2018
Closed
@KrisThielemans
Copy link
Member Author

KrisThielemans commented Dec 9, 2018 •
edited
Loading

Happy to require CMake 3.10. Can't do 3.11 really as Ubuntu bionic uses 3.10, but recommend 3.11 or later

@KrisThielemans
Copy link
Member Author

.travis.yml is updated via #176

KrisThielemans added a commit that referenced this issue Dec 13, 2018
@KrisThielemans
Merge pull request #176 from CCPPETMR/travis_cmake
b7fde26 
- upgrade CMake in .travis.yml to 3.13.1 (partially addresses #162)
- always build boost on linux as the system boost is too old on Trusty (Ubuntu 14.04) 
- don't build ACE as it currently fails (#174)
- make sure Travis fails if running CMake fails (fixed #175)
@KrisThielemans KrisThielemans mentioned this issue Dec 17, 2018
Closed
@KrisThielemans
Copy link
Member Author

@paskino, please update CMakeLists.txt to require 3.10 and update our install instructions to recommend using a recent CMake (at least 3.11)

@KrisThielemans KrisThielemans added this to the v2.0 milestone Feb 15, 2019
@paskino paskino mentioned this issue Mar 15, 2019
Merged
@KrisThielemans
Copy link
Member Author

KrisThielemans commented Mar 16, 2019 •
edited
Loading

docker/build_essential-ubuntu.sh already uses CMake 3.14 now. Azure uses https://github.com/CCPPETMR/CCPPETMR_VM/blob/master/scripts/INSTALL_CMake.sh which is fine as well

paskino pushed a commit to paskino/SIRF-SuperBuild that referenced this issue Oct 25, 2021
@rijobro
git fetch before checking out SB branch (SyneRBI#163)
c00922e 
Fixes SyneRBI#162
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paskino paskino

Labels
None yet
Projects
None yet
Milestone
v2.0
Development

Successfully merging a pull request may close this issue.

require CMake 3.10 SyneRBI/SIRF-SuperBuild
2 participants
@KrisThielemans @paskino