-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade Gadgetron and ISMRMRD #146
Comments
I see no reason not to do this. we'll have to move on soon anyway.
A pain. I'd like to avoid it.
I don't see how conda is going to help avoiding having to use gcc 6 for gadgetron.
As we're moving to SIRF 2.0, it's a good time to upgrade Gadgetron. So I wouldn't choose this option |
will need to change travis to use g++-6 |
conda can help by being able to install specific compilers? |
For gadgetron we're currently using both 1 and 2. |
@dchansen, sorry, not sure what you mean with
|
yeah, but who's going to do that, aside from you? |
I agree you probably don't want to conda install a compiler if you can avoid it - people will get the new compiler overriding their system one in that environment without necessarily realising. |
@KrisThielemans it's not so trivial to install a different compiler with conda. Though conda provides new compilers (only for Mac and Linux), conda-forge is not currently using those. |
@casperdcl the compiler is requested only for the build (possibly) |
let's not rely on conda for getting the correct compiler for the build. Also, major upgardes between compilers can mean ABIs are not compatible etc. I'm not saying we shouldn't pursue conda, but I think hoping that it will solve our problems for this particular issue is asking for too much. |
I agree with @KrisThielemans, I think using conda in this way is asking for trouble. |
OK, I'll proceed with option 1. |
Depends on #162 |
@rijobro you're working on this. It's quite tricky though. Please refer to this issue with your updates and comment. |
external fix required (PR on gadgetron: gadgetron/gadgetron#726). Once this is done, should be ok to update. |
Done in #205 |
New Gadgetron needs gcc 6.0 and newer ISMRMRD. See previous discussion at #145.
Ubuntu 16.04 has 5.4. On the VM it could be possible to install gcc version 6 following this link
@paskino sees a few options:
Although option 3 is still in a work-in-progress phase @paskino strongly believes that we should pursue that direction.
Originally posted by @paskino in #145 (comment)
The text was updated successfully, but these errors were encountered: