Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade Gadgetron and ISMRMRD #146

Closed
KrisThielemans opened this issue Oct 4, 2018 · 17 comments
Closed

upgrade Gadgetron and ISMRMRD #146

KrisThielemans opened this issue Oct 4, 2018 · 17 comments
Milestone

Comments

@KrisThielemans
Copy link
Member

New Gadgetron needs gcc 6.0 and newer ISMRMRD. See previous discussion at #145.

Ubuntu 16.04 has 5.4. On the VM it could be possible to install gcc version 6 following this link

@paskino sees a few options:

  1. Build a new VM with Ubuntu 18.04 which ships GCC 7.3.0
  2. Add the new unofficial repository to get GCC 6 onto the current VM (Ubuntu 16.04)
  3. Use conda
  4. Keep outdated Gadgetron in the short term.

Although option 3 is still in a work-in-progress phase @paskino strongly believes that we should pursue that direction.

Originally posted by @paskino in #145 (comment)

This was referenced Oct 4, 2018
@KrisThielemans
Copy link
Member Author

KrisThielemans commented Oct 4, 2018

Build a new VM with Ubuntu 18.04 which ships GCC 7.3.0

I see no reason not to do this. we'll have to move on soon anyway.

Add the new unofficial repository to get GCC 6 onto the current VM (Ubuntu 16.04)

A pain. I'd like to avoid it.

Use conda

I don't see how conda is going to help avoiding having to use gcc 6 for gadgetron.

Keep outdated Gadgetron in the short term.

As we're moving to SIRF 2.0, it's a good time to upgrade Gadgetron. So I wouldn't choose this option

@KrisThielemans
Copy link
Member Author

@dchansen, @xueh2 what would a good Gadgteron, and ISMRMRD commit be?

@KrisThielemans
Copy link
Member Author

will need to change travis to use g++-6

@paskino
Copy link
Contributor

paskino commented Oct 4, 2018

conda can help by being able to install specific compilers?

@dchansen
Copy link

dchansen commented Oct 4, 2018

For gadgetron we're currently using both 1 and 2.
We're moving to Ubuntu 18.04 as soon as everything (non-Gadgetron) works on the scanner side, and in the meantime we've upgraded our docker images with GCC 6.

@KrisThielemans
Copy link
Member Author

@dchansen, sorry, not sure what you mean with

For gadgetron we're currently using both 1 and 2.

@KrisThielemans
Copy link
Member Author

KrisThielemans commented Oct 4, 2018

conda can help by being able to install specific compilers?

yeah, but who's going to do that, aside from you?

@casperdcl
Copy link
Member

casperdcl commented Oct 4, 2018

I agree you probably don't want to conda install a compiler if you can avoid it - people will get the new compiler overriding their system one in that environment without necessarily realising.

@paskino
Copy link
Contributor

paskino commented Oct 4, 2018

@KrisThielemans it's not so trivial to install a different compiler with conda. Though conda provides new compilers (only for Mac and Linux), conda-forge is not currently using those.

@paskino
Copy link
Contributor

paskino commented Oct 4, 2018

@casperdcl the compiler is requested only for the build (possibly)

@KrisThielemans
Copy link
Member Author

let's not rely on conda for getting the correct compiler for the build. Also, major upgardes between compilers can mean ABIs are not compatible etc. I'm not saying we shouldn't pursue conda, but I think hoping that it will solve our problems for this particular issue is asking for too much.

@bathomas
Copy link
Contributor

bathomas commented Oct 4, 2018

I agree with @KrisThielemans, I think using conda in this way is asking for trouble.

@paskino
Copy link
Contributor

paskino commented Oct 4, 2018

OK, I'll proceed with option 1.

@KrisThielemans
Copy link
Member Author

Depends on #162

@KrisThielemans
Copy link
Member Author

@rijobro you're working on this. It's quite tricky though. Please refer to this issue with your updates and comment.

@KrisThielemans KrisThielemans added this to the v2.0 milestone Feb 15, 2019
@rijobro
Copy link
Contributor

rijobro commented Feb 15, 2019

external fix required (PR on gadgetron: gadgetron/gadgetron#726).

Once this is done, should be ok to update.

@KrisThielemans
Copy link
Member Author

Done in #205

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants