Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FindOPENMP changed since CMake 3.9 (older version breaks SIRFReg) #259

Closed
KrisThielemans opened this issue Dec 17, 2018 · 3 comments
Closed
Assignees
Milestone

Comments

@KrisThielemans
Copy link
Member

Since CMake 3.9, FindOPENMP has OpenMP_<lang>_FOUND and defines the OpenMP::OpenMP_<lang> target. Before that, it had OPENMP_FOUND and OpenMP_CXX_FLAGS (and no link flag, causing a bug on some systems for linking).

This breaks our lines to accomodate OpenMP and NiftyReg

As we'll have boost problem dependencies etc with older CMake as well, I suggest we up to requirements to CMake 3.9. Objections?

@KrisThielemans KrisThielemans changed the title FindOPENMP changes after CMake 3.8 (breaks SIRFReg) FindOPENMP changed since CMake 3.9 (older version breaks SIRFReg) Dec 17, 2018
@KrisThielemans KrisThielemans added this to the v2.0 milestone Feb 23, 2019
@KrisThielemans
Copy link
Member Author

@rijobro, only thing that needs to happen is up requirement for CMake version to 3.9.0 (and therefore edit installation instructions and CHANGES.md)

@rijobro
Copy link
Contributor

rijobro commented Mar 18, 2019

Ok

@KrisThielemans
Copy link
Member Author

fixed by #331

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants