Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re/add alerts for new numbers #2456

Open
wants to merge 196 commits into
base: spoke14.1_tollfree
Choose a base branch
from
Open

Re/add alerts for new numbers #2456

wants to merge 196 commits into from

Conversation

engelhartrueben
Copy link
Collaborator

@engelhartrueben engelhartrueben commented Sep 18, 2024 •
edited
Loading

Fixes # (issue)

Adds alerts for Toll free and Short Code numbers

Description

Had to merge in stage-main-14.1 in order to properly work on this. Should have squashed. My bad.
Please reach out for demo and/or explanation.
View this diff for easier review: stage-main-14.1...re/add-alerts-for-new-numbers

When checking Toll free with 2 numbers in:
image

When check short codes with no available
image

Checklist:

  • I have manually tested my changes on desktop and mobile
  • The test suite passes locally with my changes
  • If my change is a UI change, I have attached a screenshot to the description section of this pull request
  • My change is 300 lines of code or less, or has a documented reason in the description why it’s longer
  • I have made any necessary changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • My PR is labeled [WIP] if it is in progress

crayolakat and others added 30 commits December 1, 2022 14:12
@crayolakat
Cascade delete interaction step
3a39a6c
@crayolakat
Add catch
2fd7b02
@crayolakat
Change console.log to console.error
99aee7f
@crayolakat
Merge branch 'main' into cascade_delete_interaction_step
254ba40
@crayolakat
SQLite adjustments
383c065
@crayolakat
Update bug_report.md
bb47f9f
@crayolakat
Get contactTimezones when not caching
40095d9
@crayolakat
Grant permission to public schema
27fef93
@codygordon
bulk send batch progress UI
b62af01
@codygordon
remove package.json browser crypto fix
9b6ae4c
@crayolakat
Update HOWTO-configure-auth0.md
f2b1689
@codygordon
increase actions test timeouts to 15 min
7e6cdf2
@crayolakat
Update release notes
27b6f29
@crayolakat
Merge branch 'kathy_catch_batch_insert' into main-stage-13.2.0
c2df884
@crayolakat
Merge branch 'kathy-update-bug-report-template' into main-stage-13.2.0
cd105b4
@crayolakat
Update RELEASE_NOTES.md
1c0eba3
@crayolakat
Merge branch 'kathy-fix-contact-timezones' into main-stage-13.2.0
09ebfc9
@crayolakat
Update RELEASE_NOTES.md
9555186
@crayolakat
Merge branch 'bulk-send-progress-ui' into main-stage-13.2.0
f8b256e
@crayolakat
Update RELEASE_NOTES.md
4d3b134
@crayolakat
Merge branch 'kathy-pg-compatibility' into main-stage-13.2.0
baaa269
@crayolakat
Update RELEASE_NOTES.md
30c56fc
@crayolakat
Merge branch 'kathy-update-auth0-rule' into main-stage-13.2.0
64efc80
@crayolakat
Update RELEASE_NOTES.md
c822e8d
@ibrand
Update README.md to reflect the state of the Spoke hand off
edad853
@ibrand
add remote switching to the README
47ae9de
@ibrand
Merge pull request #5 from MoveOnOrg/ibrand-patch-1
39422f3 
Update README.md to reflect the state of the Spoke hand off
@crayolakat
Merge branch 'main-stage-13.2.0'
49415b9
@crayolakat
Update HOWTO-use_bulk_sending.md
d43a128
@crayolakat
Update Bandwidth docs
99acc07
engelhartrueben and others added 22 commits September 4, 2024 09:43
@engelhartrueben
Merge pull request #2389 from StateVoicesNational/re/fix-sqlite
74558a6 
bug/2234 fixing sqlite
@engelhartrueben
Merge pull request #2408 from StateVoicesNational/group-survey
89fcd2e 
#2408 Grouped survey stats
@engelhartrueben
fixe function typeError
7c28980
@engelhartrueben
Merge pull request #2423 from StateVoicesNational/mz/merge-moveon-14.1
1bf7c39 
#2423 Dynamic Replies Feature - by MoveOn
@mau11
Merge pull request #2431 from aflcio/org-message-handlers
3c2456e 
Allow org-specific message handlers
@engelhartrueben
Merge branch 'stage-main-14.1' into re/google-docs-integration-UI
1d2113b
@mau11
Merge pull request #2432 from StateVoicesNational/re/google-docs-inte…
237fc52 
…gration-UI

Google Docs Script Import UI
@mau11
Merge pull request #2371 from StateVoicesNational/stefanhayden/cypres…
b7985fb 
…s-upgrade

Upgrade cypress from 5.6.0 to 13.11.0
@engelhartrueben
Merge pull request #2417 from mcverter/mverter/relative-links-in-mark…
32f2d70 
…down

#2417 use relative paths for markdown links
@mau11
Merge pull request #2416 from mcverter/2201-alphabetize-orgs-right-menu
7675125 
organizations sorted in right side UserMenu
@engelhartrueben
re add old styling for floatingButton. Unsure where/why this was removed
99ee3f0
@mau11
Update texter view styling to be more responsive
e707bc1
@engelhartrueben
upgrade upload artifact to V4. V2 was deprecated June 30, 2024.
a8c4686
@mau11
Merge branch 'stage-main-14.1' into mz/update-texter-view-styling
534dca5
@engelhartrueben
Merge pull request #2451 from StateVoicesNational/mz/update-texter-vi…
1d4ae9e 
…ew-styling

#2451 Update texter view styling to be more responsive
@engelhartrueben
remove twice called variant
c1d0dad
@engelhartrueben
merge stage-main-14.1
16a7203
@engelhartrueben
basic implementation of short code and toll free popup. Unable to do …
78a4884 
…this async due to jobs table
@engelhartrueben
add componentDidUpdate functionality for toll free and short code
4fc1c24
@engelhartrueben
add area code to job payload
fc79122
@engelhartrueben
add get_toll_free and get_short_code to pendingPhoneNumberJobs in ord…
29e6920 
…er to keep track of their completion
@engelhartrueben
adjust logic to properly present the outcome of chekcing shortcode/to…
a5f9c69 
…llfree
@engelhartrueben engelhartrueben added the S-work in progress (WIP) Status: PR label for work that is not yet ready to be reviewed label Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mau11 mau11 Awaiting requested review from mau11

@mabrownnyu mabrownnyu Awaiting requested review from mabrownnyu

Assignees
No one assigned
Labels
S-work in progress (WIP) Status: PR label for work that is not yet ready to be reviewed
Projects
Spoke Release Schedule
Status: FEATURES
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.