Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update texter view styling to be more responsive #2451

Merged
merged 2 commits into from
Sep 13, 2024

Conversation

mau11
Copy link
Member

@mau11 mau11 commented Sep 12, 2024

Fixes # (issue)

Description

Styling updates (see screenshots below) + fixed sidescroll on mobile

before (empty chat)

Screenshot 2024-09-12 at 2 00 38 PM Screenshot 2024-09-12 at 2 01 14 PM

after (empty chat)

Screenshot 2024-09-12 at 1 57 15 PM Screenshot 2024-09-12 at 1 57 31 PM

before (messages in chat)

Screenshot 2024-09-12 at 2 01 43 PM Screenshot 2024-09-12 at 2 02 03 PM

after (messages in chat)

Screenshot 2024-09-12 at 1 58 49 PM Screenshot 2024-09-12 at 1 59 07 PM

Checklist:

  • I have manually tested my changes on desktop and mobile
  • The test suite passes locally with my changes
  • If my change is a UI change, I have attached a screenshot to the description section of this pull request
  • My change is 300 lines of code or less, or has a documented reason in the description why it’s longer
  • I have made any necessary changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • My PR is labeled [WIP] if it is in progress

@mau11
Copy link
Member Author

mau11 commented Sep 12, 2024

@engelhartrueben
Copy link
Collaborator

@mau11 That V2 action was deprecated June 30, 2024, and changing it to V4 fixes that. I ran into it this morning on a different branch - I pushed a commit to stage-main-14.1. Please rebase!

I can take a look at this later tonight, but this looks great (:

@mau11 mau11 mentioned this pull request Sep 12, 2024
Copy link
Collaborator

@engelhartrueben engelhartrueben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@engelhartrueben engelhartrueben merged commit 1d4ae9e into stage-main-14.1 Sep 13, 2024
17 checks passed
@engelhartrueben engelhartrueben deleted the mz/update-texter-view-styling branch September 13, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 14.1
Development

Successfully merging this pull request may close these issues.

2 participants