Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow org-specific message handlers #2431

Merged

Conversation

jeffm2001
Copy link
Collaborator

Fixes # (issue)

Description

The getMessageHandlers function accepts an organization argument, but we weren't actually passing it in. Passing the organization when retrieving available handlers makes it possible to configure these on a per-org basis. There's no user interface for it, but you can do it by adjusting the features json blob in the organization table. (This is how service managers work as well).

Checklist:

  • I have manually tested my changes on desktop and mobile
  • The test suite passes locally with my changes
  • If my change is a UI change, I have attached a screenshot to the description section of this pull request
  • My change is 300 lines of code or less, or has a documented reason in the description why it’s longer
  • [] I have made any necessary changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • My PR is labeled [WIP] if it is in progress

@engelhartrueben
Copy link
Collaborator

Thanks for bringing this PR. It makes sense to allow this. We can include this in the next release.

Copy link
Contributor

@sduveen-pivot sduveen-pivot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@mau11 mau11 changed the base branch from main to stage-main-14.1 September 4, 2024 19:12
@mau11 mau11 merged commit 3c2456e into StateVoicesNational:stage-main-14.1 Sep 4, 2024
8 checks passed
@mau11 mau11 mentioned this pull request Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 14.1
Development

Successfully merging this pull request may close these issues.

4 participants