Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Docs Script Import UI #2432

Merged
merged 12 commits into from
Sep 4, 2024
Merged

Conversation

engelhartrueben
Copy link
Collaborator

Fixes # (issue)

Shows the Google client_email email on the front for easy access.

Description

The client_email is what is used to share a Google Doc to a Google Docs API for the Script Import feature.

It is important to show because this email is long and convoluted, making it impossible to remember. Best to have an easy way of copy and pasting!

Additional features:

  • Change the scope of the API call to read only
  • Add error handling when parsing the GOOGLE_SECRET JSON object for client_email, which also includes a front end error message in the event that GOOGLE_SECRET is fractured in some way.

TO DO: Add screenshots

REQUEST FROM REVIEWER: Specifically review error messages and advise. Is the message clear and useful?

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change, and any blockers that make your change a WIP

Checklist:

  • I have manually tested my changes on desktop and mobile
  • The test suite passes locally with my changes
  • If my change is a UI change, I have attached a screenshot to the description section of this pull request
  • My change is 300 lines of code or less, or has a documented reason in the description why it’s longer
  • I have made any necessary changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • My PR is labeled [WIP] if it is in progress

@engelhartrueben engelhartrueben added the S-work in progress (WIP) Status: PR label for work that is not yet ready to be reviewed label Aug 20, 2024
@engelhartrueben engelhartrueben marked this pull request as ready for review September 4, 2024 13:42
@engelhartrueben engelhartrueben removed the S-work in progress (WIP) Status: PR label for work that is not yet ready to be reviewed label Sep 4, 2024
@mau11 mau11 merged commit 237fc52 into stage-main-14.1 Sep 4, 2024
17 checks passed
@mau11 mau11 mentioned this pull request Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 14.1
Development

Successfully merging this pull request may close these issues.

2 participants