Add aciconvert subcommand to confcom

[ksayid]

Introduces aciconvert subcommand, which converts ARM templates, images, or YAML files into JSON format. This was an ask from an internal customer.

Other changes

• Env vars are now sorted alphabetically in the policy. This was done to make the policy from $$\text{YAML} \overset{\text{aciconvert}}{\to} \text{JSON} \overset{\text{acipolicygen}}{\to} \text{Policy}$$ match the policy from $$\text{YAML} \overset{\text{acipolicygen}}{\to} \text{Policy}$$
• Made a few tests more flexible. They assumed the positions of env vars in the policy, but now we just check for existence in the list of env vars.

[Copilot]

Copilot reviewed 5 out of 9 changed files in this pull request and generated 2 comments.

Files not reviewed (4)

• src/confcom/azext_confcom/commands.py: Evaluated as low risk
• src/confcom/azext_confcom/_validators.py: Evaluated as low risk
• src/confcom/azext_confcom/_params.py: Evaluated as low risk
• src/confcom/azext_confcom/container.py: Evaluated as low risk

Comments suppressed due to low confidence (1)

src/confcom/azext_confcom/custom.py:400

• The filename handling logic in the loop could lead to unexpected behavior if multiple policies are generated. Ensure the filenames are correctly handled to avoid overwriting files.

output_filename = f"{output_filename_base}_({i}).json"

[Copilot]

The split operation on the environment variable rule assumes there will always be exactly one '=' character. Add a check to ensure the rule format is correct before splitting.

Suggested change

	rule = temp_env["name"] = env[config.POLICY_FIELD_CONTAINERS_ELEMENTS_ENVS_RULE]
	if rule.count('=') != 1: logger.warning("Environment variable rule %s has more than one '='. Please verify its format in the output file", rule); continue

[Copilot]

The function does not handle cases where all input parameters (arm_template, image_name, virtual_node_yaml_path) are None. This could lead to a situation where container_group_policies is None, causing the subsequent code to fail. Add a check to ensure at least one input parameter is provided and raise a clear error message if not.

[hgarvison]

Why are these commented out?