adding bugfix and test for persistent volume template #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SethHollandsworth
requested review from
hgarvison and
stevendongatmsft
as code owners
| } | ||
| vct_spec = case_insensitive_dict_get(volume_claim_template, "spec") | ||
| if vct_spec: | ||
| vct_access_modes = case_insensitive_dict_get(vct_spec, "accessModes") |
There was a problem hiding this comment.
Add a null check for vct_access_modes before checking its contents to avoid potential errors.
Suggested change
| vct_access_modes = case_insensitive_dict_get(vct_spec, "accessModes") | |
| if vct_access_modes and config.VIRTUAL_NODE_YAML_READ_ONLY_MANY in vct_access_modes: |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
| @@ -1104,45 +1106,63 @@ def load_policy_from_virtual_node_yaml_str( | |||
| envs += config.VIRTUAL_NODE_ENV_RULES_WORKLOAD_IDENTITY | |||
|
|
|||
| # command | |||
| command = case_insensitive_dict_get(container, "command") or [] | |||
| command = case_insensitive_dict_get(container, config.VIRTUAL_NODE_YAML_LIFECYCLE_COMMAND) or [] | |||
There was a problem hiding this comment.
The command field should refer to the container's command, not the lifecycle command. Use the correct config field for the container's command.
Suggested change
| command = case_insensitive_dict_get(container, config.VIRTUAL_NODE_YAML_LIFECYCLE_COMMAND) or [] | |
| command = case_insensitive_dict_get(container, config.VIRTUAL_NODE_YAML_COMMAND) or [] |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
ksayid
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Andrea found a bug where implicit volumes with volumeClaimTemplates were not being recognized. This adds them as an option and marks them as readonly if "ReadOnlyMany" is used when declaring.