Can't use az image copy #84
Assignees
Labels
Comments
|
@Wolf7horne Are you attempting to use this against Public Azure? |
|
@derekbekoe Yes I am. |
|
|
|
@Wolf7horne |
|
@tamirkamara the same issue, full output attached. Full command |
|
@PoisonousJohn Tamir |
|
@tamirkamara as it was mentioned by @Wolf7horne, the case is related to blob-based image (non-managed disk). I understand that for now this extension assumes you're using image disk. Do you have any plans on supporting blob images? |
3 tasks
runefa
added a commit
to runefa/azure-cli-extensions
that referenced
this issue
May 4, 2022
* Added FileShare commands. * Updated params to match spec. Added param help. * Added help. Removed --ids support. * Removed automatic import statements. * Added back type in help. * Added tests. * Updated param names to better reflect AzureFile dependency. * Added validation to ensure share name and account name are longer than 2 characters. Seems to be an API issue. * Added warning message if user is updating existing storage. Co-authored-by: Haroon Feisal <[email protected]>
StrawnSC
added a commit
to StrawnSC/azure-cli-extensions
that referenced
this issue
May 19, 2022
* Marchp1s and add back Identity (#57) * Skeleton code * az containerapp env show * List kube/managed environments * Create kube environment, wait doesn't work yet * Update containerapp stubs (check if it is supported now) * Containerapp env delete, polling not working yet * Added polling for create and delete * Use Microsoft.App RP for show, list, delete command * Create containerapp env using Microsoft.App RP * Add optional containerapp env create arguments * Remove old kube environment code, naming fixes * Containerapp create almost done * Done containerapp create, except for --yaml. Need to test * Containerapp show, list * Fix helptext * Containerapp delete * Containerapp update. Needs secrets api to be implemented, and testing * Add scale command * Various validations, small fixes * listSecrets API for updates, autogen log analytics for env * Use space delimiter for secrets and env variables * Verify sub is registered to Microsoft.ContainerRegistration if creating vnet enabled env, remove logs-type parameter * Containerapp create --yaml * Fix updating registry to do create or update * Fix containerapp update command. Add image-name parameter to support multi container updates. Fix updating registries, containers and secrets * started update with --yaml. Need to do create or update for when an attribute is a list of items * use space delimiter for startup_command and args, instead of comma delimiter * Traffic weights * List and show revisions * az containerapp revision restart, activate, deactivate * Add ability for users to clear args/command in az containerapp update * Various fixes, traffic weights fixes * Verify subnet subscription is registered to Microsoft.ContainerServices * GitHub Actions Update (Azure#17) * Added models. Finished transferring Calvin's previous work. * Updated wrong models. * Updated models in custom.py, added githubactionclient. * Updated envelope to be correct. * Small bug fixes. * Updated error handling. Fixed bugs. Initial working state. * Added better error handling. * Added error messages for tokens with inappropriate access rights. * Added back get_acr_cred. * Fixed problems from merge conflict. * Updated names of imports from ._models.py to fix pylance erros. * Removed random imports. Co-authored-by: Haroon Feisal <[email protected]> * Remove --location since location must be same as managed env * Add options for flag names: --env-vars and --registry-srever * Empty string to clear env_vars * Default revisions_mode to single * Infer acr credentials if it is acr and credentials are not provided * fix help msg * if image is hosted on acr, and no registry server is supplied, infer the registry server * Added subgroups (Ingress, Registry, Secret) and updated revisions (Azure#18) * Added ingress subgroup. * Added help for ingress. * Fixed ingress traffic help. * Added registry commands. * Updated registry remove util to clear secrets if none remaining. Added warning when updating existing registry. Added registry help. * Changed registry delete to remove. * Added error message if user tries to remove non assigned registry. * Changed registry add back to registry set. * Added secret subgroup commands. * Removed yaml support from secret set. * Changed secret add to secret set. Updated consistency between secret set and secret delete. Added secret help. Require at least one secret passed with --secrets for secret commands. * Changed param name for secret delete from --secrets to --secret-names. Updated help. * Changed registry remove to registry delete. * Fixed bug in registry delete. * Added revision mode set and revision copy. * Modified update_containerapp_yaml to support updating from non-current revision. Authored-by: Haroon Feisal <[email protected]> * More p0 fixes (Azure#20) * Remove --registry-login-server, only allow --registry-server * Rename --environment-variables to --env-vars * If no image is supplied, use default quickstart image * Update help text (Azure#21) * Update help text * Update punctuation * master -> main * New 1.0.1 version * Added identity commands + --assign-identity flag to containerapp create (#8) * Added identity show and assign. * Finisheed identity remove. * Added helps, updated identity remove to work with identity names instead of requiring identity resource ids. * Moved helper function to utils. * Require --identities flag when removing identities. * Added message for assign identity with no specified identity. * Added --assign-identity flag to containerapp create. * Moved assign-identity flag to containerapp create. * Fixed small logic error on remove identities when passing duplicate identities. Added warnings for certain edge cases. * Updated param definition for identity assign --identity default. * Added identity examples in help. * Made sure secrets were not removed when assigning identities. Added tolerance for [system] passed with capital letters. * Fixed error from merge. Co-authored-by: Haroon Feisal <[email protected]> * Dapr Commands (Azure#23) * Added ingress subgroup. * Added help for ingress. * Fixed ingress traffic help. * Added registry commands. * Updated registry remove util to clear secrets if none remaining. Added warning when updating existing registry. Added registry help. * Changed registry delete to remove. * Added error message if user tries to remove non assigned registry. * Changed registry add back to registry set. * Added secret subgroup commands. * Removed yaml support from secret set. * Changed secret add to secret set. Updated consistency between secret set and secret delete. Added secret help. Require at least one secret passed with --secrets for secret commands. * Changed param name for secret delete from --secrets to --secret-names. Updated help. * Changed registry remove to registry delete. * Fixed bug in registry delete. * Added revision mode set and revision copy. * Added dapr enable and dapr disable. Need to test more. * Added list, show, set dapr component. Added dapr enable, disable. * Added delete dapr delete. * Added helps and param text. * Changed dapr delete to dapr remove to match with dapr set. * Commented out managed identity for whl file. * Uncommented. Co-authored-by: Haroon Feisal <[email protected]> * Rename --image-name to --container-name * Remove allowInsecure since it was messing with the api parsing * Fix for env var being empty string * Rename to --dapr-instrumentation-key, only infer ACR credentials if --registry-server is provided * Remove az containerapp scale * Fix delete containerapp errors * Remove ingress, dapr flags from az containerapp update/revision copy * Fix revision list -o table * Help text fix * Bump extension to 0.1.2 * Update managed identities and Dapr help text (Azure#25) * Update managed identities and Dapr help text * Update Dapr flags * Add secretref note * Env var options + various bug fixes (Azure#26) * Moved dapr arguments to env as a subgroup. * Added env variable options. * Changed revision mode set to revision set-mode. * Added env var options to revision copy. * Fixed revision copy bug related to env secret refs. * Changed registry and secret delete to remove. Added registry param helps. Removed replica from table output and added trafficWeight. * Updating warning text. * Updated warning text once more. * Made name optional for revision copy if from-revision flag is passed. Co-authored-by: Haroon Feisal <[email protected]> * Fixed style issues, various bug fixes (Azure#27) * Moved dapr arguments to env as a subgroup. * Added env variable options. * Changed revision mode set to revision set-mode. * Added env var options to revision copy. * Fixed revision copy bug related to env secret refs. * Changed registry and secret delete to remove. Added registry param helps. Removed replica from table output and added trafficWeight. * Updating warning text. * Updated warning text once more. * Made name optional for revision copy if from-revision flag is passed. * Fixed whitespace style issues. * Styled clients and utils to pass pylint. * Finished client.py pylint fixes. * Fixed pylint issues. * Fixed flake8 commands and custom. * Fixed flake issues in src. * Added license header to _sdk_models. * Added confirmation for containerapp delete. Co-authored-by: Haroon Feisal <[email protected]> * Update src/containerapp/azext_containerapp/tests/latest/test_containerapp_scenario.py Co-authored-by: Xing Zhou <[email protected]> * Specific Error Types + Bugfixes (Help, remove app-subnet-resource-id, removed env-var alias, added help text for --name) (Azure#28) * Moved dapr arguments to env as a subgroup. * Added env variable options. * Changed revision mode set to revision set-mode. * Added env var options to revision copy. * Fixed revision copy bug related to env secret refs. * Changed registry and secret delete to remove. Added registry param helps. Removed replica from table output and added trafficWeight. * Updating warning text. * Updated warning text once more. * Made name optional for revision copy if from-revision flag is passed. * Fixed whitespace style issues. * Styled clients and utils to pass pylint. * Finished client.py pylint fixes. * Fixed pylint issues. * Fixed flake8 commands and custom. * Fixed flake issues in src. * Added license header to _sdk_models. * Added confirmation for containerapp delete. * Update helps for identity, revision. Removed env-var alias for set-env-vars. Added name param help. * Removed app-subnet-resource-id. * Updated infrastructure subnet param help. * Check if containerapp resource exists before attempting to delete. * Added check before deleting managed env. * Changed error types to be more specific. * Removed check before deletion. Removed comments. Co-authored-by: Haroon Feisal <[email protected]> * Reset to 0.1.0 version, remove unneeded options-list * Update min cli core version * Fixed style issues. (Azure#30) Co-authored-by: Haroon Feisal <[email protected]> * Fix linter issues * Use custom-show-command * Removed --ids from revision, secret, registry list. * Add linter exclusions * Fix polling on delete containerapp * Fix error handling * Add Container App Service * Fix flake linter * Fix help text * Mark extension as preview * Add python 3.9 and 3.10 as supported * Remove registries and secrets from az containerapp update, in favor of registry and secret subgroup * Fix YAML not working * Move import to inside deserialize function * Ingress enable --transport default. Secret list returns empty array. Secret update prints message saying user needs to restart their apps. Added show-values flag to secret list. Fixed yaml datetime field issues, replaced x00 values that also came up during testing. * Fixed dapr in create. * Revert "Ingress enable --transport default. Secret list returns empty array. Secret update prints message saying user needs to restart their apps. Added show-values flag to secret list. Fixed yaml datetime field issues, replaced x00 values that also came up during testing." This reverts commit 51bc543. * Revert "Fixed dapr in create." This reverts commit 37030ad. * Ingress enable --transport default. Secret list returns empty array. Secret update prints message saying user needs to restart their apps. Added show-values flag to secret list. Fixed yaml datetime field issues, replaced x00 values that also came up during testing. * Skeleton code * az containerapp env show * List kube/managed environments * Create kube environment, wait doesn't work yet * Update containerapp stubs (check if it is supported now) * Containerapp env delete, polling not working yet * Added polling for create and delete * Use Microsoft.App RP for show, list, delete command * Create containerapp env using Microsoft.App RP * Add optional containerapp env create arguments * Remove old kube environment code, naming fixes * Containerapp create almost done * Done containerapp create, except for --yaml. Need to test * Containerapp show, list * Fix helptext * Containerapp delete * Containerapp update. Needs secrets api to be implemented, and testing * Add scale command * Various validations, small fixes * listSecrets API for updates, autogen log analytics for env * Use space delimiter for secrets and env variables * Verify sub is registered to Microsoft.ContainerRegistration if creating vnet enabled env, remove logs-type parameter * Containerapp create --yaml * Fix updating registry to do create or update * Fix containerapp update command. Add image-name parameter to support multi container updates. Fix updating registries, containers and secrets * started update with --yaml. Need to do create or update for when an attribute is a list of items * use space delimiter for startup_command and args, instead of comma delimiter * Traffic weights * List and show revisions * az containerapp revision restart, activate, deactivate * Add ability for users to clear args/command in az containerapp update * Various fixes, traffic weights fixes * Verify subnet subscription is registered to Microsoft.ContainerServices * GitHub Actions Update (Azure#17) * Added models. Finished transferring Calvin's previous work. * Updated wrong models. * Updated models in custom.py, added githubactionclient. * Updated envelope to be correct. * Small bug fixes. * Updated error handling. Fixed bugs. Initial working state. * Added better error handling. * Added error messages for tokens with inappropriate access rights. * Added back get_acr_cred. * Fixed problems from merge conflict. * Updated names of imports from ._models.py to fix pylance erros. * Removed random imports. Co-authored-by: Haroon Feisal <[email protected]> * Remove --location since location must be same as managed env * Add options for flag names: --env-vars and --registry-srever * Empty string to clear env_vars * Default revisions_mode to single * Infer acr credentials if it is acr and credentials are not provided * fix help msg * if image is hosted on acr, and no registry server is supplied, infer the registry server * Added subgroups (Ingress, Registry, Secret) and updated revisions (Azure#18) * Added ingress subgroup. * Added help for ingress. * Fixed ingress traffic help. * Added registry commands. * Updated registry remove util to clear secrets if none remaining. Added warning when updating existing registry. Added registry help. * Changed registry delete to remove. * Added error message if user tries to remove non assigned registry. * Changed registry add back to registry set. * Added secret subgroup commands. * Removed yaml support from secret set. * Changed secret add to secret set. Updated consistency between secret set and secret delete. Added secret help. Require at least one secret passed with --secrets for secret commands. * Changed param name for secret delete from --secrets to --secret-names. Updated help. * Changed registry remove to registry delete. * Fixed bug in registry delete. * Added revision mode set and revision copy. * Modified update_containerapp_yaml to support updating from non-current revision. Authored-by: Haroon Feisal <[email protected]> * More p0 fixes (Azure#20) * Remove --registry-login-server, only allow --registry-server * Rename --environment-variables to --env-vars * If no image is supplied, use default quickstart image * Update help text (Azure#21) * Update help text * Update punctuation * master -> main * New 1.0.1 version * Added identity commands + --assign-identity flag to containerapp create (#8) * Added identity show and assign. * Finisheed identity remove. * Added helps, updated identity remove to work with identity names instead of requiring identity resource ids. * Moved helper function to utils. * Require --identities flag when removing identities. * Added message for assign identity with no specified identity. * Added --assign-identity flag to containerapp create. * Moved assign-identity flag to containerapp create. * Fixed small logic error on remove identities when passing duplicate identities. Added warnings for certain edge cases. * Updated param definition for identity assign --identity default. * Added identity examples in help. * Made sure secrets were not removed when assigning identities. Added tolerance for [system] passed with capital letters. * Fixed error from merge. Co-authored-by: Haroon Feisal <[email protected]> * Dapr Commands (Azure#23) * Added ingress subgroup. * Added help for ingress. * Fixed ingress traffic help. * Added registry commands. * Updated registry remove util to clear secrets if none remaining. Added warning when updating existing registry. Added registry help. * Changed registry delete to remove. * Added error message if user tries to remove non assigned registry. * Changed registry add back to registry set. * Added secret subgroup commands. * Removed yaml support from secret set. * Changed secret add to secret set. Updated consistency between secret set and secret delete. Added secret help. Require at least one secret passed with --secrets for secret commands. * Changed param name for secret delete from --secrets to --secret-names. Updated help. * Changed registry remove to registry delete. * Fixed bug in registry delete. * Added revision mode set and revision copy. * Added dapr enable and dapr disable. Need to test more. * Added list, show, set dapr component. Added dapr enable, disable. * Added delete dapr delete. * Added helps and param text. * Changed dapr delete to dapr remove to match with dapr set. * Commented out managed identity for whl file. * Uncommented. Co-authored-by: Haroon Feisal <[email protected]> * Rename --image-name to --container-name * Remove allowInsecure since it was messing with the api parsing * Fix for env var being empty string * Rename to --dapr-instrumentation-key, only infer ACR credentials if --registry-server is provided * Remove az containerapp scale * Fix delete containerapp errors * Remove ingress, dapr flags from az containerapp update/revision copy * Fix revision list -o table * Help text fix * Bump extension to 0.1.2 * Update managed identities and Dapr help text (Azure#25) * Update managed identities and Dapr help text * Update Dapr flags * Add secretref note * Env var options + various bug fixes (Azure#26) * Moved dapr arguments to env as a subgroup. * Added env variable options. * Changed revision mode set to revision set-mode. * Added env var options to revision copy. * Fixed revision copy bug related to env secret refs. * Changed registry and secret delete to remove. Added registry param helps. Removed replica from table output and added trafficWeight. * Updating warning text. * Updated warning text once more. * Made name optional for revision copy if from-revision flag is passed. Co-authored-by: Haroon Feisal <[email protected]> * Fixed style issues, various bug fixes (Azure#27) * Moved dapr arguments to env as a subgroup. * Added env variable options. * Changed revision mode set to revision set-mode. * Added env var options to revision copy. * Fixed revision copy bug related to env secret refs. * Changed registry and secret delete to remove. Added registry param helps. Removed replica from table output and added trafficWeight. * Updating warning text. * Updated warning text once more. * Made name optional for revision copy if from-revision flag is passed. * Fixed whitespace style issues. * Styled clients and utils to pass pylint. * Finished client.py pylint fixes. * Fixed pylint issues. * Fixed flake8 commands and custom. * Fixed flake issues in src. * Added license header to _sdk_models. * Added confirmation for containerapp delete. Co-authored-by: Haroon Feisal <[email protected]> * Update src/containerapp/azext_containerapp/tests/latest/test_containerapp_scenario.py Co-authored-by: Xing Zhou <[email protected]> * Specific Error Types + Bugfixes (Help, remove app-subnet-resource-id, removed env-var alias, added help text for --name) (Azure#28) * Moved dapr arguments to env as a subgroup. * Added env variable options. * Changed revision mode set to revision set-mode. * Added env var options to revision copy. * Fixed revision copy bug related to env secret refs. * Changed registry and secret delete to remove. Added registry param helps. Removed replica from table output and added trafficWeight. * Updating warning text. * Updated warning text once more. * Made name optional for revision copy if from-revision flag is passed. * Fixed whitespace style issues. * Styled clients and utils to pass pylint. * Finished client.py pylint fixes. * Fixed pylint issues. * Fixed flake8 commands and custom. * Fixed flake issues in src. * Added license header to _sdk_models. * Added confirmation for containerapp delete. * Update helps for identity, revision. Removed env-var alias for set-env-vars. Added name param help. * Removed app-subnet-resource-id. * Updated infrastructure subnet param help. * Check if containerapp resource exists before attempting to delete. * Added check before deleting managed env. * Changed error types to be more specific. * Removed check before deletion. Removed comments. Co-authored-by: Haroon Feisal <[email protected]> * Reset to 0.1.0 version, remove unneeded options-list * Update min cli core version * Fixed style issues. (Azure#30) Co-authored-by: Haroon Feisal <[email protected]> * Fix linter issues * Use custom-show-command * Removed --ids from revision, secret, registry list. * Add linter exclusions * Fix polling on delete containerapp * Fix error handling * Add Container App Service * Fix flake linter * Fix help text * Mark extension as preview * Add python 3.9 and 3.10 as supported * Remove registries and secrets from az containerapp update, in favor of registry and secret subgroup * Fix YAML not working * Move import to inside deserialize function * Dapr moved from Template to Configuration * Use aka.ms link for containerapps yaml * Updated dapr enable/disable to current spec. * Fixed oversight. * Remove revisions-mode from containerapp update * Fixed dapr enable property names. (Azure#47) Co-authored-by: Haroon Feisal <[email protected]> * Fix exceptions with using --yaml in containerapp create/update * Rename history msg * Include fqdn in containerapp table output * Added ingress messages. * Revert history msg * Reduced redundant code between revision copy and containerapp update. * Fixed merge issues. * Fixed merge conflicts, moved helper function Co-authored-by: Calvin Chan <[email protected]> Co-authored-by: Haroon Feisal <[email protected]> Co-authored-by: Anthony Chu <[email protected]> Co-authored-by: Xing Zhou <[email protected]> * Fix help for linter * various fixes, helptext (Azure#59) * Fixes (Azure#60) * Updated managed identity + help. (Azure#61) Co-authored-by: Haroon Feisal <[email protected]> * Added user-assigned and system-assigned to containerapp create. (Azure#62) Co-authored-by: Haroon Feisal <[email protected]> * Bump version to 0.1.1 (Azure#63) * Added more specific MSI help text. (Azure#64) * Added more specific MSI help text. * Updated help text. Co-authored-by: Haroon Feisal <[email protected]> * Bump to 0.3.0 (Azure#65) * Container App Test suite (Azure#67) * Add tests for containerapp create * All tests under the same function to share environment - need to figure how to get multiple functions to share environment * Basic tests * use new GH actions API * remove live only recordings * update CODEOWNERS * fix API version naming * Managed Identity Tests (Azure#69) * Added managed identity tests. * Fixed msi tests. Co-authored-by: Haroon Feisal <[email protected]> * resolve review comments * Managed Identity Fixes (Azure#71) * Added managed identity tests. * Fixed msi tests. * Added live_only to managed identity tests. * Changed region to eastus2 from canary. Co-authored-by: Haroon Feisal <[email protected]> * Update src/containerapp/azext_containerapp/_params.py Co-authored-by: Xing Zhou <[email protected]> * 4/26 release: Up with --repo/--browse, exec (ssh) command, replica commands, log streaming commands (Azure#72) * Skeleton code * az containerapp env show * List kube/managed environments * Create kube environment, wait doesn't work yet * Update containerapp stubs (check if it is supported now) * Containerapp env delete, polling not working yet * Added polling for create and delete * Use Microsoft.App RP for show, list, delete command * Create containerapp env using Microsoft.App RP * Add optional containerapp env create arguments * Remove old kube environment code, naming fixes * Containerapp create almost done * Done containerapp create, except for --yaml. Need to test * Containerapp show, list * Fix helptext * Containerapp delete * Containerapp update. Needs secrets api to be implemented, and testing * Add scale command * Various validations, small fixes * listSecrets API for updates, autogen log analytics for env * Use space delimiter for secrets and env variables * Verify sub is registered to Microsoft.ContainerRegistration if creating vnet enabled env, remove logs-type parameter * Containerapp create --yaml * Fix updating registry to do create or update * Fix containerapp update command. Add image-name parameter to support multi container updates. Fix updating registries, containers and secrets * started update with --yaml. Need to do create or update for when an attribute is a list of items * use space delimiter for startup_command and args, instead of comma delimiter * Traffic weights * List and show revisions * az containerapp revision restart, activate, deactivate * Add ability for users to clear args/command in az containerapp update * Various fixes, traffic weights fixes * Verify subnet subscription is registered to Microsoft.ContainerServices * GitHub Actions Update (Azure#17) * Added models. Finished transferring Calvin's previous work. * Updated wrong models. * Updated models in custom.py, added githubactionclient. * Updated envelope to be correct. * Small bug fixes. * Updated error handling. Fixed bugs. Initial working state. * Added better error handling. * Added error messages for tokens with inappropriate access rights. * Added back get_acr_cred. * Fixed problems from merge conflict. * Updated names of imports from ._models.py to fix pylance erros. * Removed random imports. Co-authored-by: Haroon Feisal <[email protected]> * Remove --location since location must be same as managed env * Add options for flag names: --env-vars and --registry-srever * Empty string to clear env_vars * Default revisions_mode to single * Infer acr credentials if it is acr and credentials are not provided * fix help msg * if image is hosted on acr, and no registry server is supplied, infer the registry server * Added subgroups (Ingress, Registry, Secret) and updated revisions (Azure#18) * Added ingress subgroup. * Added help for ingress. * Fixed ingress traffic help. * Added registry commands. * Updated registry remove util to clear secrets if none remaining. Added warning when updating existing registry. Added registry help. * Changed registry delete to remove. * Added error message if user tries to remove non assigned registry. * Changed registry add back to registry set. * Added secret subgroup commands. * Removed yaml support from secret set. * Changed secret add to secret set. Updated consistency between secret set and secret delete. Added secret help. Require at least one secret passed with --secrets for secret commands. * Changed param name for secret delete from --secrets to --secret-names. Updated help. * Changed registry remove to registry delete. * Fixed bug in registry delete. * Added revision mode set and revision copy. * Modified update_containerapp_yaml to support updating from non-current revision. Authored-by: Haroon Feisal <[email protected]> * More p0 fixes (Azure#20) * Remove --registry-login-server, only allow --registry-server * Rename --environment-variables to --env-vars * If no image is supplied, use default quickstart image * Update help text (Azure#21) * Update help text * Update punctuation * master -> main * New 1.0.1 version * Added identity commands + --assign-identity flag to containerapp create (#8) * Added identity show and assign. * Finisheed identity remove. * Added helps, updated identity remove to work with identity names instead of requiring identity resource ids. * Moved helper function to utils. * Require --identities flag when removing identities. * Added message for assign identity with no specified identity. * Added --assign-identity flag to containerapp create. * Moved assign-identity flag to containerapp create. * Fixed small logic error on remove identities when passing duplicate identities. Added warnings for certain edge cases. * Updated param definition for identity assign --identity default. * Added identity examples in help. * Made sure secrets were not removed when assigning identities. Added tolerance for [system] passed with capital letters. * Fixed error from merge. Co-authored-by: Haroon Feisal <[email protected]> * Dapr Commands (Azure#23) * Added ingress subgroup. * Added help for ingress. * Fixed ingress traffic help. * Added registry commands. * Updated registry remove util to clear secrets if none remaining. Added warning when updating existing registry. Added registry help. * Changed registry delete to remove. * Added error message if user tries to remove non assigned registry. * Changed registry add back to registry set. * Added secret subgroup commands. * Removed yaml support from secret set. * Changed secret add to secret set. Updated consistency between secret set and secret delete. Added secret help. Require at least one secret passed with --secrets for secret commands. * Changed param name for secret delete from --secrets to --secret-names. Updated help. * Changed registry remove to registry delete. * Fixed bug in registry delete. * Added revision mode set and revision copy. * Added dapr enable and dapr disable. Need to test more. * Added list, show, set dapr component. Added dapr enable, disable. * Added delete dapr delete. * Added helps and param text. * Changed dapr delete to dapr remove to match with dapr set. * Commented out managed identity for whl file. * Uncommented. Co-authored-by: Haroon Feisal <[email protected]> * Rename --image-name to --container-name * Remove allowInsecure since it was messing with the api parsing * Fix for env var being empty string * Rename to --dapr-instrumentation-key, only infer ACR credentials if --registry-server is provided * Remove az containerapp scale * Fix delete containerapp errors * Remove ingress, dapr flags from az containerapp update/revision copy * Fix revision list -o table * Help text fix * Bump extension to 0.1.2 * Update managed identities and Dapr help text (Azure#25) * Update managed identities and Dapr help text * Update Dapr flags * Add secretref note * Env var options + various bug fixes (Azure#26) * Moved dapr arguments to env as a subgroup. * Added env variable options. * Changed revision mode set to revision set-mode. * Added env var options to revision copy. * Fixed revision copy bug related to env secret refs. * Changed registry and secret delete to remove. Added registry param helps. Removed replica from table output and added trafficWeight. * Updating warning text. * Updated warning text once more. * Made name optional for revision copy if from-revision flag is passed. Co-authored-by: Haroon Feisal <[email protected]> * Fixed style issues, various bug fixes (Azure#27) * Moved dapr arguments to env as a subgroup. * Added env variable options. * Changed revision mode set to revision set-mode. * Added env var options to revision copy. * Fixed revision copy bug related to env secret refs. * Changed registry and secret delete to remove. Added registry param helps. Removed replica from table output and added trafficWeight. * Updating warning text. * Updated warning text once more. * Made name optional for revision copy if from-revision flag is passed. * Fixed whitespace style issues. * Styled clients and utils to pass pylint. * Finished client.py pylint fixes. * Fixed pylint issues. * Fixed flake8 commands and custom. * Fixed flake issues in src. * Added license header to _sdk_models. * Added confirmation for containerapp delete. Co-authored-by: Haroon Feisal <[email protected]> * Update src/containerapp/azext_containerapp/tests/latest/test_containerapp_scenario.py Co-authored-by: Xing Zhou <[email protected]> * Specific Error Types + Bugfixes (Help, remove app-subnet-resource-id, removed env-var alias, added help text for --name) (Azure#28) * Moved dapr arguments to env as a subgroup. * Added env variable options. * Changed revision mode set to revision set-mode. * Added env var options to revision copy. * Fixed revision copy bug related to env secret refs. * Changed registry and secret delete to remove. Added registry param helps. Removed replica from table output and added trafficWeight. * Updating warning text. * Updated warning text once more. * Made name optional for revision copy if from-revision flag is passed. * Fixed whitespace style issues. * Styled clients and utils to pass pylint. * Finished client.py pylint fixes. * Fixed pylint issues. * Fixed flake8 commands and custom. * Fixed flake issues in src. * Added license header to _sdk_models. * Added confirmation for containerapp delete. * Update helps for identity, revision. Removed env-var alias for set-env-vars. Added name param help. * Removed app-subnet-resource-id. * Updated infrastructure subnet param help. * Check if containerapp resource exists before attempting to delete. * Added check before deleting managed env. * Changed error types to be more specific. * Removed check before deletion. Removed comments. Co-authored-by: Haroon Feisal <[email protected]> * Reset to 0.1.0 version, remove unneeded options-list * Update min cli core version * Fixed style issues. (Azure#30) Co-authored-by: Haroon Feisal <[email protected]> * Fix linter issues * Use custom-show-command * Removed --ids from revision, secret, registry list. * Add linter exclusions * Fix polling on delete containerapp * Fix error handling * Add Container App Service * Fix flake linter * Fix help text * Mark extension as preview * Add python 3.9 and 3.10 as supported * Remove registries and secrets from az containerapp update, in favor of registry and secret subgroup * Fix YAML not working * Move import to inside deserialize function * Dapr moved from Template to Configuration * Use aka.ms link for containerapps yaml * Updated dapr enable/disable to current spec. * Fixed oversight. * Remove revisions-mode from containerapp update * Fixed dapr enable property names. (Azure#47) Co-authored-by: Haroon Feisal <[email protected]> * Fix exceptions with using --yaml in containerapp create/update * Rename history msg * Include fqdn in containerapp table output * Added ingress messages. * Revert history msg * Add basic test case * Remove managed-identity support for first release of CLI * Need to investigate test flakiness * Update _help.py removing duplicate help * Added prototype of container up. * Fixed deploy from acr registry image infer credentials issue. * Tried to add source. * Added acr build. * Finished acr build functionality. * Added acr create functionality and pull registry from existing containerapp if it exists. * Fixed bugs. * Check if rg exists and create one with name if it doesn't. * initial containerapp ssh implementation * fix interactive commands (vim); handle ctrl + c instead of exiting * fix style and linter issues * Added disable verbose. Moved utils into utils.py. * fix for ssh for windows clients * fix for unix * Disable verbose now uses sdk poller so it gives running animation. * Added helps for params. Added error handling for non acr registry passed with source. Ignore param disable_warnings for create and no_wait for up. * Updated disable_warnings ignore. Removed disable_warnings from update_containerapp. * add terminal resizing * reorganize code; implement terminal resizing, add startup command param, etc * organize code, remove token from warning output * add validations, add replica commands * use the correct API for fetching default container; remove is_preview * Renamed silent to quiet. * Fixed style issues. * add log streaming, bump version number and add to HISTORY.rst * add basic ssh test * Added workspace name and fqdn to dry_run_str. Added indicators of if the resources are new or existing to dry_run_str. * fix ssh test for windows * Check RP for location when not provided. Open Dockerfile and use EXPOSE for CA port. * fix windows arrow keys after exit * fix typo, add logstream test, remove token from logstream output * Removed print statement. * Updated dockerfile expose automatic ingress feature. * Removed dry run str, added dry run obj instead. * use bearer auth; fix --command bug * add handling for smooth transition to new URL path * Fixed merge conflict. * fix merge conflicts * Create env if name passed and it doesn't exist. * Added missing import from merge. * Added prototype for new environment workflow. * Finished environment logic. * Minor updates before demo. * add 'az containerapp github up' (wip) * various fixes for demo * rearrange github up code * merge haroonf/containerappup * start up refactor * add --repo to up and refactor up * reorganize code more; fix various bugs * fix linter issues, fix lingering exec/tail improvements * update history * update output * bug fixes for --repo * fix --source bug * fix --source * minor bug fixes * Added API change. * Finished API change, added helloworld image auto ingress, checked provisioning state beforehand. * fixes for sisira's comments * fix minor typo * bug fix where commands fail if providing registry creds * Fixed style issues. * Updated help and version text. Co-authored-by: Calvin Chan <[email protected]> Co-authored-by: Haroon Feisal <[email protected]> Co-authored-by: Haroon Feisal <[email protected]> Co-authored-by: Anthony Chu <[email protected]> Co-authored-by: Xing Zhou <[email protected]> Co-authored-by: Sisira Panchagnula <[email protected]> * Fixed small issue with test. * Removed flake exclusions and removed type=str from params. * Fixed repo bug when searching for dockerfile, increased timeout on github action complete, fixed datetime import issue from style fix. * Added env var changes. * Assume port if ingress is provided with image and port is not. * Fixed small helloworld error. * Fixed logger typo. * Search for acr before creating one. * Fixed bug where only --environment is passed. Changed hash on acr name to make it more unique. Tiny change in find_existing_acr. * error out if dockerfile not found (--repo) * Fixed bug with --image. Changed logger warning output. Disabled warnings on the registry update code for containerapp up. Added HELLOWORLD constant. * Disabled no_wait. Added better error handling for up API calls. Updated ingress infer warning text. Fixed typo. Moved create_if_needed to environment. * fix ACR length cap; enforce name/secret limits; trigger GH action if needed (update with GH actions already extant); fail command if GH action ends in failure * force exact match for ACR retrieval (prevents secrets issues for --repo) * fix hashing and add GH validations * don't retrieve a registry if one provided; take RG from env if possible * Fixed --registry-server with --image bug. (Azure#78) * Fixed --registry-server with --image bug. * Fixed style issues. Co-authored-by: Haroon Feisal <[email protected]> * use SP creds if provided * fix github actions (less polling) * Added prototype for env check. * Honor location and environment passed to create new containerapp (even if a CA exists on subscription with the same name) (Azure#79) * Create new Containerapp if user passes env name even if a CA exists with the same name. * Create a new app if location doesn't match any other app. * Fixed small bug, added better error handling for multiple environments with the same name on subscription. Co-authored-by: Haroon Feisal <[email protected]> * print created SP name/id; prevent using ACR names longer than 20 chars with --repo; add basic --image test * fix style; add license header * Finished core logic. * add max core cli version 2.36.0 * make ACR name more unique (must be globally unique) * Finished logic. * sort workflows by date before selecting one * log workflow * Added error message with eligible locations if users pass uneligible location. * Added function to check if env already exists so we don't try to update the location value of an existing environment. * Added error handling for location northcentralusstage. Added list of eligible locations to unallowed location error message. * Small fixes, implemented check_env_name_on_rg. * location bug fix * fix style * bump version number * Updates to tests (Azure#82) * Updates to update tests * Update api version for create * Remove recordings (Azure#83) * prevent using --only-show-errors, --output, -o in up * Added FileShare commands. (Azure#84) * Added FileShare commands. * Updated params to match spec. Added param help. * Added help. Removed --ids support. * Removed automatic import statements. * Added back type in help. * Added tests. * Updated param names to better reflect AzureFile dependency. * Added validation to ensure share name and account name are longer than 2 characters. Seems to be an API issue. * Added warning message if user is updating existing storage. Co-authored-by: Haroon Feisal <[email protected]> * Fixed bug. (Azure#86) Co-authored-by: Haroon Feisal <[email protected]> * register log analytics resource provider if not registered when creating an env with up * fix style * Fixed linter issue. * fix linter issues * update history file * Moved constant to constants.py. * add timeout to container app ping for ssh/logstream * Various tests (Ingress, Traffic, Dapr, Env) (Azure#87) * Added env tests. * Added ingress tests. * Added ingress traffic tests. * Fixed small issue. * Added remove test for dapr components. * Removed live_only from containerapp commands. Added recordings. * Removed live_only from env commands. * Removed sleep 60 since we use poll for delete anyways. * Wrote better dapr-component tests. Fixed old tests that required live only. Co-authored-by: Haroon Feisal <[email protected]> * Revert "Various tests (Ingress, Traffic, Dapr, Env) (Azure#87)" (Azure#88) This reverts commit 40ca5b9. * Reverted fileshare. (Azure#90) Co-authored-by: Haroon Feisal <[email protected]> * Tests (dapr-components, env, ingress, traffic) (Azure#89) * Added env tests. * Added ingress tests. * Added ingress traffic tests. * Fixed small issue. * Added remove test for dapr components. * Removed live_only from containerapp commands. Added recordings. * Removed live_only from env commands. * Removed sleep 60 since we use poll for delete anyways. * Wrote better dapr-component tests. Fixed old tests that required live only. * Added suppression for log analytics dummy secrets. * Rerecorded tests. * rerecord failing tests * Updated credscan. Co-authored-by: Haroon Feisal <[email protected]> Co-authored-by: Silas Strawn <[email protected]> * adding certs cmd & test * adding hostname cmds & test * changes based on comments * changes based on comments Co-authored-by: Haroon Feisal <[email protected]> Co-authored-by: Calvin Chan <[email protected]> Co-authored-by: Haroon Feisal <[email protected]> Co-authored-by: Anthony Chu <[email protected]> Co-authored-by: Xing Zhou <[email protected]> Co-authored-by: Silas Strawn <[email protected]> Co-authored-by: Sisira Panchagnula <[email protected]>
yanzhudd
pushed a commit
that referenced
this issue
Oct 24, 2023
* removed deploy with sdk * added artifact list * push example cnf bicep * Add temporary build workflow for AOSM extension (#4) * Add temporary build workflow for AOSM extension * Add Releaser to maintain a release with the latest build in a consistent place * added output dir; fixing getchartmappingschema * Add empty init files to inner modules so setuptools recognises them as modules * Use latest RG model to remove unnecessary dependency on version * Use latest deployment model to remove unnecessary dependency on version * fixed parameter mappings + copied needed files to output folder * jinja2 and find value paths * fixed typos + self.aritfacts only has unique artifacts * use regex instead of string to find deploy params * delete accidentaly commited input.json * fixed deploy params; added indent to mapping file * Update readme with install/bug reporting instructions * Adjust headers so rendered readme looks nicer * renamed values.nondef + added cli errors * Split help command example lines * Clarify that bug process is internal * fixed parameter vals not updating * delete unuseed temoplate and update jinja2 templates * Update README.md * Update README.md * added docstrings; added basic error catching with file handling * small refactor of generate nfd * fixed j2 template captions; added create_nfd to cnf; edited error messages; added deleting existing folder to custom.py * fixed file not found erroe * Refactor commands to az aosm nfd|nsd build (#10) * Refactor commands to az aosm nfd|nsd build * setup.py version * Version was wrong * remove publish option from build * lint * wrong params * fixed most style errors; ran static checks and azdev style * pre merge commit * more style changes; renamed vnfbicepnfd to vnfnfd * Update readme with workflow * added configfile validation * added temp dir to vnf; renamed shared constants * sunny markups * removed create_nfd_folder; added schema prefix to constant * added deploymentparams to constants.py * added error catching for get chart name and version * added meaningful logs; prevent auto overwriting input.json * edited vnf schema to have accepted types * added templates to setup.py * added location from input file not resourceGroup().location * added path_to_mappings to input.json; added logic to take mappings from file outside of helm package * renamed non_def_values to mappings_path * Pk5/add nsd cli (#15) * First working version of the CLI NSD create * Fully working version of the NSD CLI * minor change to nsd_generate * Sunny's refactor * First round of cleanup * Secound Round of cleanup * fix the 2023 api NSDV * description updates * deleted comment * Fix SNS creation * Fix SNS creation try 2 * markups * delete unnecessary file * Testing markups * Fix the SNS attempt 3 * minor fixes * Fix config validation * fix CNF depends on * initial commit; ran python static checks fmt (except on vendored sdks), fixed styling on _configuration.py * Name uploaded VHD correctly * Self review markups * broken config generation code * fixed up configuration.py * fixed cnf generator styling * fixed styling for cnf generator * fixed up nfd generator base and deploy with arm * fixed styling for artifact.py * fixed styling for atrifact manifest .py * Code review markups * fixed more linting * first attempt at regex * Sunny/choose deploy parameters (#23) * choose-deploy-parameters * optioned deployParameters for CNF * lint * lint2 * docs * docs * lint * 9.82 score * Fix bugs * more useful debug logs * Fix bugs and logging * lint * markups * Fix for oras target string with erroneous spaces * fixed regex; tested on existing charts and sas charts; committing to not lose prints for testing * changed regex constants + tidied * fixed blankspace * markups * initial commit * tidied code and added comments * add multi nf config * Add style and lint check * added logic for handling deployparams within lists * one line fix from review * removing print statement * added new test file and one unit test * added workflow for unit tests in pipeline + set up rough structure of unit testing * instantiated cnf class; added fake invalid helm package; added new files to use for testing * Nsd for cnfs (#33) * NSD building for CNFs * linting * Add Publish command to the CNF azure CLI (#24) * Working publish * Fix the artifact upload * Working image copy * minor fix * Minor fixes * sunny merge add-aosm-extension into patryk's branch (#25) * Sunny/choose deploy parameters (#23) * choose-deploy-parameters * optioned deployParameters for CNF * lint * lint2 * docs * docs * lint * 9.82 score * Fix bugs * more useful debug logs * Fix bugs and logging * lint * markups * comment out breaking line * minor TODOs * deleted comment * fix bring your own parameters * Markups * Fix the helm upload * Minor markups * Change error message --------- Co-authored-by: sunnycarter <[email protected]> Co-authored-by: Sunny Carter <[email protected]> * Expose NFD version and managed identities (#34) * NFDV version exposed as a CGV on an SNS * Managed identities support on NFs * Fix identiy, fix API versions * history --------- Co-authored-by: Jamie Parsons <[email protected]> Co-authored-by: Sunny Carter <[email protected]> * Add a first VNF test * achurchard/style fixes (#35) Fix style issues raised by `azdev style` * Add CNF UTs that will fail at the moment * Actually include all files. * Always run tests * Add another test that won't pass yet * remove github pipeline tests - they should run in Azure * Sundry fixes for CNF quickstart (#38) * Sundry fixes for CNF quickstart * merge add-aosm-ext in (#37) * markups * NSD UTs * Update read me. * Improve path handling, other small refactorings (#39) # Main changes ## Make methods relying on self._tmp_dir private - `self._tmp_dir` is only available in the context of calling `generate_nfd()`, so methods relying on `self._tmp_dir` should be private ## Use pathlib.Path rather than os file operations - Provides clearer and stronger typing than passing `str`s around - Adds some handy utility functions ## Variable renaming for clarity - E.g. consistently use 'directory' / 'dir' (rather than mix with 'folder') - Obvs somewhat subjective, but as someone new to most of this code, the changes made sense to me ## Add nfd_bicep_path as abstract property on NFDGenerator - We rely on it when calling the concrete implementations - Also use ABC rather than raise NotImplementedError ## Miscellaneous style updates to keep `azdev style aosm` happy - isort - black * Fix Artifact upload on Windows (#40) * Black * Mark ups * Sunny/fix artifact upload windows (#41) * Fix Artifact upload on Windows * mypy fixups * mypy fixes * linting * mypy * mypy for _configuration.py * mypy for vnf_nfd_generator.py * mypy appeasement * python-static-checks fmt * az style happy * lint * mypy cnf_nfd_generator * copyright * more lint * Remove windows oras workaround now 0.0.18 oras out * history --------- Co-authored-by: Jamie Parsons <[email protected]> * Fix VNFD build (#42) * Multiple instances of the same NF * fix vnf deploy schema types (#44) * Tidy up * Mypy and docs * history.rst * Update README with logging info (#43) * Update README with logging info * Update docs * self markups * Take oras 0.1.19 to fix Windows artifact upload (#46) * Rename a few things * DRY the deploy_nfd_from_bicep code * Make conditional statements clearer * black * Update custom.py to use new nfd deploy method * Black with text processing * Create new nfRET class * Mypy passing * UTs passing * Dry the deploy_nfd_from_bicep() code (#48) - Removed duplicated code in the deploy_vnfd_from_bicep() and deploy_cnfd_from_bicep() methods - Moved variables onto the class instance and stopped passing them around in the method signatures - Also made the deployer class a dataclass for cleaner __init__ - Made parameters a property of the class, and moved the logic for getting/generating them into that property method - Improved the typing - Included adding enums for SkipSteps and DeployableResourceTypes - Added the new skip step logic for image uploads - Added a new skip step type of IMAGE_UPLOAD Testing: - No MyPy errors - Live tests for VNFS+NSD, CNFs, including all --skip options * Unit tests added * Versions are wrong in NSD template comments * Self review markups * Remove wrong comments * Code review markups * Extra markups * Fix mypy * Pk5/add integration tests (#51) * Somewhat working example * Cleanups * Update recording * fix minor linting error * More markups * Update output in tests * Pk5/minor integration tests changes (#52) * Modify changelog and rename tests * Delete recording file * Update recordings * Update developer docs * Remove credentials * Fix linting * cheeky extra change * Remove credentials from the integration test recordings (#54) * Modify changelog and rename tests * Delete recording file * Fix the credentials issue in the integration tests * Update CHANGELOG * Markups * Fix typo * Minor markups * Make cleaning up resources more robust and remove the VHD external reference * Markups * Remove the integration test from the repo (#56) * prerequisite docker for cnf * Fix bicep render on Windows (#57) * Fixes for Windows (#58) * Fix bicep render on Windows * Fixes for Windows * python-static-checks ran * ADO-880627: Use docker-less ACR login For running in environments without docker, such as CI pipelines. This affects uploading Helm charts for CNFs - the ACR login now fetches an access token, which is used to login to the Helm registry and upload the chart. * docker is not required any more * Remove pre-release build and lint files from release branch (#63) * Release markups - release branch (#65) * Markups from release comments * history * markups and fixes * README changes * linting fixes * Fix integration tests (#67) * Fix integration tests * Update src/aosm/development.md Co-authored-by: Cyclam <[email protected]> * Update src/aosm/azext_aosm/tests/latest/test_aosm_cnf_publish_and_delete.py Co-authored-by: Cyclam <[email protected]> * Update src/aosm/azext_aosm/tests/latest/test_aosm_cnf_publish_and_delete.py Co-authored-by: Cyclam <[email protected]> * Markup changes --------- Co-authored-by: Cyclam <[email protected]> Co-authored-by: Sunny Carter <[email protected]> * Add aosm to service_name.json * move artifact upload to before nfd/nsd deploy (#62) * move artifact upload to before nfd/nsd deploy * markups * check in new test recording * non-working attempt to use token creds * Check for Azure features on deploy and delete (#71) * WIP: Check for features on deploy and delete * linting * Anand has confirmed names of flags * Update test recording as now has calls to Features API * Update src/aosm/azext_aosm/custom.py Co-authored-by: jamiedparsons <[email protected]> * docstring markups --------- Co-authored-by: jamiedparsons <[email protected]> * code working * Fix generate-config * Fix tests * lint * linting * Jl/nfdv proxy (#73) * added publisher scope to input file; changed to proxy nsdv * fixed get request on proxy nfdv (should be overwritten when autogenerated again) * small print bug fix --------- Co-authored-by: Jordan <[email protected]> * Code review mark ups * Linting and fix UTs * aosm codeowner * Update HISTORY.rst * Normalise aosm version to 1.0.0b1 for release * update hashes in recording * Temporary test revert of "aosm codeowner" This reverts commit 479ba54. * Fix license header formatting * Revert "Temporary test revert of "aosm codeowner"" This reverts commit 0e4d0e7. * Remove nonexistent entry from codeowners * Fix source_local_docker_image defaults to placeholder text (#79) * temp fix for bug * minor formatting * refactor + change validation ordering to mimic previous behaviour * add docstring --------- Co-authored-by: Jordan <[email protected]> * renamed nsdg to nsd * Helptext + a little bit of validation * Fixed up validation * Return True if _all_ required artifact manifests exist, not just the last one checked. * Code markups + linting. * Docs: CNF publish options and permissions (#91) * Requirement for docker again * revert bad markup (#94) * Move live tests to swedensouth * Actually move to uaenorth * Don't log out ACR passwords when artifact commands fail (#97) * Don't log out passwords when artifact commands fail * Don't log out passwords when artifact commands fail part 2 * Comment to explain dropping the original exception * Fix cnf image take 2 (#101) * Fix CNF image copy to work cross subscription * Cross subscription works for image copy. Still test same subscription * lint * Error message * oops, code paste error * markups * appease mypy * Default RG and ACR Values with Publisher Name (#103) * added default rg and acr values for nf + nsd; added blob_url default for vnf * added bug fix to close Paulo's bug * change error message back --------- Co-authored-by: Jordan <[email protected]> * Fix unauthorized error bug * Add spacing * fix unexpected symbol when parsing lists (#107) * Validation requirements on helm names (#109) * Validation requirements on helm names * lint * markups * lint * Fix error parsing * Lower case acr names (#112) * Lower case ACR names and fix interactive mode for lists * lint * remove duplicate else branch * always allow azureDeployLocation to be configurable * Add new optional VHD parameters * Make VNF publish and delete a live test only * Validate VHD parameters in build UT * Markups from the CLI team * mark-ups * remove azureDeployLocation as a configurable vhd parameter * add explanitory comments * Updates for 2023-09-01 API (#84) * Regen Python SDK from 2023-09-01 API - also uses latest AutoRest client - fix for HybridNetworkManagementClient init signature (swap order of subscription_id and credential parameters) * Update CLI extension code to use new SDK * added SAMI to publisher pre deploy * Update bicep templates to use 2023-09-01 * Update NF templates * Update metaschema * Add Allow-Publisher to required feature flags * Use secure objects for deployment parameters * Correctly get array item types in CNF deployment parameter schemas * Revert master .flake8 config * Fix double space in user output. Co-authored-by: Xing Zhou <[email protected]> * Remove delete message to be consistent with other CLI extensions * Move "Deleted <resource>" messages to logger.info(). * Remove Blob_SAS_URL Option from ArmTemplate in input file (#119) * moved blob url to vhd config only; untested * stopped error in post innit before validate * changed ordering of inputs so that blob and filepath are next to each other; helptext for filepath different for each option * Markups from sunny * appease mypy --------- Co-authored-by: Jordan <[email protected]> Co-authored-by: Sunny Carter <[email protected]> --------- Co-authored-by: Jordan <[email protected]> Co-authored-by: Jacob Darby <[email protected]> Co-authored-by: Chaos <[email protected]> Co-authored-by: Chaos Chhapi <[email protected]> Co-authored-by: jordlay <[email protected]> Co-authored-by: patrykkulik-microsoft <[email protected]> Co-authored-by: Jacob <[email protected]> Co-authored-by: Jamie Parsons <[email protected]> Co-authored-by: jamiedparsons <[email protected]> Co-authored-by: Andy Churchard <[email protected]> Co-authored-by: Cyclam <[email protected]> Co-authored-by: William Bradley <[email protected]> Co-authored-by: Xing Zhou <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
image-copy-extension
'NoneType' object is not subscriptable
Getting os disk id of the source vm/image
'NoneType' object is not subscriptable
Traceback (most recent call last):
File "/opt/az/lib/python3.6/site-packages/knack/cli.py", line 194, in invoke
cmd_result = self.invocation.execute(args)
File "/opt/az/lib/python3.6/site-packages/azure/cli/core/commands/init.py", line 342, in execute
six.reraise(*sys.exc_info())
File "/opt/az/lib/python3.6/site-packages/six.py", line 693, in reraise
raise value
File "/opt/az/lib/python3.6/site-packages/azure/cli/core/commands/init.py", line 315, in execute
result = cmd(params)
File "/opt/az/lib/python3.6/site-packages/azure/cli/core/commands/init.py", line 175, in call
return super(AzCliCommand, self).call(*args, **kwargs)
File "/opt/az/lib/python3.6/site-packages/knack/commands.py", line 109, in call
return self.handler(*args, **kwargs)
File "/opt/az/lib/python3.6/site-packages/azure/cli/core/init.py", line 349, in default_command_handler
result = op(**command_args)
File "/home/Wolfthorne/.azure/cliextensions/image-copy-extension/azext_imagecopy/custom.py", line 27, in imagecopy
source_os_disk_id = json_cmd_output['storageProfile']['osDisk']['managedDisk']['id']
TypeError: 'NoneType' object is not subscriptable
The text was updated successfully, but these errors were encountered: