Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: apic-extension 1.2.0b1 release #8411

Merged
merged 29 commits into from
Jan 17, 2025
Merged

Conversation

frankqianms
Copy link
Member

@frankqianms frankqianms commented Jan 13, 2025


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

blackchoey and others added 24 commits April 9, 2024 09:51
* build: Run CI in Python 3.8-3.11

* build: remove pull request event for CI to avoid duplicate runs
* feat: enable openapi spec from url in api register

* refactor: set spec definition as link format when link provided

* fix: fix style

* test: add error handling case for testing invalid spec url

* fix: fix test case

* fix: use 404 response url

* test: update case

* test: update test case

* refactor: update error logic
* test: update test case to setup live test pipeline (#75)

* test: update test case

* update

* .

* .

* .

* .

* .

* .

* .

* .

* .

* .

* .

* test: update test case

* refactor: enable both identity

* fix: bad if else

* fix: fix bad parameter
* refactor: add example

* fix: update params

* fix: bad api id
* refactor: add example

* fix: update params

* fix: bad api id

* refactor: add @filename.json examples

* refactor: update
* refactor: add error handling

* refactor: catch internal error

* fix: revert the change
* feat: add APIM/APIC sync commands

* feat: rename apim to azure-api-management

* style: fix code style

* fix: sync property names with new API spec

* Revert "fix: sync property names with new API spec"

This reverts commit 04da67e.

---------

Co-authored-by: frankqianms <[email protected]>
* feat: resolve feedback and fix examples

* style: fix code style
* feat: add APIM/APIC sync commands

* feat: rename apim to azure-api-management

* style: fix code style

* fix: sync property names with new API spec

* feat: add aws api gateway sync command

* Revert "fix: sync property names with new API spec"

This reverts commit 04da67e.

* refactor: add amazonApiGatewaySource

* refactor: refactoring apim sync and amazon sync

* refactor: refactor cmd structure to make apim and aws sync seperated

* fix: remove log print

* chore: generate new cmds

* refactor: update version and remove import

* feat: add `apic integration create amazon-api-gateway`

* fix: style

* fix: change query param api-version

* revert changes in _delete.py

* fix: some neede fixs

* fix: add the help sentence

* refactor: make params clear

* refactor: handle msi-resource-id

* refacor: revert flatten of apim resource

* fix: use 06-01-preiew currently

* fix: style

* refactor: arg groups

* fix: bad short param name

* chore: re-generate

* fix: old resource_id name

* chore: arg group

* chore: naming

* fix: fix according to comments

* chore: update

* fix: style

---------

Co-authored-by: Chaoyi Yuan <[email protected]>
* feat: add import amazon-api-gateway cmd

* feat: change arg group and update parameter name

---------

Co-authored-by: Chaoyi Yuan <[email protected]>
* feat: rename command and param names

* doc: update comments

* doc: update sample
…apic integration create aws` (#86)

* test: add test case for apim sync

* refactor: refactor for apim preparer

* refactor: refactoring case and utils, optimize checkers

* chore: remove print and add explaination

* refactor: rename file

* fix: try to fix error determing the version

* revert: Remove specific azure-cli and azure-core installations

* test: add aws sync testcase (#87)

* test: add test case for aws sync command

* fix: remove key value

* fix: remove pip install

* chore: renaming constants

* refactor: update the utils and test case

* refactor: updated
Copy link

azure-client-tools-bot-prd bot commented Jan 13, 2025

⚠️Azure CLI Extensions Breaking Change Test
⚠️apic-extension
rule cmd_name rule_message suggest_message
⚠️ 1011 - SubgroupAdd apic import sub group apic import added
⚠️ 1011 - SubgroupAdd apic integration sub group apic integration added

Copy link

Hi @frankqianms,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

Copy link

Hi @frankqianms,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

@yonzhan
Copy link
Collaborator

yonzhan commented Jan 13, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

Copy link

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

Copy link

github-actions bot commented Jan 13, 2025

@github-actions github-actions bot added the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Jan 13, 2025
@AllyW AllyW added the preview release extension module as preview label Jan 13, 2025
@yonzhan yonzhan requested review from kairu-ms and jsntcy January 13, 2025 02:55
@github-actions github-actions bot removed the release-version-block Updates do not qualify release version rules. NOTE: please do not edit it manually. label Jan 13, 2025
frankqianms and others added 2 commits January 13, 2025 10:58
@frankqianms frankqianms marked this pull request as draft January 13, 2025 03:02
@frankqianms frankqianms marked this pull request as ready for review January 15, 2025 02:28
Copy link
Contributor

@blackchoey blackchoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kairu-ms
Copy link
Contributor

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

Copy link
Contributor

@kairu-ms kairu-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the failed CI task

@frankqianms
Copy link
Member Author

Please fix the failed CI task

They are not secrets.

@kairu-ms kairu-ms merged commit 7f9035b into Azure:main Jan 17, 2025
21 of 22 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ apic-extension-1.2.0b1 ] : https://dev.azure.com/msazure/One/_build/results?buildId=112754499&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview release extension module as preview
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants