build: move update version logic to workflow #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenytang-ms
approved these changes
Apr 9, 2024
wenytang-ms
reviewed
Apr 9, 2024
| run: | | ||
| python ./github/workflows/update_version.py |
There was a problem hiding this comment.
maybe .github/workflows/update_version.py not ./github/...
There was a problem hiding this comment.
Yes, that's another problem. But since I'm not checking out new branch from main, feature branch won't have this .py file under .github. Seems it's better to put the python code to workflow file?
There was a problem hiding this comment.
It will be all right, you can take any way to run python code.
blackchoey
added a commit
that referenced
this pull request
Jul 17, 2024
* build: add cicd pipeline (#7) * build: move update version logic to workflow (#8) * build: Run CI on multiple python version (#38) * build: Run CI in Python 3.8-3.11 * build: remove pull request event for CI to avoid duplicate runs * test: add test cases for commands (#40) * fix: error when register API with long description spec (#41) * test: add test cases for optional parameters (#42) * feat!: remove file name param (#43) * fix: error not thrown when import spec with >3MB file (#44) * feat!: remove state param for deployment commands (#46) * fix: API title created by register command is not same with provided spec (#47) * feat!: redesign parameters to specify APIM instance for import-from-apim command (#45) * test: clean up legacy test cases (#48) * test: add test cases for command examples (#49) * docs: update help message per feedback (#50) * build: bump version to 1.0.0 and add changelog (#51) * fix: some parameters should be required in import-specification and deployment command (#53) * feat!: rename parameter names to align with other Azure CLI command experience (#52) * test: enable test for import-from-apim (#54) * test: fix show service test case (#55) * docs: update changelog for 1.0.0 (#56) * Update HISTORY.rst - jukasper updated changelog * Update HISTORY.rst * Update HISTORY.rst * Update HISTORY.rst * Update HISTORY.rst * Update HISTORY.rst * Update HISTORY.rst * Update HISTORY.rst * Update HISTORY.rst * Update HISTORY.rst * Update HISTORY.rst * Update HISTORY.rst * Update HISTORY.rst * Update HISTORY.rst * Update HISTORY.rst * Update HISTORY.rst * Update HISTORY.rst * docs: update readme for apic-extension (#57) * fix: cannot run create command against existing resource (#58) * fix: cannot run create command against existing resource * style: fix style * build: remove cicd pipeline (#59) * build: resolve review comments (#60) --------- Co-authored-by: Julia Kasper <[email protected]>
frankqianms
added a commit
that referenced
this pull request
Oct 10, 2024
* build: add cicd pipeline (#7) * build: move update version logic to workflow (#8) * build: Run CI on multiple python version (#38) * build: Run CI in Python 3.8-3.11 * build: remove pull request event for CI to avoid duplicate runs * refactor: add apic api update example * tests: add test case * fix: fix style * fix: fix test case * fix: fix test case * fix: fix test case & add recording * fix: remove bad command prefix * refactor: optimize test case code * refactor: remove duplicate example for apic create * fix: fix style * feat: add examples for create & update apic service with system assigned identity * fix: fix external doc extracting bug in spec * fix: remove extra print * fix: fix style * fix: fix style * fix: fix style * fix: fix style * tests: fix test case * refactor: remove external docs from tags * tests: update test case * refactor: remove summary setting in api register * feat: support custom metadata export only * fix: fix test case * tests: add test case * fix: fix arg type * refactor: add help example * fix: fix bad logic of link format * refactor: remove extra example * refactor: update example * doc: update 1.0.1 release history * refactor: change note style * fix: fix * fix: remove breaking change label * build: bump version to 1.1.0 * Update V1.1.0 history (#71) * Update HISTORY.rst * Update HISTORY.rst * Update HISTORY.rst --------- Co-authored-by: Julia Kasper <[email protected]> * test: fix test cases * build: remove files to get ready for release --------- Co-authored-by: Chaoyi Yuan <[email protected]> Co-authored-by: Julia Kasper <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The feature branch does not have the CICD related files. So move the update version logic to workflow to avoid failures.