Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: integration examples and bad example for apic update #91

Merged
merged 2 commits into from
Jan 13, 2025
Merged

refactor: integration examples and bad example for apic update #91

merged 2 commits into from
Jan 13, 2025

Conversation

frankqianms
Copy link
Collaborator

This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@frankqianms frankqianms changed the title refactor: integration examples refactor: integration examples and bad example for apic update Jan 10, 2025
blackchoey
blackchoey approved these changes Jan 13, 2025
View reviewed changes
Copy link
Owner

@blackchoey blackchoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add test cases for all the examples, so we can ensure the examples won't fail when making changes. Feel free to do this in another PR.

@frankqianms frankqianms merged commit d2cf45b into dev Jan 13, 2025
4 checks passed
@frankqianms frankqianms deleted the frank/integration-update branch January 13, 2025 02:58
frankqianms added a commit that referenced this pull request Jan 21, 2025
@frankqianms @blackchoey
build: apic-extension 1.2.0b1 release (Azure#8411)
7f9035b 
* build: add cicd pipeline (#7)

* build: move update version logic to workflow (#8)

* build: Run CI on multiple python version (#38)

* build: Run CI in Python 3.8-3.11

* build: remove pull request event for CI to avoid duplicate runs

* feat: enable openapi spec from url in api register (#74)

* feat: enable openapi spec from url in api register

* refactor: set spec definition as link format when link provided

* fix: fix style

* test: add error handling case for testing invalid spec url

* fix: fix test case

* fix: use 404 response url

* test: update case

* test: update test case

* refactor: update error logic

* test: update test case to setup live test pipeline (#76)

* test: update test case to setup live test pipeline (#75)

* test: update test case

* update

* .

* .

* .

* .

* .

* .

* .

* .

* .

* .

* .

* test: update test case

* refactor: enable both identity

* fix: bad if else

* fix: fix bad parameter

* refactor: add example (#77)

* refactor: add example

* fix: update params

* fix: bad api id

* refactor: add @filename.json examples (#78)

* refactor: add example

* fix: update params

* fix: bad api id

* refactor: add @filename.json examples

* refactor: update

* refactor: add error handling (#79)

* refactor: add error handling

* refactor: catch internal error

* fix: revert the change

* feat: support APIM/APIC sync (#80)

* feat: add APIM/APIC sync commands

* feat: rename apim to azure-api-management

* style: fix code style

* fix: sync property names with new API spec

* Revert "fix: sync property names with new API spec"

This reverts commit 04da67e.

---------

Co-authored-by: frankqianms <[email protected]>

* feat: resolve feedback and fix examples (#82)

* feat: resolve feedback and fix examples

* style: fix code style

* feat: amazon api gateway sync (#81)

* feat: add APIM/APIC sync commands

* feat: rename apim to azure-api-management

* style: fix code style

* fix: sync property names with new API spec

* feat: add aws api gateway sync command

* Revert "fix: sync property names with new API spec"

This reverts commit 04da67e.

* refactor: add amazonApiGatewaySource

* refactor: refactoring apim sync and amazon sync

* refactor: refactor cmd structure to make apim and aws sync seperated

* fix: remove log print

* chore: generate new cmds

* refactor: update version and remove import

* feat: add `apic integration create amazon-api-gateway`

* fix: style

* fix: change query param api-version

* revert changes in _delete.py

* fix: some neede fixs

* fix: add the help sentence

* refactor: make params clear

* refactor: handle msi-resource-id

* refacor: revert flatten of apim resource

* fix: use 06-01-preiew currently

* fix: style

* refactor: arg groups

* fix: bad short param name

* chore: re-generate

* fix: old resource_id name

* chore: arg group

* chore: naming

* fix: fix according to comments

* chore: update

* fix: style

---------

Co-authored-by: Chaoyi Yuan <[email protected]>

* feat: add import amazon-api-gateway cmd (#83)

* feat: add import amazon-api-gateway cmd

* feat: change arg group and update parameter name

---------

Co-authored-by: Chaoyi Yuan <[email protected]>

* fix: use older version API (#84)

* feat: rename command and param names (#85)

* feat: rename command and param names

* doc: update comments

* doc: update sample

* test: add test case for sync cmd `apic integration create apim` and `apic integration create aws` (#86)

* test: add test case for apim sync

* refactor: refactor for apim preparer

* refactor: refactoring case and utils, optimize checkers

* chore: remove print and add explaination

* refactor: rename file

* fix: try to fix error determing the version

* revert: Remove specific azure-cli and azure-core installations

* test: add aws sync testcase (#87)

* test: add test case for aws sync command

* fix: remove key value

* fix: remove pip install

* chore: renaming constants

* refactor: update the utils and test case

* refactor: updated

* fix: workaround for urllib3 package (#88)

* Revert "fix: workaround for urllib3 package (#88)" (#90)

This reverts commit 1d508f4.

* build: 1.2.0 beta 1 release

* build: remove CI and CD files

* doc: improve history

* fix: set extention version to be preview

* refactor: integration examples and bad example for `apic update` (#91)

* refactor: integration examples

* fix: apic update example

* chore: update log

* test: add import-aws case and modify region

---------

Co-authored-by: Chaoyi Yuan <[email protected]>
Co-authored-by: Chaoyi Yuan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blackchoey blackchoey blackchoey approved these changes

@arpishahmsft arpishahmsft Awaiting requested review from arpishahmsft arpishahmsft is a code owner

@adashen adashen Awaiting requested review from adashen adashen is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frankqianms @blackchoey