GIVCAMP-88 | data card #245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ne height in TW theme
* dev: 1.2.2 GIVCAMP-294 | Basic Hero overlay options and image optimization (#243) HSTS set max-age to 31536000 (#242) 1.2.1 Icon animation (#240) GIVCAMP-304 | Add CTA region to Section and Homepage Theme/Story Section (#239)
✅ Deploy Preview for giving-campaign ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
yvonnetangsu
commented
Mar 12, 2024
Comment on lines
+54
to
+57
| {/* If number counter is enabled, aria-hidden the animated heading and add a SR only heading */} | ||
| {isCounter && heading && ( | ||
| <Heading as={headingLevel} srOnly>{heading}</Heading> | ||
| )} |
There was a problem hiding this comment.
If there is a number counter in the heading, add a SR only heading with all static heading, then aria-hidden the visible heading with the number counter.
yvonnetangsu
commented
Mar 12, 2024
| @@ -1,11 +1,11 @@ | |||
| # [Giving Campaign (Stanford On Purpose)](https://github.com/SU-SWS/ood-giving-campaign) | |||
| # [Stanford Momentum](https://github.com/SU-SWS/ood-giving-campaign) | |||
There was a problem hiding this comment.
Updating some readme
yvonnetangsu
commented
Mar 12, 2024
Comment on lines
+1
to
+9
| /** | ||
| * Momentum line heights | ||
| */ | ||
| module.exports = function () { | ||
| return { | ||
| // Extra tight line height for Druk font in some components, e.g., Data Card, Moment Poster | ||
| druk: '0.9', | ||
| }; | ||
| }; |
There was a problem hiding this comment.
Add extra tight leading utility for Druk font that are used in a few places
sherakama
reviewed
Mar 12, 2024
| }); | ||
|
|
||
| export const heading = 'rs-mb-3 ml-22 whitespace-pre-line mt-auto'; | ||
| export const body = '*:*:leading-snug'; |
|
@sherakama I think I'm going to merge this and cut a release. It doesn't affect anything that's published so it's pretty safe 😄 If you see anything you're concerned about LMK |
Merged
yvonnetangsu
added a commit
that referenced
this pull request
Apr 2, 2024
* dev: (34 commits) GIVCAMP-292 GIVCAMP-305 | Horizontal Initiative card and image aspect ratio options (#256) 1.3.3 Update robots to use different URL for sitemap path (#254) 1.3.2 GIVCAMP-307 | Stacked story hero variant (#251) 1.3.1 GIVCAMP-297 GIVCAMP-312 | Section background options + add light overlay options (#248) Bump follow-redirects from 1.15.4 to 1.15.6 (#249) 1.3.0 GIVCAMP-289: Inline External Script Loading. (#246) GIVCAMP-88 | data card (#245) 1.2.2 GIVCAMP-294 | Basic Hero overlay options and image optimization (#243) HSTS set max-age to 31536000 (#242) 1.2.1 Icon animation (#240) GIVCAMP-304 | Add CTA region to Section and Homepage Theme/Story Section (#239) 1.2.0 GIVCAMP-293 | Moment poster (#236) NoJira: Remove Editor Token (#237) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
READY FOR REVIEW
Summary
Review By (Date)
Criticality
Review Tasks
Setup tasks and/or behavior to test
Go to storyblok test/test-initiative-template page
Select the PR245 preview URL in the visual editor
Scroll down to see data cards in dark and light mode.
Check that the cards with number counter enabled, the number in the heading counts up once the card comes into view.
Associated Issues and/or People