Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GIVCAMP-297 GIVCAMP-312 | Section background options + add light overlay options #248

Merged
merged 6 commits into from
Mar 18, 2024
Merged

GIVCAMP-297 GIVCAMP-312 | Section background options + add light overlay options #248

merged 6 commits into from
Mar 18, 2024

Conversation

yvonnetangsu
Copy link
Member

@yvonnetangsu yvonnetangsu commented Mar 16, 2024 •
edited
Loading

READY FOR REVIEW

Summary

  • Adding more background options for Section and Homepage Theme/Story Section components
  • Add light overlay and dark/light theme options to Section/Homepage ThemeStory/Moment poster
  • replace all w-full h-full classes with size-full

Review By (Date)

  • Retro

Review Tasks

Setup tasks and/or behavior to test

  1. Pull down locally and review on the test/test-initiative-template page
  2. Check homepage on the preview that it still looks ok

Associated Issues and/or People

@netlify Netlify
Copy link

netlify bot commented Mar 16, 2024 •
edited
Loading

✅ Deploy Preview for giving-campaign ready!

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/sites/giving-campaign/deploys/65f8c2b00344f728f2db1790
😎 Deploy Preview https://deploy-preview-248--giving-campaign.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@yvonnetangsu yvonnetangsu changed the title GIVCAMP-297 | Section background options GIVCAMP-297 GIVCAMP-312 | Section background options + add light overlay options Mar 18, 2024
@yvonnetangsu yvonnetangsu requested a review from sherakama March 18, 2024 22:21
@yvonnetangsu
Copy link
Member Author

You know the deal @sherakama - pushing this through 🤠

@yvonnetangsu yvonnetangsu merged commit 395be37 into dev Mar 18, 2024
5 checks passed
@yvonnetangsu yvonnetangsu deleted the feature/GIVCAMP-297_section-bg-options branch March 18, 2024 22:48
@yvonnetangsu yvonnetangsu mentioned this pull request Mar 18, 2024
Merged
yvonnetangsu added a commit that referenced this pull request Apr 2, 2024
@yvonnetangsu
Merge branch 'dev' into feature/GIVCAMP-282_react-player-light
f23df9b 
* dev: (34 commits)
  GIVCAMP-292 GIVCAMP-305 | Horizontal Initiative card and image aspect ratio options (#256)
  1.3.3
  Update robots to use different URL for sitemap path (#254)
  1.3.2
  GIVCAMP-307 | Stacked story hero variant (#251)
  1.3.1
  GIVCAMP-297 GIVCAMP-312 | Section background options + add light overlay options (#248)
  Bump follow-redirects from 1.15.4 to 1.15.6 (#249)
  1.3.0
  GIVCAMP-289: Inline External Script Loading. (#246)
  GIVCAMP-88 | data card (#245)
  1.2.2
  GIVCAMP-294 | Basic Hero overlay options and image optimization (#243)
  HSTS set max-age to 31536000 (#242)
  1.2.1
  Icon animation (#240)
  GIVCAMP-304 | Add CTA region to Section and Homepage Theme/Story Section (#239)
  1.2.0
  GIVCAMP-293 | Moment poster (#236)
  NoJira: Remove Editor Token (#237)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sherakama sherakama Awaiting requested review from sherakama

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@yvonnetangsu