Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GIVCAMP-295 | Add Icon type and animation options to CTA #240

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

yvonnetangsu
Copy link
Member

READY FOR REVIEW

Summary

  • Add more icon types and new option icon animation for the CTA component in Storyblok

Review By (Date)

  • Retro

Criticality

  • 3

Review Tasks

Setup tasks and/or behavior to test

  1. Pull down locally
  2. Go to test/yvonne-test-volunteer-leadership-summit
  3. Scroll to bottom of the photo gallery
  4. Check that you can now pick more icons, also pick animation for the icon for the CTA component

Screenshot 2024-03-04 at 4 24 11 PM
Screenshot 2024-03-04 at 4 24 36 PM

Associated Issues and/or People

@yvonnetangsu yvonnetangsu requested a review from sherakama March 5, 2024 00:27
Copy link

netlify bot commented Mar 5, 2024

Deploy Preview for giving-campaign ready!

Name Link
🔨 Latest commit 496952f
🔍 Latest deploy log https://app.netlify.com/sites/giving-campaign/deploys/65e666d4bbe8080008c6c5e8
😎 Deploy Preview https://deploy-preview-240--giving-campaign.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Comment on lines +76 to +78
'triangle-right': 'w-09em scale-x-90 mt-01em',
'triangle-down': 'w-09em scale-x-90 rotate-90 mt-01em',
'triangle-up': 'w-09em scale-x-90 -rotate-90 mt-02em',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace scale-x-[0.9] with scale-x-90

@yvonnetangsu
Copy link
Member Author

This is also getting merged 🤠

@yvonnetangsu yvonnetangsu merged commit 879b341 into dev Mar 5, 2024
5 checks passed
@yvonnetangsu yvonnetangsu deleted the feature/GIVCAMP-295_cta-icon-options branch March 5, 2024 00:31
@yvonnetangsu yvonnetangsu mentioned this pull request Mar 5, 2024
yvonnetangsu added a commit that referenced this pull request Mar 6, 2024
* dev:
  1.2.2
  GIVCAMP-294 | Basic Hero overlay options and image optimization (#243)
  HSTS set max-age to 31536000 (#242)
  1.2.1
  Icon animation (#240)
  GIVCAMP-304 | Add CTA region to Section and Homepage Theme/Story Section (#239)
yvonnetangsu added a commit that referenced this pull request Apr 2, 2024
* dev: (34 commits)
  GIVCAMP-292 GIVCAMP-305 | Horizontal Initiative card and image aspect ratio options (#256)
  1.3.3
  Update robots to use different URL for sitemap path (#254)
  1.3.2
  GIVCAMP-307 | Stacked story hero variant (#251)
  1.3.1
  GIVCAMP-297 GIVCAMP-312 | Section background options + add light overlay options (#248)
  Bump follow-redirects from 1.15.4 to 1.15.6 (#249)
  1.3.0
  GIVCAMP-289: Inline External Script Loading. (#246)
  GIVCAMP-88 | data card (#245)
  1.2.2
  GIVCAMP-294 | Basic Hero overlay options and image optimization (#243)
  HSTS set max-age to 31536000 (#242)
  1.2.1
  Icon animation (#240)
  GIVCAMP-304 | Add CTA region to Section and Homepage Theme/Story Section (#239)
  1.2.0
  GIVCAMP-293 | Moment poster (#236)
  NoJira: Remove Editor Token (#237)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant