Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v1.3.0 #247

Merged
merged 3 commits into from
Mar 13, 2024
Merged

Release v1.3.0 #247

merged 3 commits into from
Mar 13, 2024

Conversation

yvonnetangsu
Copy link
Member

@yvonnetangsu yvonnetangsu commented Mar 12, 2024

READY FOR REVIEW

Summary

Review By (Date)

  • Mar 13

Criticality

  • 5

Review Tasks

Setup tasks and/or behavior to test

  1. Look at code diff
  2. Check preview that nothing's broken

su-sws-jira and others added 3 commits March 5, 2024 20:12
* DataCard setup; replace "Giving Campaign" with "Momentum"; add new line height in TW theme

* Add druk leading option

* DataCard styles WIP

* Number counter and full height within grid

* Modify demo content because props changed

* counter function

* clean up

* Accessible headings; remove isSmallHeading prop
* GIVCAMP-289: Inline External Script Loading.

* GIVCAMP-289: Clean up script on unmount.

* Update SbEmbed.tsx

* fixup! Types.

* Update components/Storyblok/SbEmbed.tsx

Co-authored-by: Yvonne Tang <[email protected]>

* Update components/Embed/Embed.tsx

Co-authored-by: Yvonne Tang <[email protected]>

---------

Co-authored-by: Yvonne Tang <[email protected]>
Copy link

netlify bot commented Mar 12, 2024

Deploy Preview for giving-campaign ready!

Name Link
🔨 Latest commit 787545f
🔍 Latest deploy log https://app.netlify.com/sites/giving-campaign/deploys/65f0df018dffce00083ea379
😎 Deploy Preview https://deploy-preview-247--giving-campaign.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@yvonnetangsu yvonnetangsu requested a review from sherakama March 12, 2024 23:03
@yvonnetangsu
Copy link
Member Author

@sherakama I'm going to push this through as it doesn't affect anything that's published 🤠

@yvonnetangsu yvonnetangsu merged commit c9098c2 into main Mar 13, 2024
6 checks passed
@yvonnetangsu yvonnetangsu deleted the release/v1.3.0 branch March 13, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants