Skip to content
This repository has been archived by the owner on Feb 3, 2023. It is now read-only.

Google Seeds #299

Merged
merged 2 commits into from
Jan 22, 2021
Merged

Google Seeds #299

merged 2 commits into from
Jan 22, 2021

Conversation

slemrmartin
Copy link
Contributor

@slemrmartin slemrmartin commented Jan 15, 2021

Source Type and ApplicationType seeds for Google Cloud Engine


RHCLOUD-11249

@slemrmartin slemrmartin requested a review from rvsia January 15, 2021 13:54
@slemrmartin
Copy link
Contributor Author

cc @dccurtis

@slemrmartin
Copy link
Contributor Author

@dccurtis availability check url will be the same like for aws? /api/cost-management/v1/source-status/

@dccurtis
Copy link

@dccurtis availability check url will be the same like for aws? /api/cost-management/v1/source-status/

Yes, no difference there

:schema:
:authentication:
- :type: username_password
:name: Project ID and Service Account JSON

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the Service Account JSON going to be used to seed the service account email for the wizard?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know, but in the credentials provided by QE there is a client_email key-value in the JSON

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there other use cases for GCP that you are working on besides Cost Management?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is and oportunity for topological-inventory collector, but we don't have any milestone for that as far as i know

db/seeds/source_types.yml Outdated Show resolved Hide resolved
- :component: textarea
:name: authentication.password
:label: Service Account JSON
:endpoint:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would we be able to leverage the new Application extra field to store the dataset?

Something like this

      - :name: application.extra.dataset
        :stepKey: cost-management
        :component: text-field
        :label: Dataset name
        :isRequired: true

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I agree! 👍 We will do it anyway in the future and doing it now will prevent any painful migration.

(You should also provide a validate in that object:

        :validate:
        - :type: required

isRequired is just a boolean to show the required marker.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

db/seeds/source_types.yml Outdated Show resolved Hide resolved
db/seeds/source_types.yml Outdated Show resolved Hide resolved
:icon_url: "/apps/chrome/assets/images/partners-icons/google-cloud-engine.svg" # TODO
:schema:
:authentication:
- :type: username_password
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should describe it more accurately as we don't actually provide any username or password - project_id maybe ?.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed to project_id_service_account_json

@dippy-bot
Copy link

Checked commits slemrmartin/sources-api@61ff6fb~...0294494 with ruby 2.5.7, rubocop 0.82.0, haml-lint 0.35.0, and yamllint
0 files checked, 0 offenses detected
Everything looks fine. ⭐

Copy link
Contributor

@rvsia rvsia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dccurtis
Copy link

Thanks for adding the extra field for dataset! I'll update on my side to query for project_id_service_account_json to get the project_id from the username field 👍

@lindgrenj6 lindgrenj6 merged commit 61d2dbb into RedHatInsights:master Jan 22, 2021
@slemrmartin slemrmartin deleted the google-type branch January 26, 2021 10:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants