-
Notifications
You must be signed in to change notification settings - Fork 31
Conversation
cc @dccurtis |
@dccurtis availability check url will be the same like for aws? |
64f44b4
to
2bafeb6
Compare
Yes, no difference there |
:schema: | ||
:authentication: | ||
- :type: username_password | ||
:name: Project ID and Service Account JSON |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is the Service Account JSON going to be used to seed the service account email for the wizard?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know, but in the credentials provided by QE there is a client_email
key-value in the JSON
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Anyway, I started from the ManageIQ's create form: https://files.gitter.im/5aa15e4ad73408ce4f907617/dsFs/Screenshot-2021-01-15-at-10.44.16.png
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there other use cases for GCP that you are working on besides Cost Management?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is and oportunity for topological-inventory collector, but we don't have any milestone for that as far as i know
- :component: textarea | ||
:name: authentication.password | ||
:label: Service Account JSON | ||
:endpoint: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would we be able to leverage the new Application
extra
field to store the dataset
?
Something like this
- :name: application.extra.dataset
:stepKey: cost-management
:component: text-field
:label: Dataset name
:isRequired: true
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I agree! 👍 We will do it anyway in the future and doing it now will prevent any painful migration.
(You should also provide a validate in that object:
:validate:
- :type: required
isRequired
is just a boolean to show the required marker.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added
2bafeb6
to
61ff6fb
Compare
db/seeds/source_types.yml
Outdated
:icon_url: "/apps/chrome/assets/images/partners-icons/google-cloud-engine.svg" # TODO | ||
:schema: | ||
:authentication: | ||
- :type: username_password |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should describe it more accurately as we don't actually provide any username or password - project_id
maybe ?.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed to project_id_service_account_json
a2092a9
to
0294494
Compare
Checked commits slemrmartin/sources-api@61ff6fb~...0294494 with ruby 2.5.7, rubocop 0.82.0, haml-lint 0.35.0, and yamllint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Thanks for adding the extra field for dataset! I'll update on my side to query for |
Source Type and ApplicationType seeds for Google Cloud Engine
RHCLOUD-11249