-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
COST-716: Finalizing GCP sources and supporting app-specific settings for AWS and Azure #2609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p_sources_update
…p_sources_update
Codecov Report
@@ Coverage Diff @@
## master #2609 +/- ##
========================================
- Coverage 94.8% 94.7% -0.1%
========================================
Files 281 281
Lines 21230 21327 +97
Branches 2412 2432 +20
========================================
+ Hits 20123 20203 +80
- Misses 665 673 +8
- Partials 442 451 +9 |
E2E Deploy update for GCP: |
maskarb
approved these changes
Jan 25, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GCP integration changes are coded against: RedHatInsights/sources-api#299 which should be merging today.
UPDATE:
The sources team agreed to use the new
Applications.extra
value to hold the dataset (was previously using PATCH). This change also brings along support for AWS and Azure to also use the newextra
field while at the same time maintaining backwards compatibility with PATCH for AWS and Azure. Data migrations in all environments must happen before we decommission the PATCH path for AWS and Azure.Testing
Test Results
cost_716_ut.txt