Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

COST-716: Finalizing GCP sources and supporting app-specific settings for AWS and Azure #2609

Merged
merged 24 commits into from
Jan 25, 2021

Conversation

dccurtis
Copy link
Contributor

@dccurtis dccurtis commented Jan 22, 2021

GCP integration changes are coded against: RedHatInsights/sources-api#299 which should be merging today.

UPDATE:

  • Change merged and it works great against this PR

The sources team agreed to use the new Applications.extra value to hold the dataset (was previously using PATCH). This change also brings along support for AWS and Azure to also use the new extra field while at the same time maintaining backwards compatibility with PATCH for AWS and Azure. Data migrations in all environments must happen before we decommission the PATCH path for AWS and Azure.

Testing

  1. Regression test AWS source creation with PATCH
  2. Regression test Azure source creation with PATCH
  3. Add AWS source with Application-extra flow
  4. Add Azure source with Application-extra flow
  5. Update AWS bucket for source_id =3 (Application.extra path) to an incorrect bucket and verify status is updated accordingly
  6. Add GCP source (using WIP sources branch) with an invalid project name (verify status is correct). Fix project name and verify source is created successfully.

Test Results
cost_716_ut.txt

@dccurtis dccurtis requested a review from a team January 22, 2021 12:25
@dccurtis dccurtis self-assigned this Jan 22, 2021
@codecov
Copy link

codecov bot commented Jan 22, 2021

Codecov Report

Merging #2609 (93446d9) into master (0bf63d7) will decrease coverage by 0.1%.
The diff coverage is 89.2%.

@@           Coverage Diff            @@
##           master   #2609     +/-   ##
========================================
- Coverage    94.8%   94.7%   -0.1%     
========================================
  Files         281     281             
  Lines       21230   21327     +97     
  Branches     2412    2432     +20     
========================================
+ Hits        20123   20203     +80     
- Misses        665     673      +8     
- Partials      442     451      +9     

@dccurtis dccurtis marked this pull request as ready for review January 22, 2021 14:59
@dccurtis
Copy link
Contributor Author

E2E Deploy update for GCP:
https://github.com/RedHatInsights/e2e-deploy/pull/2678

Copy link
Member

@maskarb maskarb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dccurtis dccurtis merged commit fa658c2 into master Jan 25, 2021
@dccurtis dccurtis deleted the gcp_sources_update branch January 25, 2021 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants