Skip to content
This repository has been archived by the owner on Feb 3, 2023. It is now read-only.

Google Seeds #299

Merged
merged 2 commits into from
Jan 22, 2021
Merged

Google Seeds #299

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
61ff6fb
Google Seeds
slemrmartin Jan 15, 2021
0294494
Google seeds update
slemrmartin Jan 22, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions db/seeds/application_types.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,12 +14,15 @@
:supported_source_types:
- amazon
- azure
- google
- openshift
:supported_authentication_types:
amazon:
- arn
azure:
- tenant_id_client_id_client_secret
google:
- username_password
openshift:
- token
"/insights/platform/cloud-meter":
Expand Down
28 changes: 28 additions & 0 deletions db/seeds/source_types.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,34 @@ ansible-tower:
:condition:
:when: endpoint.verify_ssl
:is: true
google:
:product_name: Google Cloud Engine
slemrmartin marked this conversation as resolved.
Show resolved Hide resolved
:vendor: Google
:icon_url: "/apps/chrome/assets/images/partners-icons/google-cloud-engine.svg" # TODO
slemrmartin marked this conversation as resolved.
Show resolved Hide resolved
:schema:
:authentication:
- :type: username_password
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should describe it more accurately as we don't actually provide any username or password - project_id maybe ?.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed to project_id_service_account_json

:name: Project ID and Service Account JSON
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the Service Account JSON going to be used to seed the service account email for the wizard?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know, but in the credentials provided by QE there is a client_email key-value in the JSON

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anyway, I started from the ManageIQ's create form: https://files.gitter.im/5aa15e4ad73408ce4f907617/dsFs/Screenshot-2021-01-15-at-10.44.16.png

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there other use cases for GCP that you are working on besides Cost Management?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is and oportunity for topological-inventory collector, but we don't have any milestone for that as far as i know

:fields:
- :component: text-field
:name: authentication.authtype
:hideField: true
:initializeOnMount: true
:initialValue: username_password
slemrmartin marked this conversation as resolved.
Show resolved Hide resolved
- :component: text-field
:name: authentication.username
:label: Project ID
- :component: textarea
:name: authentication.password
:label: Service Account JSON
:endpoint:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would we be able to leverage the new Application extra field to store the dataset?

Something like this

      - :name: application.extra.dataset
        :stepKey: cost-management
        :component: text-field
        :label: Dataset name
        :isRequired: true

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I agree! 👍 We will do it anyway in the future and doing it now will prevent any painful migration.

(You should also provide a validate in that object:

        :validate:
        - :type: required

isRequired is just a boolean to show the required marker.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added

:hidden: true
:fields:
- :component: text-field
:name: endpoint.role
:hideField: true
:initializeOnMount: true
:initialValue: google
azure:
:product_name: Microsoft Azure
:vendor: Azure
Expand Down