Raise the minimum deployment target for macOS to 10.12 #2134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2. self._clock will eventually be set to virtualTime
…to MortyMerr-feature/map
…et Xcode automatically suggest a fix
typo, changed `thr` to `the`
…the view heirarchy
Thanks for your time.
(cherry picked from commit 0bab5e2)
…Reduce .asObservable useless calls
A couple of print statements were missing. The print output should line up correctly with the code now.
that elements are -> those elements are
|
Thanks for making this! Overall I’m not against, but 6.0 will take some time either way so it will not immediately solve the issues Apple randomly broke, which makes this a bit tricky. Regardless, labeling this for 6.0. |
NSTextView did not support weak references until this macOS release. Xcode 11.4 has started to call this out, as before this commit, the project has been targeting macOS 10.9. Fixes ReactiveX#2125.
tonyarnold
force-pushed
the
raise-macos-deployment-target-to-10.12
branch
from
cbe5a22 to
aebd535
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes to raise the minimum deployment version for macOS targets to macOS 10.12 "Sierra". Fixes #2125.
I also investigated using some combination of availability checks, but these approaches all required duplication of the
RxTextViewDelegateProxytype.Given that there's a major release of RxSwift in development at the time of writing this PR, this seems to me to be a good time to make a change to the base requirements of the library.
I understand that folks (:wave: @freak4pc) would prefer to wait to see whether Apple chooses to leave the error diagnostic that is causing #2125 in future builds of Xcode 11.4, but in either case the PR is here if you can make use of it.
As mentioned in #2125, I've filed FB7566796 about this with Apple, however the diagnostic is relevant and correct in its advice.