Extended Sample operation to support a default value

[aspitz]

Added the ability to set a default value for the sampler to return in the event that there were no new elements between sampler ticks

[RxPullRequestBot]

	1 Warning
⚠️	No CHANGELOG changes made

Generated by 🚫 Danger

[kzaher]

Let me think about this suggestion.

[freak4pc]

This is kinda interesting actually. Since this is purely additive there’s no real issue with adding this.

The only issue I’m seeing here is that it’s diverging from ReactiveX and from the original usage of sample (turning into something like an interval withLatestFrom).

Still could be an interesting addition 🤔🤔🤔 hard to say

[aspitz-intrepid]

@kzaher any further thoughts?

[freak4pc]

I still find this to be a good addition. More specifically, it would be quite hard accomplishing this behavior by combining other operators in RxSwift.

@aspitz any chance you'd be willing to bring this up-to-date to the latest standards or the repo? Otherwise, I can find someone else to take over this code.

[aspitz-intrepid]

I can fix this up :)

[freak4pc]

Awesome :) @aspitz-intrepid

[freak4pc]

Looks good, thank you! Just a few quick notes.

[freak4pc]

LGTM! Final nitpick and we can merge this. Thank you :)

[freak4pc]

Thank you ! @aspitz