forked from ReactiveX/RxSwift
-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RxSwift: change macOS minimum deployment to 10.13. #3
Closed
BenNunOhad
wants to merge
259
commits into
Lightricks:lightricks-6.5.0-fix-xcode-proj-warnings
from
BenNunOhad:feature/rxSwift/update-minimum-deployment
Closed
RxSwift: change macOS minimum deployment to 10.13. #3
BenNunOhad
wants to merge
259
commits into
Lightricks:lightricks-6.5.0-fix-xcode-proj-warnings
from
BenNunOhad:feature/rxSwift/update-minimum-deployment
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2. self._clock will eventually be set to virtualTime
…to MortyMerr-feature/map
…et Xcode automatically suggest a fix
typo, changed `thr` to `the`
Ensure that `convertURLRequestToCurlCommand(_:)` prints the httpBody for PUT requests.
(cherry picked from commit fd6fb2b)
Set the LastUpgradeCheck to `1500` which corresponds to Xcode 15 (that supposed to be announced in ~1 year from now) to eliminate the Xcode proj file warnings. These warnings suggest to upgrade the proj file and raise the deployment target. This should "buy" at least one year w/o these annoying warnings. Setting this number to `1500` will allow to face these (and perhaps other) warnings in next year and decide what we wanna do with them, since we don't wanna ignore them completely.
To prevent Xcode warnings.
To resolve compiler warnings.
BenNunOhad
force-pushed
the
feature/rxSwift/update-minimum-deployment
branch
from
July 12, 2023 12:44
db56948
to
ada9f0e
Compare
BenNunOhad
changed the base branch from
master
to
lightricks-6.5.0-fix-xcode-proj-warnings
July 12, 2023 12:52
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
convertURLRequestToCurlCommand(_:)
NSTextView
not weak for Swift 5.2 and up.asSignal
functionsdistinctUntilChanged(at:)
for Key PathsReactive
catchError(_:)
tocatch(_:)
elementAt(_:)
toelement(at:)
ignoreElements
returnObservable<Never>
subscribeOn
tosubscribe(on:)
catchErrorJustReturn
tocatchJustReturn
drive()
andemit()
ambiguity