Add Hooks documentation, remove unexpected logs #1988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freak4pc
requested changes
May 28, 2019
M0rtyMerr
force-pushed
the
feature/Hooks
branch
2 times, most recently
from
264514e to
762e25d
Compare
|
If there are English grammar issues, I will appreciate any help with fixing them :) |
freak4pc
reviewed
Jun 1, 2019
freak4pc
requested changes
Jun 3, 2019
freak4pc
approved these changes
Jun 3, 2019
freak4pc
pushed a commit
that referenced
this pull request
Feb 8, 2020
freak4pc
pushed a commit
that referenced
this pull request
Feb 8, 2020
freak4pc
pushed a commit
that referenced
this pull request
Feb 8, 2020
This was referenced Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hooksenum encapsulates quite useful logic for error handling/debugging, however, I didn't find any documentation about that. I am sure this enum could help users with debugging their apps, so my proposal is to add a description of it toGettingStarted.mdAlso, I add check on empty array. If the callstack array is empty user will see just "subscription called from:" and empty line, which might be quite confusing for him.