fix: adjust method signatures for Xcode 12.5 compatibility #2305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I just love Xcode's definition of "non breaking changes" 🤦 Thank you! |
freak4pc
approved these changes
Apr 9, 2021
|
That was already fixed in #2297 🤔 |
|
We don't work on develop anymore, I should fix that. Sorry for the confusion, didn't realize it's a dupe 🤭 |
|
No problem, fixing CONTRIBUTING.md would be a great idea 😄 |
paulo-bc
pushed a commit
to paulo-bc/RxSwift
that referenced
this pull request
May 6, 2021
…#2305) Co-authored-by: David Harris <[email protected]>
BenNunOhad
pushed a commit
to BenNunOhad/RxSwift
that referenced
this pull request
Jul 12, 2023
…#2305) Co-authored-by: David Harris <[email protected]>
GalBerezansky
pushed a commit
to GalBerezansky/RxSwift
that referenced
this pull request
Jul 23, 2023
…#2305) Co-authored-by: David Harris <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Xcode gives errors now around these function declarations starting in Xcode 12.5, tested in b3 and this properly adds the declarations as well as gets rid of what seems to be a now-unneeded ternary if.
This is needed for the new Xcode versions, as well as anything depending on those.